[GitHub] [netbeans] matthiasblaesing commented on pull request #2558: [NETBEANS-188] Add support for auto code completion in the SQL Editor

[GitBox <gi...@apache.org>]

matthiasblaesing commented on pull request #2558:
URL: https://github.com/apache/netbeans/pull/2558#issuecomment-743342632


   To be clear: I won't merge this as is, if someone else does be prepared for issues resulting from this. If code completion is invoked automatically and causes the metadata to fetched, this sounds like a cheap operation, but it is not. If you want to experience the real problem, take a SAP system, a slow WAN link and expend the tables. That is a worst case scenario, but I also observed slow meta data loading on loaded systems.
   
   In my mind, completion while typing should be quick and this means, network round trips are out of the question. You'd need to differentiate whether the user asked for completion explicitly or not. If not asked explicitly I would only complete from grammar and/or cached metadata, if explicitly invoked I would try to fetch metadata.


----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org



---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@netbeans.apache.org
For additional commands, e-mail: notifications-help@netbeans.apache.org

For further information about the NetBeans mailing lists, visit:
https://cwiki.apache.org/confluence/display/NETBEANS/Mailing+lists