You are viewing a plain text version of this content. The canonical link for it is here.

Posted to notifications@superset.apache.org by GitBox <gi...@apache.org> on 2021/08/26 10:20:19 UTC

[GitHub] [superset] villebro commented on a change in pull request #16463: chore(ci): bump pylint to 2.10.2

villebro commented on a change in pull request #16463:
URL: https://github.com/apache/superset/pull/16463#discussion_r696495797



##########
File path: .pylintrc
##########
@@ -86,6 +86,8 @@ disable=
     missing-docstring,
     too-many-lines,
     duplicate-code,
+    unspecified-encoding,

Review comment:
       I don't necessarily agree with this. While we could add `encoding="utf-8"` to all text file opens, this would likely break compatibility with Windows which defaults to `cp-1252`. So I recommend we disable this rule for now.




-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org



---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org
For additional commands, e-mail: notifications-help@superset.apache.org