You are viewing a plain text version of this content. The canonical link for it is here.
Posted to github@datafusion.apache.org by "LeslieKid (via GitHub)" <gi...@apache.org> on 2024/11/29 19:53:51 UTC
[PR] [POC] Fuse operations in `equal_rows_arr` [datafusion]
LeslieKid opened a new pull request, #13607:
URL: https://github.com/apache/datafusion/pull/13607
## Which issue does this PR close?
<!--
We generally require a GitHub issue to be filed for all bug fixes and enhancements and this helps us generate change logs for our releases. You can link an issue to this PR using the GitHub syntax. For example `Closes #123` indicates that this PR will close issue #123.
-->
Closes #12131 .
## Rationale for this change
<!--
Why are you proposing this change? If this is already explained clearly in the issue then this section is not needed.
Explaining clearly why changes are proposed helps reviewers understand your changes and offer better suggestions for fixes.
-->
## What changes are included in this PR?
<!--
There is no need to duplicate the description in the issue here but it is sometimes worth providing a summary of the individual changes in this PR.
-->
## Are these changes tested?
<!--
We typically require tests for all PRs in order to:
1. Prevent the code from being accidentally broken by subsequent changes
2. Serve as another way to document the expected behavior of the code
If tests are not included in your PR, please explain why (for example, are they covered by existing tests)?
-->
## Are there any user-facing changes?
<!--
If there are user-facing changes then we may require documentation to be updated before approving the PR.
-->
<!--
If there are any breaking changes to public APIs, please add the `api change` label.
-->
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: github-unsubscribe@datafusion.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: github-unsubscribe@datafusion.apache.org
For additional commands, e-mail: github-help@datafusion.apache.org
Re: [PR] [POC] Fuse operations in `equal_rows_arr` [datafusion]
Posted by "LeslieKid (via GitHub)" <gi...@apache.org>.
LeslieKid commented on PR #13607:
URL: https://github.com/apache/datafusion/pull/13607#issuecomment-2509973507
The current benchmark results on my computer are:
```
--------------------
Benchmark tpch_mem_sf1.json
--------------------
┏━━━━━━━━━━━━━━┳━━━━━━━━━━┳━━━━━━━━━━━┳━━━━━━━━━━━━━━━┓
┃ Query ┃ main ┃ hash-join ┃ Change ┃
┡━━━━━━━━━━━━━━╇━━━━━━━━━━╇━━━━━━━━━━━╇━━━━━━━━━━━━━━━┩
│ QQuery 1 │ 88.79ms │ 85.61ms │ no change │
│ QQuery 2 │ 13.24ms │ 13.14ms │ no change │
│ QQuery 3 │ 21.88ms │ 22.28ms │ no change │
│ QQuery 4 │ 13.12ms │ 13.36ms │ no change │
│ QQuery 5 │ 42.65ms │ 40.32ms │ +1.06x faster │
│ QQuery 6 │ 4.79ms │ 4.77ms │ no change │
│ QQuery 7 │ 81.89ms │ 80.93ms │ no change │
│ QQuery 8 │ 16.44ms │ 16.56ms │ no change │
│ QQuery 9 │ 45.76ms │ 45.13ms │ no change │
│ QQuery 10 │ 41.66ms │ 41.02ms │ no change │
│ QQuery 11 │ 5.65ms │ 6.05ms │ 1.07x slower │
│ QQuery 12 │ 26.32ms │ 26.35ms │ no change │
│ QQuery 13 │ 18.90ms │ 19.65ms │ no change │
│ QQuery 14 │ 5.07ms │ 5.09ms │ no change │
│ QQuery 15 │ 11.67ms │ 11.69ms │ no change │
│ QQuery 16 │ 12.68ms │ 12.57ms │ no change │
│ QQuery 17 │ 63.97ms │ 63.23ms │ no change │
│ QQuery 18 │ 148.73ms │ 148.57ms │ no change │
│ QQuery 19 │ 23.53ms │ 23.29ms │ no change │
│ QQuery 20 │ 23.16ms │ 23.25ms │ no change │
│ QQuery 21 │ 101.53ms │ 99.36ms │ no change │
│ QQuery 22 │ 15.41ms │ 15.11ms │ no change │
└──────────────┴──────────┴───────────┴───────────────┘
┏━━━━━━━━━━━━━━━━━━━━━━━━━━┳━━━━━━━━━━┓
┃ Benchmark Summary ┃ ┃
┡━━━━━━━━━━━━━━━━━━━━━━━━━━╇━━━━━━━━━━┩
│ Total Time (main) │ 826.83ms │
│ Total Time (hash-join) │ 817.33ms │
│ Average Time (main) │ 37.58ms │
│ Average Time (hash-join) │ 37.15ms │
│ Queries Faster │ 1 │
│ Queries Slower │ 1 │
│ Queries with No Change │ 20 │
└──────────────────────────┴──────────┘
--------------------
Benchmark tpch_sf1.json
--------------------
┏━━━━━━━━━━━━━━┳━━━━━━━━━━┳━━━━━━━━━━━┳━━━━━━━━━━━━━━━┓
┃ Query ┃ main ┃ hash-join ┃ Change ┃
┡━━━━━━━━━━━━━━╇━━━━━━━━━━╇━━━━━━━━━━━╇━━━━━━━━━━━━━━━┩
│ QQuery 1 │ 115.67ms │ 113.55ms │ no change │
│ QQuery 2 │ 20.18ms │ 20.85ms │ no change │
│ QQuery 3 │ 40.90ms │ 42.72ms │ no change │
│ QQuery 4 │ 27.69ms │ 26.85ms │ no change │
│ QQuery 5 │ 65.46ms │ 65.07ms │ no change │
│ QQuery 6 │ 19.83ms │ 20.36ms │ no change │
│ QQuery 7 │ 92.16ms │ 87.85ms │ no change │
│ QQuery 8 │ 59.73ms │ 57.81ms │ no change │
│ QQuery 9 │ 80.80ms │ 80.41ms │ no change │
│ QQuery 10 │ 71.76ms │ 68.15ms │ +1.05x faster │
│ QQuery 11 │ 13.70ms │ 14.08ms │ no change │
│ QQuery 12 │ 41.34ms │ 40.55ms │ no change │
│ QQuery 13 │ 41.06ms │ 39.47ms │ no change │
│ QQuery 14 │ 30.83ms │ 29.78ms │ no change │
│ QQuery 15 │ 49.08ms │ 50.25ms │ no change │
│ QQuery 16 │ 14.89ms │ 15.39ms │ no change │
│ QQuery 17 │ 105.27ms │ 102.18ms │ no change │
│ QQuery 18 │ 140.74ms │ 137.79ms │ no change │
│ QQuery 19 │ 54.41ms │ 51.36ms │ +1.06x faster │
│ QQuery 20 │ 46.00ms │ 43.53ms │ +1.06x faster │
│ QQuery 21 │ 108.36ms │ 108.11ms │ no change │
│ QQuery 22 │ 17.36ms │ 17.62ms │ no change │
└──────────────┴──────────┴───────────┴───────────────┘
┏━━━━━━━━━━━━━━━━━━━━━━━━━━┳━━━━━━━━━━━┓
┃ Benchmark Summary ┃ ┃
┡━━━━━━━━━━━━━━━━━━━━━━━━━━╇━━━━━━━━━━━┩
│ Total Time (main) │ 1257.23ms │
│ Total Time (hash-join) │ 1233.75ms │
│ Average Time (main) │ 57.15ms │
│ Average Time (hash-join) │ 56.08ms │
│ Queries Faster │ 3 │
│ Queries Slower │ 0 │
│ Queries with No Change │ 19 │
└──────────────────────────┴───────────┘
```
I'm not sure if the test results on my computer are accurate. Can you help for running the benchmarks on your machines? @Dandandan @Rachelint
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: github-unsubscribe@datafusion.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: github-unsubscribe@datafusion.apache.org
For additional commands, e-mail: github-help@datafusion.apache.org
Re: [PR] [POC] Fuse operations in `equal_rows_arr` [datafusion]
Posted by "github-actions[bot] (via GitHub)" <gi...@apache.org>.
github-actions[bot] closed pull request #13607: [POC] Fuse operations in `equal_rows_arr`
URL: https://github.com/apache/datafusion/pull/13607
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: github-unsubscribe@datafusion.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: github-unsubscribe@datafusion.apache.org
For additional commands, e-mail: github-help@datafusion.apache.org
Re: [PR] [POC] Fuse operations in `equal_rows_arr` [datafusion]
Posted by "LeslieKid (via GitHub)" <gi...@apache.org>.
LeslieKid commented on PR #13607:
URL: https://github.com/apache/datafusion/pull/13607#issuecomment-2508640484
Major changes currently:
- Compare arrays with indices (in a for loop) without `take+eq`.
- Update a single boolean buffer instead of create a new one every time.
I am trying to:
- Compare nulls and values separately.
- Avoid using `Filter`.
- Support more types. (e.g. Null, Boolean, StringView...)
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: github-unsubscribe@datafusion.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: github-unsubscribe@datafusion.apache.org
For additional commands, e-mail: github-help@datafusion.apache.org
Re: [PR] [POC] Fuse operations in `equal_rows_arr` [datafusion]
Posted by "github-actions[bot] (via GitHub)" <gi...@apache.org>.
github-actions[bot] commented on PR #13607:
URL: https://github.com/apache/datafusion/pull/13607#issuecomment-2629200711
Thank you for your contribution. Unfortunately, this pull request is stale because it has been open 60 days with no activity. Please remove the stale label or comment or this will be closed in 7 days.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: github-unsubscribe@datafusion.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: github-unsubscribe@datafusion.apache.org
For additional commands, e-mail: github-help@datafusion.apache.org