[GitHub] [submarine] kevin85421 commented on a change in pull request #598: SUBMARINE-835. Exposing method modified

[GitBox <gi...@apache.org>]

kevin85421 commented on a change in pull request #598:
URL: https://github.com/apache/submarine/pull/598#discussion_r645923222



##########
File path: submarine-cloud-v2/controller.go
##########
@@ -1271,16 +1269,7 @@ func (c *Controller) syncHandler(workqueueItem WorkQueueItem) error {
 			return err
 		}
 
-		// Port-forwarding
-		// TODO:
-		//   (1) multi-tenant port-forwarding
-		//   (2) Basic operations: on/off/modify (change port)
-		//   (3) in-cluster
-		if action == ADD {
-			if !c.incluster {

Review comment:
       Do you have tested the deletion of submarine CR? I guess that the deletion will have some bugs.
   
   

##########
File path: submarine-cloud-v2/README.md
##########
@@ -57,21 +64,25 @@ go build -o submarine-operator
 kubectl create ns submarine-admin
 kubectl apply -n submarine-admin -f artifacts/examples/example-submarine.yaml
 
-# Step3: "submarine-operator" will perform port-forwarding automatically.
+# Step3: Exposing Service
+# Using minikube ip + NodePort
+$ minikube ip  # you'll get the IP address of minikube, ex: 192.168.49.2
 
-# Step4: View workbench (127.0.0.1:32080) with your web browser
+# Step4: View workbench
+# http://{minikube ip}:32080, ex: http://192.168.49.2:32080

Review comment:
       In my experience, `minikube ip` does not work in the development environment (MacOS), and thus it would be better to add method2 (port-forward command).
   




-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org