[GitHub] thrift pull request #1057: Update TSSLSocket.cpp

[jeking3 <gi...@git.apache.org>]

Github user jeking3 commented on a diff in the pull request:

    https://github.com/apache/thrift/pull/1057#discussion_r72976807
  
    --- Diff: lib/cpp/src/thrift/transport/TSSLSocket.cpp ---
    @@ -471,8 +471,10 @@ void TSSLSocket::checkHandshake() {
           }
         } while (rc == 2);
       } else {
    -    // set the SNI hostname
    -    SSL_set_tlsext_host_name(ssl_, getHost().c_str());
    +    /* OpenSSL < 0.9.8f does not have SSL_set_tlsext_host_name() */
    +    #if defined(SSL_set_tlsext_host_name) // set the SNI hostname
    --- End diff --
    
    Typically we would add something to the build system environment to differentiate this; also is there an alternative that can be used with older OpenSSL?  Other folks who are committers will need to decide if it is worth supporting an older and likely quite vulnerable (to hacks) OpenSSL library.


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---