You are viewing a plain text version of this content. The canonical link for it is here.

Posted to issues@trafficcontrol.apache.org by GitBox <gi...@apache.org> on 2020/01/24 16:06:31 UTC

[GitHub] [trafficcontrol] ocket8888 commented on a change in pull request #4316: Rewrite cachegroup parameter delete to Go

ocket8888 commented on a change in pull request #4316: Rewrite cachegroup parameter delete to Go
URL: https://github.com/apache/trafficcontrol/pull/4316#discussion_r370706377
 
 

 ##########
 File path: traffic_ops/traffic_ops_golang/cachegroupparameter/parameters.go
 ##########
 @@ -33,14 +34,16 @@ import (
 )
 
 const (
-	CacheGroupIDQueryParam = "id"
-	ParameterIDQueryParam  = "parameterId"
+	CacheGroupIDQueryParam      = "id"
+	CacheGroupIDNamedQueryParam = "cachegroupID"
+	ParameterIDQueryParam       = "parameterId"
 )
 
-//we need a type alias to define functions on
+// TOCacheGroupParameter is a type alias that is used to define CRUD functions on
 
 Review comment:
   nit: GoDoc should end with a period.

----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
users@infra.apache.org


With regards,
Apache Git Services