You are viewing a plain text version of this content. The canonical link for it is here.
Posted to commits@ambari.apache.org by GitBox <gi...@apache.org> on 2022/11/14 16:19:46 UTC
[GitHub] [ambari-metrics] lucasbak opened a new pull request, #63: AMBARI-25563. Storm dashboards are not showing metrics.
lucasbak opened a new pull request, #63:
URL: https://github.com/apache/ambari-metrics/pull/63
## What changes were proposed in this pull request?
Forward 5fd23256c7e0cbba78cee8d8883c00c34e70ff56 AMBARI-25563. Storm dashboards are not showing metrics.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@ambari.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@ambari.apache.org
For additional commands, e-mail: commits-help@ambari.apache.org
[GitHub] [ambari-metrics] kevinw66 merged pull request #63: AMBARI-25563. Storm dashboards are not showing metrics.
Posted by GitBox <gi...@apache.org>.
kevinw66 merged PR #63:
URL: https://github.com/apache/ambari-metrics/pull/63
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@ambari.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@ambari.apache.org
For additional commands, e-mail: commits-help@ambari.apache.org
[GitHub] [ambari-metrics] lucasbak commented on a diff in pull request #63: AMBARI-25563. Storm dashboards are not showing metrics.
Posted by GitBox <gi...@apache.org>.
lucasbak commented on code in PR #63:
URL: https://github.com/apache/ambari-metrics/pull/63#discussion_r1022531286
##########
ambari-metrics-timelineservice/src/main/java/org/apache/ambari/metrics/core/timeline/query/TransientMetricCondition.java:
##########
@@ -60,22 +60,22 @@ public StringBuilder getTransientConditionClause() {
appendConjunction = appendHostnameClause(sb, appendConjunction);
String appId = getAppId();
- if (appId.contains("%")) {
- appendConjunction = append(sb, appendConjunction, getAppId(), " APP_ID LIKE ?");
- } else {
- appendConjunction = append(sb, appendConjunction, getAppId(), " APP_ID = ?");
+ if (appId != null) {
+ if (appId.contains("%")) {
+ appendConjunction = append(sb, appendConjunction, getAppId(), " APP_ID LIKE ?");
+ } else {
+ appendConjunction = append(sb, appendConjunction, getAppId(), " APP_ID = ?");
+ }
}
String instanceId = getInstanceId();
- if (instanceId.contains("%")) {
- appendConjunction = append(sb, appendConjunction, getInstanceId(), " INSTANCE_ID LIKE ?");
- } else {
- appendConjunction = append(sb, appendConjunction, getInstanceId(), " INSTANCE_ID = ?");
+ if (instanceId != null) {
+ if (instanceId.contains("%")) {
+ appendConjunction = append(sb, appendConjunction, getInstanceId(), " INSTANCE_ID LIKE ?");
+ } else {
+ appendConjunction = append(sb, appendConjunction, getInstanceId(), " INSTANCE_ID = ?");
+ }
}
- appendConjunction = append(sb, appendConjunction, getStartTime(), " SERVER_TIME >= ?");
- append(sb, appendConjunction, getEndTime(), " SERVER_TIME < ?");
-
- return sb;
Review Comment:
No need to delete those lines
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@ambari.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@ambari.apache.org
For additional commands, e-mail: commits-help@ambari.apache.org
[GitHub] [ambari-metrics] kevinw66 commented on a diff in pull request #63: AMBARI-25563. Storm dashboards are not showing metrics.
Posted by GitBox <gi...@apache.org>.
kevinw66 commented on code in PR #63:
URL: https://github.com/apache/ambari-metrics/pull/63#discussion_r1022365735
##########
ambari-metrics-timelineservice/src/main/java/org/apache/ambari/metrics/core/timeline/query/TransientMetricCondition.java:
##########
@@ -60,22 +60,22 @@ public StringBuilder getTransientConditionClause() {
appendConjunction = appendHostnameClause(sb, appendConjunction);
String appId = getAppId();
- if (appId.contains("%")) {
- appendConjunction = append(sb, appendConjunction, getAppId(), " APP_ID LIKE ?");
- } else {
- appendConjunction = append(sb, appendConjunction, getAppId(), " APP_ID = ?");
+ if (appId != null) {
+ if (appId.contains("%")) {
+ appendConjunction = append(sb, appendConjunction, getAppId(), " APP_ID LIKE ?");
+ } else {
+ appendConjunction = append(sb, appendConjunction, getAppId(), " APP_ID = ?");
+ }
}
String instanceId = getInstanceId();
- if (instanceId.contains("%")) {
- appendConjunction = append(sb, appendConjunction, getInstanceId(), " INSTANCE_ID LIKE ?");
- } else {
- appendConjunction = append(sb, appendConjunction, getInstanceId(), " INSTANCE_ID = ?");
+ if (instanceId != null) {
+ if (instanceId.contains("%")) {
+ appendConjunction = append(sb, appendConjunction, getInstanceId(), " INSTANCE_ID LIKE ?");
+ } else {
+ appendConjunction = append(sb, appendConjunction, getInstanceId(), " INSTANCE_ID = ?");
+ }
}
- appendConjunction = append(sb, appendConjunction, getStartTime(), " SERVER_TIME >= ?");
- append(sb, appendConjunction, getEndTime(), " SERVER_TIME < ?");
-
- return sb;
Review Comment:
I don't see this being deleted in original commit, why delete here?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@ambari.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@ambari.apache.org
For additional commands, e-mail: commits-help@ambari.apache.org