[GitHub] [storm] kishorvpatil commented on a change in pull request #3287: [STORM-3271] enable supervisors to launch a worker inside a docker container

[GitBox <gi...@apache.org>]

kishorvpatil commented on a change in pull request #3287:
URL: https://github.com/apache/storm/pull/3287#discussion_r449280056



##########
File path: storm-server/src/main/java/org/apache/storm/container/docker/DockerPsCommand.java
##########
@@ -0,0 +1,52 @@
+/*
+ * Licensed to the Apache Software Foundation (ASF) under one
+ * or more contributor license agreements.  See the NOTICE file
+ * distributed with this work for additional information
+ * regarding copyright ownership.  The ASF licenses this file
+ * to you under the Apache License, Version 2.0 (the
+ * "License"); you may not use this file except in compliance
+ * with the License.  You may obtain a copy of the License at
+ *
+ * http://www.apache.org/licenses/LICENSE-2.0
+ *
+ * Unless required by applicable law or agreed to in writing, software
+ * distributed under the License is distributed on an "AS IS" BASIS,
+ * WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied.
+ * See the License for the specific language governing permissions and
+ * limitations under the License.
+ */
+
+package org.apache.storm.container.docker;
+
+import java.util.ArrayList;
+import java.util.List;
+import org.apache.commons.lang.StringUtils;
+
+public class DockerPsCommand extends DockerCommand {
+    private static final String PS_COMMAND = "ps";
+
+    public DockerPsCommand() {
+        super(PS_COMMAND);
+    }
+
+    public DockerPsCommand withQuietOption() {
+        super.addCommandArguments("--quiet=true");
+        return this;
+    }
+
+    public DockerPsCommand withNameFilter(String containerName) {
+        super.addCommandArguments("--filter=name=" + containerName);
+        return this;
+    }
+
+    /**
+     * Get the full command.
+     * @return the full command.
+     */
+    @Override
+    public String getCommandWithArguments() {

Review comment:
       Do we need to override this method? Looks like the parent _DockerCommand.getCommandWithArguments_ is doing the same thing.




----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org