You are viewing a plain text version of this content. The canonical link for it is here.
Posted to dev@tomcat.apache.org by bu...@apache.org on 2010/10/29 21:45:44 UTC

DO NOT REPLY [Bug 50182] New: Contributing back enhancements to CompressionFilter

https://issues.apache.org/bugzilla/show_bug.cgi?id=50182

           Summary: Contributing back enhancements to CompressionFilter
           Product: Tomcat 6
           Version: unspecified
          Platform: All
        OS/Version: All
            Status: NEW
          Severity: enhancement
          Priority: P2
         Component: Examples
        AssignedTo: dev@tomcat.apache.org
        ReportedBy: david@sogeeky.net


Created an attachment (id=26227)
 --> (https://issues.apache.org/bugzilla/attachment.cgi?id=26227)
Source code and example web.xml

Years ago I contributed an enhancement to convert the SSIServlet into a filter
(java/org/apache/catalina/ssi/SSIFilter.java).  Now I'm back to offer up some
enhancements to the CompressionFilter example
(webapps/examples/WEB-INF/classes/compressionFilters).

I've found (as have others) that the connector compression is flaky and
unreliable, so I turned to the CompressionFilter example, but found it to be
badly lacking in functionality.  No doubt owing to its status as an example
project.  I've made a bunch of enhancements to it and I feel it's worth of
being moved out of examples now.  You may even want to deprecate the connector
compression in favor of this - or at least roll the two together.  In my own
webapp (and the attached zip) I've renamed it to GZipFilter and it lives in my
own internal package structure, but please move it back into an org.apache
package structure and rename it as you see fit.

The enhancements I've made are:
* It now supports specifying which mime types are compressible.
* It now supports a variable sized buffer, which can be used to avoid chunking
on small files.
* The compression threshold and all other settings are configurable in web.xml.
* Miscellaneous bug fixes.

If you adopt these enhancements, please credit David Becker with no email, same
as on the SSIServlet.

Enjoy!

-- 
Configure bugmail: https://issues.apache.org/bugzilla/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are the assignee for the bug.

---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@tomcat.apache.org
For additional commands, e-mail: dev-help@tomcat.apache.org


DO NOT REPLY [Bug 50182] Contributing back enhancements to CompressionFilter

Posted by bu...@apache.org.
https://issues.apache.org/bugzilla/show_bug.cgi?id=50182

David Becker <da...@sogeeky.net> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
                 CC|                            |david@sogeeky.net

--- Comment #1 from David Becker <da...@sogeeky.net> 2010-10-29 15:47:26 EDT ---
For records on my previous SSIFilter see:
https://issues.apache.org/bugzilla/show_bug.cgi?id=33106

-- 
Configure bugmail: https://issues.apache.org/bugzilla/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are the assignee for the bug.

---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@tomcat.apache.org
For additional commands, e-mail: dev-help@tomcat.apache.org


[Bug 50182] Contributing back enhancements to CompressionFilter

Posted by bu...@apache.org.
https://issues.apache.org/bugzilla/show_bug.cgi?id=50182

Mark Thomas <ma...@apache.org> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
             Status|NEW                         |RESOLVED
         Resolution|---                         |FIXED

--- Comment #2 from Mark Thomas <ma...@apache.org> ---
Patch applied (with minor alterations) to 7.0.x and will be included in 7.0.28
onwards.

-- 
You are receiving this mail because:
You are the assignee for the bug.

---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@tomcat.apache.org
For additional commands, e-mail: dev-help@tomcat.apache.org