You are viewing a plain text version of this content. The canonical link for it is here.
Posted to commits@doris.apache.org by GitBox <gi...@apache.org> on 2022/10/13 14:25:42 UTC
[GitHub] [doris] BiteTheDDDDt opened a new pull request, #13362: [Enhancement](function) refactor of date function
BiteTheDDDDt opened a new pull request, #13362:
URL: https://github.com/apache/doris/pull/13362
# Proposed changes
1. refactor some functions template argument.
2. year() only check year validity now.
3. change instance number of tpch q9
## Problem summary
Describe your changes.
## Checklist(Required)
1. Does it affect the original behavior:
- [ ] Yes
- [ ] No
- [ ] I don't know
4. Has unit tests been added:
- [ ] Yes
- [ ] No
- [ ] No Need
5. Has document been added or modified:
- [ ] Yes
- [ ] No
- [ ] No Need
6. Does it need to update dependencies:
- [ ] Yes
- [ ] No
7. Are there any changes that cannot be rolled back:
- [ ] Yes (If Yes, please explain WHY)
- [ ] No
## Further comments
If this is a relatively large or complex change, kick off the discussion at [dev@doris.apache.org](mailto:dev@doris.apache.org) by explaining why you chose the solution you did and what alternatives you considered, etc...
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org
For additional commands, e-mail: commits-help@doris.apache.org
[GitHub] [doris] Gabriel39 commented on a diff in pull request #13362: [Enhancement](function) refactor of date function
Posted by GitBox <gi...@apache.org>.
Gabriel39 commented on code in PR #13362:
URL: https://github.com/apache/doris/pull/13362#discussion_r995506834
##########
be/src/vec/runtime/vdatetime_value.h:
##########
@@ -1040,6 +1039,8 @@ class DateV2Value {
}
}
+ bool is_valid_year() const { return year() < MAX_YEAR && year() > MIN_YEAR; }
Review Comment:
unused function?
##########
be/src/vec/exec/format/parquet/vparquet_page_reader.cpp:
##########
@@ -19,6 +19,7 @@
#include <stdint.h>
+#include "common/config.h"
Review Comment:
unnecessary addition?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org
For additional commands, e-mail: commits-help@doris.apache.org
[GitHub] [doris] github-actions[bot] commented on pull request #13362: [Enhancement](function) refactor of date function
Posted by GitBox <gi...@apache.org>.
github-actions[bot] commented on PR #13362:
URL: https://github.com/apache/doris/pull/13362#issuecomment-1279728971
PR approved by at least one committer and no changes requested.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org
For additional commands, e-mail: commits-help@doris.apache.org
[GitHub] [doris] github-actions[bot] commented on pull request #13362: [Enhancement](function) refactor of date function
Posted by GitBox <gi...@apache.org>.
github-actions[bot] commented on PR #13362:
URL: https://github.com/apache/doris/pull/13362#issuecomment-1279728974
PR approved by anyone and no changes requested.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org
For additional commands, e-mail: commits-help@doris.apache.org
[GitHub] [doris] BiteTheDDDDt merged pull request #13362: [Enhancement](function) refactor of date function
Posted by GitBox <gi...@apache.org>.
BiteTheDDDDt merged PR #13362:
URL: https://github.com/apache/doris/pull/13362
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org
For additional commands, e-mail: commits-help@doris.apache.org