You are viewing a plain text version of this content. The canonical link for it is here.

Posted to commits@pulsar.apache.org by GitBox <gi...@apache.org> on 2022/10/24 08:36:04 UTC

[GitHub] [pulsar] nodece commented on a diff in pull request #18171: [fix][ci] Check full build artifacts licenses

nodece commented on code in PR #18171:
URL: https://github.com/apache/pulsar/pull/18171#discussion_r1003037952


##########
.github/workflows/pulsar-ci.yaml:
##########
@@ -544,6 +544,10 @@ jobs:
           -Pmain,docker -Dmaven.test.skip=true -Ddocker.squash=true \
           -Dspotbugs.skip=true -Dlicense.skip=true -Dcheckstyle.skip=true -Drat.skip=true
 
+      # check full build artifacts licenses
+      - name: Check binary licenses
+        run: src/check-binary-license.sh ./distribution/server/target/apache-pulsar-*-bin.tar.gz

Review Comment:
   I think you should move this command to `build-and-license-check` job.



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscribe@pulsar.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org