Re: [PR] [SPARK-59975][SQL] Handle all-null partial and final tuple/theta intersection aggregates [spark]

["SavicStefan (via GitHub)" <gi...@apache.org>]

SavicStefan commented on code in PR #59252:
URL: https://github.com/apache/spark/pull/59252#discussion_r4228634036


##########
sql/core/src/test/scala/org/apache/spark/sql/DataFrameAggregateSuite.scala:
##########
@@ -5031,6 +5031,62 @@ class DataFrameAggregateSuite extends SharedSparkSession
     assert(estimateResult == 2.0)
   }
 
+  private val intersectionSketchFunctions = Seq(

Review Comment:
   Added both of them and also the optional window one, I think ti makes sense to add it.



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org


---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org