Re: [PR] [SPARK-43877][PYTHON] Fix behavior difference for compare binary functions. [spark]

["zhengruifeng (via GitHub)" <gi...@apache.org>]

zhengruifeng commented on code in PR #56134:
URL: https://github.com/apache/spark/pull/56134#discussion_r3372619319


##########
python/pyspark/sql/connect/column.py:
##########
@@ -91,10 +91,27 @@ def _bin_op(
     else:
         other_expr = other._expr  # type: ignore[assignment]
 
+    # For comparison ops, replace NULL results with boolean fillers to match
+    # pandas-on-Spark semantics on the client side. See SPARK-43877.

Review Comment:
   I think we don't need to follow the behavior of pandas,
   it is part of the general dataframe APIs which is expected to follow the SQL behavior. 



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org


---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org