You are viewing a plain text version of this content. The canonical link for it is here.

Posted to dev@rocketmq.apache.org by GitBox <gi...@apache.org> on 2020/11/09 03:28:18 UTC

[GitHub] [rocketmq] lovelife-li opened a new pull request #2409: Optimize rebalance

lovelife-li opened a new pull request #2409:
URL: https://github.com/apache/rocketmq/pull/2409

## What is the purpose of the change

test

## Brief changelog

test

## Verifying this change

test

Follow this checklist to help us incorporate your contribution quickly and easily. Notice, `it would be helpful if you could finish the following 5 checklist(the last one is not necessary)before request the community to review your PR`.

- [x] Make sure there is a [Github issue](https://github.com/apache/rocketmq/issues) filed for the change (usually before you start working on it). Trivial changes like typos do not require a Github issue. Your pull request should address just this issue, without pulling in other changes - one PR resolves one issue.
- [x] Format the pull request title like `[ISSUE #123] Fix UnknownException when host config not exist`. Each commit in the pull request should have a meaningful subject line and body.
- [x] Write a pull request description that is detailed enough to understand what the pull request does, how, and why.
- [x] Write necessary unit-test(over 80% coverage) to verify your logic correction, more mock a little better when cross module dependency exist. If the new feature or significant change is committed, please remember to add integration-test in [test module](https://github.com/apache/rocketmq/tree/master/test).
- [x] Run `mvn -B clean apache-rat:check findbugs:findbugs checkstyle:checkstyle` to make sure basic checks pass. Run `mvn clean install -DskipITs` to make sure unit-test pass. Run `mvn clean test-compile failsafe:integration-test` to make sure integration-test pass.
- [ ] If this contribution is large, please file an [Apache Individual Contributor License Agreement](http://www.apache.org/licenses/#clas).

----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

[GitHub] [rocketmq] lovelife-li closed pull request #2409: Optimize rebalance

Posted by GitBox <gi...@apache.org>.

lovelife-li closed pull request #2409:
URL: https://github.com/apache/rocketmq/pull/2409


   


----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

[GitHub] [rocketmq] coveralls commented on pull request #2409: Optimize rebalance

Posted by GitBox <gi...@apache.org>.

coveralls commented on pull request #2409:
URL: https://github.com/apache/rocketmq/pull/2409#issuecomment-723736075






----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

[GitHub] [rocketmq] RongtongJin closed pull request #2409: Optimize rebalance

Posted by GitBox <gi...@apache.org>.

RongtongJin closed pull request #2409:
URL: https://github.com/apache/rocketmq/pull/2409


   


----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

[GitHub] [rocketmq] codecov-io commented on pull request #2409: Optimize rebalance

Posted by GitBox <gi...@apache.org>.

codecov-io commented on pull request #2409:
URL: https://github.com/apache/rocketmq/pull/2409#issuecomment-723738615


   # [Codecov](https://codecov.io/gh/apache/rocketmq/pull/2409?src=pr&el=h1) Report
   > Merging [#2409](https://codecov.io/gh/apache/rocketmq/pull/2409?src=pr&el=desc) (c60cb0f) into [master](https://codecov.io/gh/apache/rocketmq/commit/9f95a972e10e0681bc3f2d00e9957aa212e897b5?el=desc) (9f95a97) will **decrease** coverage by `0.44%`.
   > The diff coverage is `21.28%`.
   
   [![Impacted file tree graph](https://codecov.io/gh/apache/rocketmq/pull/2409/graphs/tree.svg?width=650&height=150&src=pr&token=4w0sxP1wZv)](https://codecov.io/gh/apache/rocketmq/pull/2409?src=pr&el=tree)
   
   ```diff
   @@             Coverage Diff              @@
   ##             master    #2409      +/-   ##
   ============================================
   - Coverage     45.69%   45.24%   -0.45%     
   + Complexity     4270     4257      -13     
   ============================================
     Files           546      552       +6     
     Lines         35860    36096     +236     
     Branches       4763     4802      +39     
   ============================================
   - Hits          16387    16333      -54     
   - Misses        17429    17729     +300     
   + Partials       2044     2034      -10     
   ```
   
   
   | [Impacted Files](https://codecov.io/gh/apache/rocketmq/pull/2409?src=pr&el=tree) | Coverage Δ | Complexity Δ | |
   |---|---|---|---|
   | [...g/apache/rocketmq/client/impl/MQClientAPIImpl.java](https://codecov.io/gh/apache/rocketmq/pull/2409/diff?src=pr&el=tree#diff-Y2xpZW50L3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9yb2NrZXRtcS9jbGllbnQvaW1wbC9NUUNsaWVudEFQSUltcGwuamF2YQ==) | `12.43% <0.00%> (-0.21%)` | `25.00 <0.00> (ø)` | |
   | [...ent/impl/consumer/DefaultLitePullConsumerImpl.java](https://codecov.io/gh/apache/rocketmq/pull/2409/diff?src=pr&el=tree#diff-Y2xpZW50L3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9yb2NrZXRtcS9jbGllbnQvaW1wbC9jb25zdW1lci9EZWZhdWx0TGl0ZVB1bGxDb25zdW1lckltcGwuamF2YQ==) | `0.00% <0.00%> (ø)` | `0.00 <0.00> (ø)` | |
   | [...lient/impl/consumer/DefaultMQPullConsumerImpl.java](https://codecov.io/gh/apache/rocketmq/pull/2409/diff?src=pr&el=tree#diff-Y2xpZW50L3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9yb2NrZXRtcS9jbGllbnQvaW1wbC9jb25zdW1lci9EZWZhdWx0TVFQdWxsQ29uc3VtZXJJbXBsLmphdmE=) | `27.29% <0.00%> (-0.08%)` | `18.00 <0.00> (ø)` | |
   | [...cketmq/client/impl/consumer/RebalancePullImpl.java](https://codecov.io/gh/apache/rocketmq/pull/2409/diff?src=pr&el=tree#diff-Y2xpZW50L3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9yb2NrZXRtcS9jbGllbnQvaW1wbC9jb25zdW1lci9SZWJhbGFuY2VQdWxsSW1wbC5qYXZh) | `23.80% <0.00%> (-1.20%)` | `2.00 <0.00> (ø)` | |
   | [...g/apache/rocketmq/common/protocol/RequestCode.java](https://codecov.io/gh/apache/rocketmq/pull/2409/diff?src=pr&el=tree#diff-Y29tbW9uL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9yb2NrZXRtcS9jb21tb24vcHJvdG9jb2wvUmVxdWVzdENvZGUuamF2YQ==) | `0.00% <ø> (ø)` | `0.00 <0.00> (ø)` | |
   | [.../apache/rocketmq/common/protocol/ResponseCode.java](https://codecov.io/gh/apache/rocketmq/pull/2409/diff?src=pr&el=tree#diff-Y29tbW9uL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9yb2NrZXRtcS9jb21tb24vcHJvdG9jb2wvUmVzcG9uc2VDb2RlLmphdmE=) | `0.00% <ø> (ø)` | `0.00 <0.00> (ø)` | |
   | [...protocol/body/AllocateMessageQueueRequestBody.java](https://codecov.io/gh/apache/rocketmq/pull/2409/diff?src=pr&el=tree#diff-Y29tbW9uL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9yb2NrZXRtcS9jb21tb24vcHJvdG9jb2wvYm9keS9BbGxvY2F0ZU1lc3NhZ2VRdWV1ZVJlcXVlc3RCb2R5LmphdmE=) | `0.00% <0.00%> (ø)` | `0.00 <0.00> (?)` | |
   | [...ocol/header/AllocateMessageQueueRequestHeader.java](https://codecov.io/gh/apache/rocketmq/pull/2409/diff?src=pr&el=tree#diff-Y29tbW9uL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9yb2NrZXRtcS9jb21tb24vcHJvdG9jb2wvaGVhZGVyL0FsbG9jYXRlTWVzc2FnZVF1ZXVlUmVxdWVzdEhlYWRlci5qYXZh) | `0.00% <0.00%> (ø)` | `0.00 <0.00> (?)` | |
   | [...tocol/header/AllocateMessageQueueResponseBody.java](https://codecov.io/gh/apache/rocketmq/pull/2409/diff?src=pr&el=tree#diff-Y29tbW9uL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9yb2NrZXRtcS9jb21tb24vcHJvdG9jb2wvaGVhZGVyL0FsbG9jYXRlTWVzc2FnZVF1ZXVlUmVzcG9uc2VCb2R5LmphdmE=) | `0.00% <0.00%> (ø)` | `0.00 <0.00> (?)` | |
   | [...col/header/AllocateMessageQueueResponseHeader.java](https://codecov.io/gh/apache/rocketmq/pull/2409/diff?src=pr&el=tree#diff-Y29tbW9uL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9yb2NrZXRtcS9jb21tb24vcHJvdG9jb2wvaGVhZGVyL0FsbG9jYXRlTWVzc2FnZVF1ZXVlUmVzcG9uc2VIZWFkZXIuamF2YQ==) | `0.00% <0.00%> (ø)` | `0.00 <0.00> (?)` | |
   | ... and [52 more](https://codecov.io/gh/apache/rocketmq/pull/2409/diff?src=pr&el=tree-more) | |
   
   ------
   
   [Continue to review full report at Codecov](https://codecov.io/gh/apache/rocketmq/pull/2409?src=pr&el=continue).
   > **Legend** - [Click here to learn more](https://docs.codecov.io/docs/codecov-delta)
   > `Δ = absolute <relative> (impact)`, `ø = not affected`, `? = missing data`
   > Powered by [Codecov](https://codecov.io/gh/apache/rocketmq/pull/2409?src=pr&el=footer). Last update [9f95a97...c60cb0f](https://codecov.io/gh/apache/rocketmq/pull/2409?src=pr&el=lastupdated). Read the [comment docs](https://docs.codecov.io/docs/pull-request-comments).
   


----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

[GitHub] [rocketmq] codecov-io edited a comment on pull request #2409: Optimize rebalance

Posted by GitBox <gi...@apache.org>.

codecov-io edited a comment on pull request #2409:
URL: https://github.com/apache/rocketmq/pull/2409#issuecomment-723738615


   # [Codecov](https://codecov.io/gh/apache/rocketmq/pull/2409?src=pr&el=h1) Report
   > Merging [#2409](https://codecov.io/gh/apache/rocketmq/pull/2409?src=pr&el=desc) (c60cb0f) into [master](https://codecov.io/gh/apache/rocketmq/commit/9f95a972e10e0681bc3f2d00e9957aa212e897b5?el=desc) (9f95a97) will **decrease** coverage by `0.40%`.
   > The diff coverage is `21.28%`.
   
   [![Impacted file tree graph](https://codecov.io/gh/apache/rocketmq/pull/2409/graphs/tree.svg?width=650&height=150&src=pr&token=4w0sxP1wZv)](https://codecov.io/gh/apache/rocketmq/pull/2409?src=pr&el=tree)
   
   ```diff
   @@             Coverage Diff              @@
   ##             master    #2409      +/-   ##
   ============================================
   - Coverage     45.69%   45.28%   -0.41%     
   + Complexity     4270     4261       -9     
   ============================================
     Files           546      552       +6     
     Lines         35860    36096     +236     
     Branches       4763     4802      +39     
   ============================================
   - Hits          16387    16347      -40     
   - Misses        17429    17718     +289     
   + Partials       2044     2031      -13     
   ```
   
   
   | [Impacted Files](https://codecov.io/gh/apache/rocketmq/pull/2409?src=pr&el=tree) | Coverage Δ | Complexity Δ | |
   |---|---|---|---|
   | [...g/apache/rocketmq/client/impl/MQClientAPIImpl.java](https://codecov.io/gh/apache/rocketmq/pull/2409/diff?src=pr&el=tree#diff-Y2xpZW50L3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9yb2NrZXRtcS9jbGllbnQvaW1wbC9NUUNsaWVudEFQSUltcGwuamF2YQ==) | `12.43% <0.00%> (-0.21%)` | `25.00 <0.00> (ø)` | |
   | [...ent/impl/consumer/DefaultLitePullConsumerImpl.java](https://codecov.io/gh/apache/rocketmq/pull/2409/diff?src=pr&el=tree#diff-Y2xpZW50L3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9yb2NrZXRtcS9jbGllbnQvaW1wbC9jb25zdW1lci9EZWZhdWx0TGl0ZVB1bGxDb25zdW1lckltcGwuamF2YQ==) | `0.00% <0.00%> (ø)` | `0.00 <0.00> (ø)` | |
   | [...lient/impl/consumer/DefaultMQPullConsumerImpl.java](https://codecov.io/gh/apache/rocketmq/pull/2409/diff?src=pr&el=tree#diff-Y2xpZW50L3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9yb2NrZXRtcS9jbGllbnQvaW1wbC9jb25zdW1lci9EZWZhdWx0TVFQdWxsQ29uc3VtZXJJbXBsLmphdmE=) | `27.29% <0.00%> (-0.08%)` | `18.00 <0.00> (ø)` | |
   | [...cketmq/client/impl/consumer/RebalancePullImpl.java](https://codecov.io/gh/apache/rocketmq/pull/2409/diff?src=pr&el=tree#diff-Y2xpZW50L3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9yb2NrZXRtcS9jbGllbnQvaW1wbC9jb25zdW1lci9SZWJhbGFuY2VQdWxsSW1wbC5qYXZh) | `23.80% <0.00%> (-1.20%)` | `2.00 <0.00> (ø)` | |
   | [...g/apache/rocketmq/common/protocol/RequestCode.java](https://codecov.io/gh/apache/rocketmq/pull/2409/diff?src=pr&el=tree#diff-Y29tbW9uL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9yb2NrZXRtcS9jb21tb24vcHJvdG9jb2wvUmVxdWVzdENvZGUuamF2YQ==) | `0.00% <ø> (ø)` | `0.00 <0.00> (ø)` | |
   | [.../apache/rocketmq/common/protocol/ResponseCode.java](https://codecov.io/gh/apache/rocketmq/pull/2409/diff?src=pr&el=tree#diff-Y29tbW9uL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9yb2NrZXRtcS9jb21tb24vcHJvdG9jb2wvUmVzcG9uc2VDb2RlLmphdmE=) | `0.00% <ø> (ø)` | `0.00 <0.00> (ø)` | |
   | [...protocol/body/AllocateMessageQueueRequestBody.java](https://codecov.io/gh/apache/rocketmq/pull/2409/diff?src=pr&el=tree#diff-Y29tbW9uL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9yb2NrZXRtcS9jb21tb24vcHJvdG9jb2wvYm9keS9BbGxvY2F0ZU1lc3NhZ2VRdWV1ZVJlcXVlc3RCb2R5LmphdmE=) | `0.00% <0.00%> (ø)` | `0.00 <0.00> (?)` | |
   | [...ocol/header/AllocateMessageQueueRequestHeader.java](https://codecov.io/gh/apache/rocketmq/pull/2409/diff?src=pr&el=tree#diff-Y29tbW9uL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9yb2NrZXRtcS9jb21tb24vcHJvdG9jb2wvaGVhZGVyL0FsbG9jYXRlTWVzc2FnZVF1ZXVlUmVxdWVzdEhlYWRlci5qYXZh) | `0.00% <0.00%> (ø)` | `0.00 <0.00> (?)` | |
   | [...tocol/header/AllocateMessageQueueResponseBody.java](https://codecov.io/gh/apache/rocketmq/pull/2409/diff?src=pr&el=tree#diff-Y29tbW9uL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9yb2NrZXRtcS9jb21tb24vcHJvdG9jb2wvaGVhZGVyL0FsbG9jYXRlTWVzc2FnZVF1ZXVlUmVzcG9uc2VCb2R5LmphdmE=) | `0.00% <0.00%> (ø)` | `0.00 <0.00> (?)` | |
   | [...col/header/AllocateMessageQueueResponseHeader.java](https://codecov.io/gh/apache/rocketmq/pull/2409/diff?src=pr&el=tree#diff-Y29tbW9uL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9yb2NrZXRtcS9jb21tb24vcHJvdG9jb2wvaGVhZGVyL0FsbG9jYXRlTWVzc2FnZVF1ZXVlUmVzcG9uc2VIZWFkZXIuamF2YQ==) | `0.00% <0.00%> (ø)` | `0.00 <0.00> (?)` | |
   | ... and [49 more](https://codecov.io/gh/apache/rocketmq/pull/2409/diff?src=pr&el=tree-more) | |
   
   ------
   
   [Continue to review full report at Codecov](https://codecov.io/gh/apache/rocketmq/pull/2409?src=pr&el=continue).
   > **Legend** - [Click here to learn more](https://docs.codecov.io/docs/codecov-delta)
   > `Δ = absolute <relative> (impact)`, `ø = not affected`, `? = missing data`
   > Powered by [Codecov](https://codecov.io/gh/apache/rocketmq/pull/2409?src=pr&el=footer). Last update [9f95a97...c60cb0f](https://codecov.io/gh/apache/rocketmq/pull/2409?src=pr&el=lastupdated). Read the [comment docs](https://docs.codecov.io/docs/pull-request-comments).
   


----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org