[GitHub] [iceberg] pvary commented on a diff in pull request #4518: core: Provide mechanism to cache manifest file content

[GitBox <gi...@apache.org>]

pvary commented on code in PR #4518:
URL: https://github.com/apache/iceberg/pull/4518#discussion_r958600742


##########
core/src/main/java/org/apache/iceberg/ManifestFiles.java:
##########
@@ -300,4 +328,14 @@ private static ManifestFile copyManifestInternal(
 
     return writer.toManifestFile();
   }
+
+  private static InputFile newInputFile(FileIO io, String path, long length) {
+    InputFile inputFile = io.newInputFile(path, length);

Review Comment:
   I have seen cases where calling `newInputFile` was the bottleneck, since the HadoopFileIo created a new `FileSystem` object every time. Why did we decide to key the cache with the `inputFile` instead of the `path`?



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: issues-unsubscribe@iceberg.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org


---------------------------------------------------------------------
To unsubscribe, e-mail: issues-unsubscribe@iceberg.apache.org
For additional commands, e-mail: issues-help@iceberg.apache.org