[GitHub] [orc] dongjoon-hyun commented on a diff in pull request #1449: ORC-1399 [C++] Return LongVectorBatch when createRowBatch for boolean type with useTightNumericVector option

["dongjoon-hyun (via GitHub)" <gi...@apache.org>]

dongjoon-hyun commented on code in PR #1449:
URL: https://github.com/apache/orc/pull/1449#discussion_r1146779649


##########
c++/src/TypeImpl.cc:
##########
@@ -286,7 +286,9 @@ namespace orc {
                                                               MemoryPool& memoryPool, bool encoded,
                                                               bool useTightNumericVector) const {
     switch (static_cast<int64_t>(kind)) {
-      case BOOLEAN:
+      case BOOLEAN: {

Review Comment:
   According to the PR title, do we need to use `useTightNumericVector` variable?



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: issues-unsubscribe@orc.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org