You are viewing a plain text version of this content. The canonical link for it is here.
Posted to github@arrow.apache.org by GitBox <gi...@apache.org> on 2021/01/02 12:50:54 UTC
[GitHub] [arrow] alamb commented on a change in pull request #9040: ARROW-11055: [Rust] [DataFusion] Support date_trunc function
alamb commented on a change in pull request #9040:
URL: https://github.com/apache/arrow/pull/9040#discussion_r550878395
##########
File path: rust/datafusion/src/physical_plan/datetime_expressions.rs
##########
@@ -205,6 +206,108 @@ pub fn to_timestamp(args: &[ArrayRef]) -> Result<TimestampNanosecondArray> {
Ok(TimestampNanosecondArray::from(Arc::new(data)))
}
+/// date_trunc SQL function
+pub fn date_trunc(args: &[ArrayRef]) -> Result<TimestampNanosecondArray> {
+ let granularity_array =
+ &args[0]
+ .as_any()
+ .downcast_ref::<StringArray>()
+ .ok_or_else(|| {
+ DataFusionError::Execution(
+ "Could not cast date_trunc granularity input to StringArray"
+ .to_string(),
+ )
+ })?;
+
+ let array = &args[1]
+ .as_any()
+ .downcast_ref::<TimestampNanosecondArray>()
+ .ok_or_else(|| {
+ DataFusionError::Execution(
+ "Could not cast date_trunc array input to TimestampNanosecondArray"
+ .to_string(),
+ )
+ })?;
+
+ let range = 0..array.len();
+ let result = range
+ .map(|i| {
+ if array.is_null(i) {
+ Ok(0_i64)
+ } else {
+ let date_time = match granularity_array.value(i) {
Review comment:
This list seems consistent with https://www.postgresql.org/docs/9.1/functions-datetime.html#FUNCTIONS-DATETIME-TRUNC 👍 I think it is fine that we don't yeet support some of the more esoteric stuff (like milleniumm')
##########
File path: rust/datafusion/src/physical_plan/group_scalar.rs
##########
@@ -35,6 +35,8 @@ pub(crate) enum GroupByScalar {
Int32(i32),
Int64(i64),
Utf8(Box<String>),
+ TimeMicrosecond(i64),
+ TimeNanosecond(i64),
Review comment:
👍
##########
File path: rust/datafusion/src/physical_plan/datetime_expressions.rs
##########
@@ -378,6 +481,64 @@ mod tests {
Ok(())
}
+ #[test]
+ fn date_trunc_test() -> Result<()> {
+ let mut ts_builder = StringBuilder::new(2);
+ let mut truncated_builder = StringBuilder::new(2);
+ let mut string_builder = StringBuilder::new(2);
+
+ ts_builder.append_null()?;
+ truncated_builder.append_null()?;
+ string_builder.append_value("second")?;
+
+ ts_builder.append_value("2020-09-08T13:42:29.190855Z")?;
+ truncated_builder.append_value("2020-09-08T13:42:29.000000Z")?;
+ string_builder.append_value("second")?;
+
+ ts_builder.append_value("2020-09-08T13:42:29.190855Z")?;
+ truncated_builder.append_value("2020-09-08T13:42:00.000000Z")?;
+ string_builder.append_value("minute")?;
+
+ ts_builder.append_value("2020-09-08T13:42:29.190855Z")?;
+ truncated_builder.append_value("2020-09-08T13:00:00.000000Z")?;
+ string_builder.append_value("hour")?;
+
+ ts_builder.append_value("2020-09-08T13:42:29.190855Z")?;
+ truncated_builder.append_value("2020-09-08T00:00:00.000000Z")?;
+ string_builder.append_value("day")?;
+
+ ts_builder.append_value("2020-09-08T13:42:29.190855Z")?;
+ truncated_builder.append_value("2020-09-07T00:00:00.000000Z")?;
+ string_builder.append_value("week")?;
+
+ ts_builder.append_value("2020-09-08T13:42:29.190855Z")?;
+ truncated_builder.append_value("2020-09-01T00:00:00.000000Z")?;
+ string_builder.append_value("month")?;
+
+ ts_builder.append_value("2020-09-08T13:42:29.190855Z")?;
+ truncated_builder.append_value("2020-01-01T00:00:00.000000Z")?;
+ string_builder.append_value("year")?;
+
+ ts_builder.append_value("2021-01-01T13:42:29.190855Z")?;
+ truncated_builder.append_value("2020-12-28T00:00:00.000000Z")?;
+ string_builder.append_value("week")?;
+
+ ts_builder.append_value("2020-01-01T13:42:29.190855Z")?;
+ truncated_builder.append_value("2019-12-30T00:00:00.000000Z")?;
Review comment:
👍
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org