You are viewing a plain text version of this content. The canonical link for it is here.
Posted to codereview@trafodion.apache.org by amandamoran <gi...@git.apache.org> on 2015/12/09 01:25:28 UTC
[GitHub] incubator-trafodion pull request: TRAFODION 1547 and TRAFODION 147...
GitHub user amandamoran opened a pull request:
https://github.com/apache/incubator-trafodion/pull/217
TRAFODION 1547 and TRAFODION 1476
You can merge this pull request into a Git repository by running:
$ git pull https://github.com/amandamoran/incubator-trafodion installbugfixes
Alternatively you can review and apply these changes as the patch at:
https://github.com/apache/incubator-trafodion/pull/217.patch
To close this pull request, make a commit to your master/trunk branch
with (at least) the following in the commit message:
This closes #217
----
commit 9f0a61bab4478c18c91259aedad19ebe310598d2
Author: Amanda Moran <am...@apache.com>
Date: 2015-12-09T00:20:08Z
Fix for passwordless ssh and EPEL issue
----
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
[GitHub] incubator-trafodion pull request: TRAFODION 1547 and TRAFODION 147...
Posted by amandamoran <gi...@git.apache.org>.
Github user amandamoran commented on a diff in the pull request:
https://github.com/apache/incubator-trafodion/pull/217#discussion_r47133790
--- Diff: install/installer/traf_add_user ---
@@ -208,15 +208,26 @@ fi
#=================================================
# Cycle through all nodes to create known_hosts file, even if only one node
echo "***INFO: Creating known_hosts file for all nodes"
+NODES_SHORT=""
for node in $NODE_LIST
-do
- sudo su $TRAF_USER --command "ssh -q -oStrictHostKeyChecking=no $node hostname"
- if [ $? -ne 0 ]; then
- echo "***ERROR: Unable to ssh to node $node"
- exit -1
- fi
+do
+ newNode=$(ssh -q -n $node hostname -s)
--- End diff --
Yes, the user needs to set up passwordless ssh and there is a check for that earlier in traf_config_check
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
[GitHub] incubator-trafodion pull request: TRAFODION 1547 and TRAFODION 147...
Posted by asfgit <gi...@git.apache.org>.
Github user asfgit closed the pull request at:
https://github.com/apache/incubator-trafodion/pull/217
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
[GitHub] incubator-trafodion pull request: TRAFODION 1547 and TRAFODION 147...
Posted by arvind-narain <gi...@git.apache.org>.
Github user arvind-narain commented on a diff in the pull request:
https://github.com/apache/incubator-trafodion/pull/217#discussion_r47122312
--- Diff: install/installer/traf_add_user ---
@@ -208,15 +208,26 @@ fi
#=================================================
# Cycle through all nodes to create known_hosts file, even if only one node
echo "***INFO: Creating known_hosts file for all nodes"
+NODES_SHORT=""
for node in $NODE_LIST
-do
- sudo su $TRAF_USER --command "ssh -q -oStrictHostKeyChecking=no $node hostname"
- if [ $? -ne 0 ]; then
- echo "***ERROR: Unable to ssh to node $node"
- exit -1
- fi
+do
+ newNode=$(ssh -q -n $node hostname -s)
--- End diff --
should the passwordless ssh for $NODE_LIST be setup first?
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---