You are viewing a plain text version of this content. The canonical link for it is here.
Posted to commits@harmony.apache.org by "Alexei Zakharov (JIRA)" <ji...@apache.org> on 2006/07/09 20:47:29 UTC

[jira] Created: (HARMONY-804) [classlib][beans] enabling of tests from StatementTest class (2)

[classlib][beans] enabling of tests from StatementTest class (2)
----------------------------------------------------------------

         Key: HARMONY-804
         URL: http://issues.apache.org/jira/browse/HARMONY-804
     Project: Harmony
        Type: Improvement

 Environment: winXP
    Reporter: Alexei Zakharov


The following tests from org.apache.harmony.beans.tests.java.beans.StatementTest were enabled:
testExecute_AmbitiousStaticMethod
testExecute_ClassForName

Change log (Statement.java):
1. Handling of static methods has been corrected. See changes for Statement.invokeMethod()
2. During method invocation time:
	- Method lookup is now performed in the current class then in the superclass, then in super class of super class and so on (JavaBeans 1.01 spec §8.3.1). This is the standard way of virtual function invocation. RI also follows this rule.
	- The lookup is performed for public methods only since this also clearly stated in spec (§8.5). RI follows the spec here.
3. I renamed testExecute_AmbitiousStaticMethod to testExecute_AmbiguousStaticMethod since IMHO this was an ordinary typo.

Please see the patch attached.

-- 
This message is automatically generated by JIRA.
-
If you think it was sent incorrectly contact one of the administrators:
   http://issues.apache.org/jira/secure/Administrators.jspa
-
For more information on JIRA, see:
   http://www.atlassian.com/software/jira


[jira] Updated: (HARMONY-804) [classlib][beans] enabling of tests from StatementTest class (2)

Posted by "Alexei Zakharov (JIRA)" <ji...@apache.org>.
     [ http://issues.apache.org/jira/browse/HARMONY-804?page=all ]

Alexei Zakharov updated HARMONY-804:
------------------------------------

    Attachment: StatementTest2.patch

> [classlib][beans] enabling of tests from StatementTest class (2)
> ----------------------------------------------------------------
>
>          Key: HARMONY-804
>          URL: http://issues.apache.org/jira/browse/HARMONY-804
>      Project: Harmony
>         Type: Improvement

>  Environment: winXP
>     Reporter: Alexei Zakharov
>  Attachments: StatementTest2.patch
>
> The following tests from org.apache.harmony.beans.tests.java.beans.StatementTest were enabled:
> testExecute_AmbitiousStaticMethod
> testExecute_ClassForName
> Change log (Statement.java):
> 1. Handling of static methods has been corrected. See changes for Statement.invokeMethod()
> 2. During method invocation time:
> 	- Method lookup is now performed in the current class then in the superclass, then in super class of super class and so on (JavaBeans 1.01 spec §8.3.1). This is the standard way of virtual function invocation. RI also follows this rule.
> 	- The lookup is performed for public methods only since this also clearly stated in spec (§8.5). RI follows the spec here.
> 3. I renamed testExecute_AmbitiousStaticMethod to testExecute_AmbiguousStaticMethod since IMHO this was an ordinary typo.
> Please see the patch attached.

-- 
This message is automatically generated by JIRA.
-
If you think it was sent incorrectly contact one of the administrators:
   http://issues.apache.org/jira/secure/Administrators.jspa
-
For more information on JIRA, see:
   http://www.atlassian.com/software/jira


[jira] Resolved: (HARMONY-804) [classlib][beans] enabling of tests from StatementTest class (2)

Posted by "Mikhail Loenko (JIRA)" <ji...@apache.org>.
     [ http://issues.apache.org/jira/browse/HARMONY-804?page=all ]
     
Mikhail Loenko resolved HARMONY-804:
------------------------------------

    Resolution: Fixed

fixed in revision 420454
Alexei, please check that it was applied as expected

> [classlib][beans] enabling of tests from StatementTest class (2)
> ----------------------------------------------------------------
>
>          Key: HARMONY-804
>          URL: http://issues.apache.org/jira/browse/HARMONY-804
>      Project: Harmony
>         Type: Improvement

>  Environment: winXP
>     Reporter: Alexei Zakharov
>     Assignee: Mikhail Loenko
>  Attachments: StatementTest2.patch
>
> The following tests from org.apache.harmony.beans.tests.java.beans.StatementTest were enabled:
> testExecute_AmbitiousStaticMethod
> testExecute_ClassForName
> Change log (Statement.java):
> 1. Handling of static methods has been corrected. See changes for Statement.invokeMethod()
> 2. During method invocation time:
> 	- Method lookup is now performed in the current class then in the superclass, then in super class of super class and so on (JavaBeans 1.01 spec §8.3.1). This is the standard way of virtual function invocation. RI also follows this rule.
> 	- The lookup is performed for public methods only since this also clearly stated in spec (§8.5). RI follows the spec here.
> 3. I renamed testExecute_AmbitiousStaticMethod to testExecute_AmbiguousStaticMethod since IMHO this was an ordinary typo.
> Please see the patch attached.

-- 
This message is automatically generated by JIRA.
-
If you think it was sent incorrectly contact one of the administrators:
   http://issues.apache.org/jira/secure/Administrators.jspa
-
For more information on JIRA, see:
   http://www.atlassian.com/software/jira


[jira] Assigned: (HARMONY-804) [classlib][beans] enabling of tests from StatementTest class (2)

Posted by "Mikhail Loenko (JIRA)" <ji...@apache.org>.
     [ http://issues.apache.org/jira/browse/HARMONY-804?page=all ]

Mikhail Loenko reassigned HARMONY-804:
--------------------------------------

    Assign To: Mikhail Loenko

> [classlib][beans] enabling of tests from StatementTest class (2)
> ----------------------------------------------------------------
>
>          Key: HARMONY-804
>          URL: http://issues.apache.org/jira/browse/HARMONY-804
>      Project: Harmony
>         Type: Improvement

>  Environment: winXP
>     Reporter: Alexei Zakharov
>     Assignee: Mikhail Loenko
>  Attachments: StatementTest2.patch
>
> The following tests from org.apache.harmony.beans.tests.java.beans.StatementTest were enabled:
> testExecute_AmbitiousStaticMethod
> testExecute_ClassForName
> Change log (Statement.java):
> 1. Handling of static methods has been corrected. See changes for Statement.invokeMethod()
> 2. During method invocation time:
> 	- Method lookup is now performed in the current class then in the superclass, then in super class of super class and so on (JavaBeans 1.01 spec §8.3.1). This is the standard way of virtual function invocation. RI also follows this rule.
> 	- The lookup is performed for public methods only since this also clearly stated in spec (§8.5). RI follows the spec here.
> 3. I renamed testExecute_AmbitiousStaticMethod to testExecute_AmbiguousStaticMethod since IMHO this was an ordinary typo.
> Please see the patch attached.

-- 
This message is automatically generated by JIRA.
-
If you think it was sent incorrectly contact one of the administrators:
   http://issues.apache.org/jira/secure/Administrators.jspa
-
For more information on JIRA, see:
   http://www.atlassian.com/software/jira


[jira] Commented: (HARMONY-804) [classlib][beans] enabling of tests from StatementTest class (2)

Posted by "Alexei Zakharov (JIRA)" <ji...@apache.org>.
    [ http://issues.apache.org/jira/browse/HARMONY-804?page=comments#action_12420303 ] 

Alexei Zakharov commented on HARMONY-804:
-----------------------------------------

Everything is fine, thanks.

> [classlib][beans] enabling of tests from StatementTest class (2)
> ----------------------------------------------------------------
>
>          Key: HARMONY-804
>          URL: http://issues.apache.org/jira/browse/HARMONY-804
>      Project: Harmony
>         Type: Improvement

>  Environment: winXP
>     Reporter: Alexei Zakharov
>     Assignee: Mikhail Loenko
>  Attachments: StatementTest2.patch
>
> The following tests from org.apache.harmony.beans.tests.java.beans.StatementTest were enabled:
> testExecute_AmbitiousStaticMethod
> testExecute_ClassForName
> Change log (Statement.java):
> 1. Handling of static methods has been corrected. See changes for Statement.invokeMethod()
> 2. During method invocation time:
> 	- Method lookup is now performed in the current class then in the superclass, then in super class of super class and so on (JavaBeans 1.01 spec §8.3.1). This is the standard way of virtual function invocation. RI also follows this rule.
> 	- The lookup is performed for public methods only since this also clearly stated in spec (§8.5). RI follows the spec here.
> 3. I renamed testExecute_AmbitiousStaticMethod to testExecute_AmbiguousStaticMethod since IMHO this was an ordinary typo.
> Please see the patch attached.

-- 
This message is automatically generated by JIRA.
-
If you think it was sent incorrectly contact one of the administrators:
   http://issues.apache.org/jira/secure/Administrators.jspa
-
For more information on JIRA, see:
   http://www.atlassian.com/software/jira