You are viewing a plain text version of this content. The canonical link for it is here.
Posted to commits@airflow.apache.org by GitBox <gi...@apache.org> on 2020/10/21 20:09:28 UTC
[GitHub] [airflow] grepthat opened a new pull request #11729: Allow Kubernetes ServiceAccount airflow-webserver to read pod logs
grepthat opened a new pull request #11729:
URL: https://github.com/apache/airflow/pull/11729
Hello, this is small fix to the helm-chart.
This is to give the *airflow-webserver* service account access to the pod logs.
related: #11696
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [airflow] stale[bot] commented on pull request #11729: Allow Kubernetes ServiceAccount airflow-webserver to read pod logs
Posted by GitBox <gi...@apache.org>.
stale[bot] commented on pull request #11729:
URL: https://github.com/apache/airflow/pull/11729#issuecomment-751239978
This issue has been automatically marked as stale because it has not had recent activity. It will be closed if no further activity occurs. Thank you for your contributions.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [airflow] kaxil commented on pull request #11729: Allow Kubernetes ServiceAccount airflow-webserver to read pod logs
Posted by GitBox <gi...@apache.org>.
kaxil commented on pull request #11729:
URL: https://github.com/apache/airflow/pull/11729#issuecomment-721445153
Can you please rebase your PR on latest Master since we have applied [Black](https://github.com/apache/airflow/commit/4e8f9cc8d02b29c325b8a5a76b4837671bdf5f68) and [PyUpgrade](https://github.com/apache/airflow/commit/8c42cf1b00c90f0d7f11b8a3a455381de8e003c5) on Master.
It will help if your squash your commits into single commit first so that there are less conflicts.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [airflow] grepthat commented on pull request #11729: Allow Kubernetes ServiceAccount airflow-webserver to read pod logs
Posted by GitBox <gi...@apache.org>.
grepthat commented on pull request #11729:
URL: https://github.com/apache/airflow/pull/11729#issuecomment-751343339
https://github.com/apache/airflow/pull/12598 closes this
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [airflow] mik-laj commented on pull request #11729: Allow Kubernetes ServiceAccount airflow-webserver to read pod logs
Posted by GitBox <gi...@apache.org>.
mik-laj commented on pull request #11729:
URL: https://github.com/apache/airflow/pull/11729#issuecomment-751252108
Is it related? https://github.com/apache/airflow/pull/12598
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [airflow] FloChehab commented on pull request #11729: Allow Kubernetes ServiceAccount airflow-webserver to read pod logs
Posted by GitBox <gi...@apache.org>.
FloChehab commented on pull request #11729:
URL: https://github.com/apache/airflow/pull/11729#issuecomment-715505017
So let's follow up from the issue :)
I'd personally put this change in a new role & rolebinding as this is not related to "launching pods" ; otherwise looks good to me.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [airflow] boring-cyborg[bot] commented on pull request #11729: Allow Kubernetes ServiceAccount airflow-webserver to read pod logs
Posted by GitBox <gi...@apache.org>.
boring-cyborg[bot] commented on pull request #11729:
URL: https://github.com/apache/airflow/pull/11729#issuecomment-713844768
Congratulations on your first Pull Request and welcome to the Apache Airflow community! If you have any issues or are unsure about any anything please check our Contribution Guide (https://github.com/apache/airflow/blob/master/CONTRIBUTING.rst)
Here are some useful points:
- Pay attention to the quality of your code (flake8, pylint and type annotations). Our [pre-commits]( https://github.com/apache/airflow/blob/master/STATIC_CODE_CHECKS.rst#prerequisites-for-pre-commit-hooks) will help you with that.
- In case of a new feature add useful documentation (in docstrings or in `docs/` directory). Adding a new operator? Check this short [guide](https://github.com/apache/airflow/blob/master/docs/howto/custom-operator.rst) Consider adding an example DAG that shows how users should use it.
- Consider using [Breeze environment](https://github.com/apache/airflow/blob/master/BREEZE.rst) for testing locally, itโs a heavy docker but it ships with a working Airflow and a lot of integrations.
- Be patient and persistent. It might take some time to get a review or get the final approval from Committers.
- Please follow [ASF Code of Conduct](https://www.apache.org/foundation/policies/conduct) for all communication including (but not limited to) comments on Pull Requests, Mailing list and Slack.
- Be sure to read the [Airflow Coding style]( https://github.com/apache/airflow/blob/master/CONTRIBUTING.rst#coding-style-and-best-practices).
Apache Airflow is a community-driven project and together we are making it better ๐.
In case of doubts contact the developers at:
Mailing List: dev@airflow.apache.org
Slack: https://s.apache.org/airflow-slack
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [airflow] grepthat closed pull request #11729: Allow Kubernetes ServiceAccount airflow-webserver to read pod logs
Posted by GitBox <gi...@apache.org>.
grepthat closed pull request #11729:
URL: https://github.com/apache/airflow/pull/11729
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [airflow] mik-laj commented on pull request #11729: Allow Kubernetes ServiceAccount airflow-webserver to read pod logs
Posted by GitBox <gi...@apache.org>.
mik-laj commented on pull request #11729:
URL: https://github.com/apache/airflow/pull/11729#issuecomment-715627718
> I'd personally put this change in a new role & rolebinding
I agree. This will make it easier to complete another ticket: https://github.com/apache/airflow/issues/11728
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org