You are viewing a plain text version of this content. The canonical link for it is here.
Posted to issues@struts.apache.org by "Piero Sartini (JIRA)" <ji...@apache.org> on 2007/09/17 15:42:36 UTC
[jira] Created: (WW-2188) Incompatible API Change in Component.java
Incompatible API Change in Component.java
-----------------------------------------
Key: WW-2188
URL: https://issues.apache.org/struts/browse/WW-2188
Project: Struts 2
Issue Type: Bug
Affects Versions: 2.0.10
Reporter: Piero Sartini
There was an incompatible API change in
org.apache.struts2.components.Component
The determineActionURL method has 2 new parameters which were not present in
2.0.9 and are passed to UrlHelper.java:
boolean forceAddSchemeHostAndPort, boolean escapeAmp
It should be safe to call with
forceAddSchemeHostAndPort=false, escapeAmp=true
(That is what UrlHelper.java does when these params are missing ..)
--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.
[jira] Resolved: (WW-2188) Incompatible API Change in
Component.java
Posted by "James Holmes (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/struts/browse/WW-2188?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]
James Holmes resolved WW-2188.
------------------------------
Resolution: Fixed
Thanks for the patch! I was already in the middle of fixing this issue when you sent it in. Our change is the same.
Fixed in SVN revision 576442.
> Incompatible API Change in Component.java
> -----------------------------------------
>
> Key: WW-2188
> URL: https://issues.apache.org/struts/browse/WW-2188
> Project: Struts 2
> Issue Type: Bug
> Affects Versions: 2.0.10
> Reporter: Piero Sartini
> Assignee: James Holmes
> Fix For: 2.0.11
>
> Attachments: ww-2188.patch
>
>
> There was an incompatible API change in
> org.apache.struts2.components.Component
> The determineActionURL method has 2 new parameters which were not present in
> 2.0.9 and are passed to UrlHelper.java:
> boolean forceAddSchemeHostAndPort, boolean escapeAmp
> It should be safe to call with
> forceAddSchemeHostAndPort=false, escapeAmp=true
> (That is what UrlHelper.java does when these params are missing ..)
--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.
[jira] Commented: (WW-2188) Incompatible API Change in
Component.java
Posted by "James Holmes (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/struts/browse/WW-2188?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel#action_42214 ]
James Holmes commented on WW-2188:
----------------------------------
Thanks for catching that Antonio. I simply overlooked it.
> Incompatible API Change in Component.java
> -----------------------------------------
>
> Key: WW-2188
> URL: https://issues.apache.org/struts/browse/WW-2188
> Project: Struts 2
> Issue Type: Bug
> Affects Versions: 2.0.10
> Reporter: Piero Sartini
> Assignee: James Holmes
> Fix For: 2.0.11
>
> Attachments: ww-2188.patch
>
>
> There was an incompatible API change in
> org.apache.struts2.components.Component
> The determineActionURL method has 2 new parameters which were not present in
> 2.0.9 and are passed to UrlHelper.java:
> boolean forceAddSchemeHostAndPort, boolean escapeAmp
> It should be safe to call with
> forceAddSchemeHostAndPort=false, escapeAmp=true
> (That is what UrlHelper.java does when these params are missing ..)
--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.
[jira] Commented: (WW-2188) Incompatible API Change in
Component.java
Posted by "Antonio Petrelli (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/struts/browse/WW-2188?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel#action_42211 ]
Antonio Petrelli commented on WW-2188:
--------------------------------------
Just a question, James: why did not you deprecate the old method?
> Incompatible API Change in Component.java
> -----------------------------------------
>
> Key: WW-2188
> URL: https://issues.apache.org/struts/browse/WW-2188
> Project: Struts 2
> Issue Type: Bug
> Affects Versions: 2.0.10
> Reporter: Piero Sartini
> Assignee: James Holmes
> Fix For: 2.0.11
>
> Attachments: ww-2188.patch
>
>
> There was an incompatible API change in
> org.apache.struts2.components.Component
> The determineActionURL method has 2 new parameters which were not present in
> 2.0.9 and are passed to UrlHelper.java:
> boolean forceAddSchemeHostAndPort, boolean escapeAmp
> It should be safe to call with
> forceAddSchemeHostAndPort=false, escapeAmp=true
> (That is what UrlHelper.java does when these params are missing ..)
--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.
[jira] Updated: (WW-2188) Incompatible API Change in Component.java
Posted by "Piero Sartini (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/struts/browse/WW-2188?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]
Piero Sartini updated WW-2188:
------------------------------
Attachment: ww-2188.patch
> Incompatible API Change in Component.java
> -----------------------------------------
>
> Key: WW-2188
> URL: https://issues.apache.org/struts/browse/WW-2188
> Project: Struts 2
> Issue Type: Bug
> Affects Versions: 2.0.10
> Reporter: Piero Sartini
> Attachments: ww-2188.patch
>
>
> There was an incompatible API change in
> org.apache.struts2.components.Component
> The determineActionURL method has 2 new parameters which were not present in
> 2.0.9 and are passed to UrlHelper.java:
> boolean forceAddSchemeHostAndPort, boolean escapeAmp
> It should be safe to call with
> forceAddSchemeHostAndPort=false, escapeAmp=true
> (That is what UrlHelper.java does when these params are missing ..)
--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.
[jira] Issue Comment Edited: (WW-2188) Incompatible API Change in
Component.java
Posted by "James Holmes (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/struts/browse/WW-2188?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel#action_42214 ]
jholmes edited comment on WW-2188 at 9/17/07 7:35 AM:
-----------------------------------------------------------
Thanks for catching that Antonio. I simply overlooked it.
Fixed in SVN revision 576454.
was (Author: jholmes):
Thanks for catching that Antonio. I simply overlooked it.
> Incompatible API Change in Component.java
> -----------------------------------------
>
> Key: WW-2188
> URL: https://issues.apache.org/struts/browse/WW-2188
> Project: Struts 2
> Issue Type: Bug
> Affects Versions: 2.0.10
> Reporter: Piero Sartini
> Assignee: James Holmes
> Fix For: 2.0.11
>
> Attachments: ww-2188.patch
>
>
> There was an incompatible API change in
> org.apache.struts2.components.Component
> The determineActionURL method has 2 new parameters which were not present in
> 2.0.9 and are passed to UrlHelper.java:
> boolean forceAddSchemeHostAndPort, boolean escapeAmp
> It should be safe to call with
> forceAddSchemeHostAndPort=false, escapeAmp=true
> (That is what UrlHelper.java does when these params are missing ..)
--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.
[jira] Assigned: (WW-2188) Incompatible API Change in
Component.java
Posted by "James Holmes (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/struts/browse/WW-2188?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]
James Holmes reassigned WW-2188:
--------------------------------
Assignee: James Holmes
> Incompatible API Change in Component.java
> -----------------------------------------
>
> Key: WW-2188
> URL: https://issues.apache.org/struts/browse/WW-2188
> Project: Struts 2
> Issue Type: Bug
> Affects Versions: 2.0.10
> Reporter: Piero Sartini
> Assignee: James Holmes
> Fix For: 2.0.11
>
> Attachments: ww-2188.patch
>
>
> There was an incompatible API change in
> org.apache.struts2.components.Component
> The determineActionURL method has 2 new parameters which were not present in
> 2.0.9 and are passed to UrlHelper.java:
> boolean forceAddSchemeHostAndPort, boolean escapeAmp
> It should be safe to call with
> forceAddSchemeHostAndPort=false, escapeAmp=true
> (That is what UrlHelper.java does when these params are missing ..)
--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.
[jira] Updated: (WW-2188) Incompatible API Change in Component.java
Posted by "James Holmes (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/struts/browse/WW-2188?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]
James Holmes updated WW-2188:
-----------------------------
Fix Version/s: 2.0.11
> Incompatible API Change in Component.java
> -----------------------------------------
>
> Key: WW-2188
> URL: https://issues.apache.org/struts/browse/WW-2188
> Project: Struts 2
> Issue Type: Bug
> Affects Versions: 2.0.10
> Reporter: Piero Sartini
> Assignee: James Holmes
> Fix For: 2.0.11
>
> Attachments: ww-2188.patch
>
>
> There was an incompatible API change in
> org.apache.struts2.components.Component
> The determineActionURL method has 2 new parameters which were not present in
> 2.0.9 and are passed to UrlHelper.java:
> boolean forceAddSchemeHostAndPort, boolean escapeAmp
> It should be safe to call with
> forceAddSchemeHostAndPort=false, escapeAmp=true
> (That is what UrlHelper.java does when these params are missing ..)
--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.