You are viewing a plain text version of this content. The canonical link for it is here.
Posted to reviews@mesos.apache.org by Joris Van Remoortere <jo...@gmail.com> on 2015/07/27 09:19:13 UTC
Review Request 36842: Mesos: Introduce configurable `UNIMPLEMENTED`
macro.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/36842/
-----------------------------------------------------------
Review request for mesos, Benjamin Hindman, Artem Harutyunyan, Joseph Wu, and Michael Park.
Bugs: MESOS-3122
https://issues.apache.org/jira/browse/MESOS-3122
Repository: mesos
Description
-------
use --enable-static-unimplemented to get compile time errors as opposed
to runtime errors.
Diffs
-----
configure.ac 546c9bbf775a4ef481fafb3a58c85c6d80e19500
Diff: https://reviews.apache.org/r/36842/diff/
Testing
-------
created a function with an `UNIMPLEMENTED()` body and verified the runtime error occured when configured by default, and a compile-time error ocurred when configured with `--enable-static-unimplemented`
Thanks,
Joris Van Remoortere
Re: Review Request 36842: Mesos: Introduce configurable
`UNIMPLEMENTED` macro.
Posted by Michael Park <mc...@gmail.com>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/36842/#review93804
-----------------------------------------------------------
Ship it!
Ship It!
- Michael Park
On July 31, 2015, 9:54 p.m., Joris Van Remoortere wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/36842/
> -----------------------------------------------------------
>
> (Updated July 31, 2015, 9:54 p.m.)
>
>
> Review request for mesos, Benjamin Hindman, Artem Harutyunyan, Joseph Wu, and Michael Park.
>
>
> Bugs: MESOS-3122
> https://issues.apache.org/jira/browse/MESOS-3122
>
>
> Repository: mesos
>
>
> Description
> -------
>
> use --enable-static-unimplemented to get compile time errors as opposed
> to runtime errors.
>
>
> Diffs
> -----
>
> configure.ac 546c9bbf775a4ef481fafb3a58c85c6d80e19500
>
> Diff: https://reviews.apache.org/r/36842/diff/
>
>
> Testing
> -------
>
> created a function with an `UNIMPLEMENTED()` body and verified the runtime error occured when configured by default, and a compile-time error ocurred when configured with `--enable-static-unimplemented`
>
>
> Thanks,
>
> Joris Van Remoortere
>
>
Re: Review Request 36842: Mesos: Introduce configurable
`UNIMPLEMENTED` macro.
Posted by Ben Mahler <be...@gmail.com>.
> On Aug. 1, 2015, 12:22 a.m., Ben Mahler wrote:
> > configure.ac, lines 1560-1561
> > <https://reviews.apache.org/r/36842/diff/2/?file=1026427#file1026427line1560>
> >
> > Hm.. coming across this I can't tell how this works, mind adding a comment?
> >
> > The following seems like magic:
> >
> > ```
> > inline Try<Nothing> cloexec(int fd)
> > {
> > UNIMPLEMENTED; // what is this symbol? can't find it
> > }
> > ```
Ah, sorry I was looking at UNIMPLEMENTED in some of the committed os.hpp code before unimplemented.hpp was committed, I guess the commit order was wrong?
Anyway, perhaps having a pointer to stout's unimplemented.hpp would be nice in the configure.ac code.
- Ben
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/36842/#review93823
-----------------------------------------------------------
On July 31, 2015, 9:54 p.m., Joris Van Remoortere wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/36842/
> -----------------------------------------------------------
>
> (Updated July 31, 2015, 9:54 p.m.)
>
>
> Review request for mesos, Benjamin Hindman, Artem Harutyunyan, Joseph Wu, and Michael Park.
>
>
> Bugs: MESOS-3122
> https://issues.apache.org/jira/browse/MESOS-3122
>
>
> Repository: mesos
>
>
> Description
> -------
>
> use --enable-static-unimplemented to get compile time errors as opposed
> to runtime errors.
>
>
> Diffs
> -----
>
> configure.ac 546c9bbf775a4ef481fafb3a58c85c6d80e19500
>
> Diff: https://reviews.apache.org/r/36842/diff/
>
>
> Testing
> -------
>
> created a function with an `UNIMPLEMENTED()` body and verified the runtime error occured when configured by default, and a compile-time error ocurred when configured with `--enable-static-unimplemented`
>
>
> Thanks,
>
> Joris Van Remoortere
>
>
Re: Review Request 36842: Mesos: Introduce configurable
`UNIMPLEMENTED` macro.
Posted by Ben Mahler <be...@gmail.com>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/36842/#review93823
-----------------------------------------------------------
configure.ac (lines 1560 - 1561)
<https://reviews.apache.org/r/36842/#comment148218>
Hm.. coming across this I can't tell how this works, mind adding a comment?
The following seems like magic:
```
inline Try<Nothing> cloexec(int fd)
{
UNIMPLEMENTED; // what is this symbol? can't find it
}
```
- Ben Mahler
On July 31, 2015, 9:54 p.m., Joris Van Remoortere wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/36842/
> -----------------------------------------------------------
>
> (Updated July 31, 2015, 9:54 p.m.)
>
>
> Review request for mesos, Benjamin Hindman, Artem Harutyunyan, Joseph Wu, and Michael Park.
>
>
> Bugs: MESOS-3122
> https://issues.apache.org/jira/browse/MESOS-3122
>
>
> Repository: mesos
>
>
> Description
> -------
>
> use --enable-static-unimplemented to get compile time errors as opposed
> to runtime errors.
>
>
> Diffs
> -----
>
> configure.ac 546c9bbf775a4ef481fafb3a58c85c6d80e19500
>
> Diff: https://reviews.apache.org/r/36842/diff/
>
>
> Testing
> -------
>
> created a function with an `UNIMPLEMENTED()` body and verified the runtime error occured when configured by default, and a compile-time error ocurred when configured with `--enable-static-unimplemented`
>
>
> Thanks,
>
> Joris Van Remoortere
>
>
Re: Review Request 36842: Mesos: Introduce configurable
`UNIMPLEMENTED` macro.
Posted by Joris Van Remoortere <jo...@gmail.com>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/36842/
-----------------------------------------------------------
(Updated July 31, 2015, 9:54 p.m.)
Review request for mesos, Benjamin Hindman, Artem Harutyunyan, Joseph Wu, and Michael Park.
Changes
-------
rebased.
Bugs: MESOS-3122
https://issues.apache.org/jira/browse/MESOS-3122
Repository: mesos
Description
-------
use --enable-static-unimplemented to get compile time errors as opposed
to runtime errors.
Diffs (updated)
-----
configure.ac 546c9bbf775a4ef481fafb3a58c85c6d80e19500
Diff: https://reviews.apache.org/r/36842/diff/
Testing
-------
created a function with an `UNIMPLEMENTED()` body and verified the runtime error occured when configured by default, and a compile-time error ocurred when configured with `--enable-static-unimplemented`
Thanks,
Joris Van Remoortere
Re: Review Request 36842: Mesos: Introduce configurable
`UNIMPLEMENTED` macro.
Posted by Artem Harutyunyan <ar...@mesosphere.io>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/36842/#review93124
-----------------------------------------------------------
Ship it!
Ship It!
- Artem Harutyunyan
On July 27, 2015, 12:19 a.m., Joris Van Remoortere wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/36842/
> -----------------------------------------------------------
>
> (Updated July 27, 2015, 12:19 a.m.)
>
>
> Review request for mesos, Benjamin Hindman, Artem Harutyunyan, Joseph Wu, and Michael Park.
>
>
> Bugs: MESOS-3122
> https://issues.apache.org/jira/browse/MESOS-3122
>
>
> Repository: mesos
>
>
> Description
> -------
>
> use --enable-static-unimplemented to get compile time errors as opposed
> to runtime errors.
>
>
> Diffs
> -----
>
> configure.ac 546c9bbf775a4ef481fafb3a58c85c6d80e19500
>
> Diff: https://reviews.apache.org/r/36842/diff/
>
>
> Testing
> -------
>
> created a function with an `UNIMPLEMENTED()` body and verified the runtime error occured when configured by default, and a compile-time error ocurred when configured with `--enable-static-unimplemented`
>
>
> Thanks,
>
> Joris Van Remoortere
>
>
Re: Review Request 36842: Mesos: Introduce configurable
`UNIMPLEMENTED` macro.
Posted by Mesos ReviewBot <re...@mesos.apache.org>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/36842/#review93099
-----------------------------------------------------------
Patch looks great!
Reviews applied: [36822, 36823, 36824, 36825, 36826, 36827, 36828, 36829, 36830, 36842]
All tests passed.
- Mesos ReviewBot
On July 27, 2015, 7:19 a.m., Joris Van Remoortere wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/36842/
> -----------------------------------------------------------
>
> (Updated July 27, 2015, 7:19 a.m.)
>
>
> Review request for mesos, Benjamin Hindman, Artem Harutyunyan, Joseph Wu, and Michael Park.
>
>
> Bugs: MESOS-3122
> https://issues.apache.org/jira/browse/MESOS-3122
>
>
> Repository: mesos
>
>
> Description
> -------
>
> use --enable-static-unimplemented to get compile time errors as opposed
> to runtime errors.
>
>
> Diffs
> -----
>
> configure.ac 546c9bbf775a4ef481fafb3a58c85c6d80e19500
>
> Diff: https://reviews.apache.org/r/36842/diff/
>
>
> Testing
> -------
>
> created a function with an `UNIMPLEMENTED()` body and verified the runtime error occured when configured by default, and a compile-time error ocurred when configured with `--enable-static-unimplemented`
>
>
> Thanks,
>
> Joris Van Remoortere
>
>
Re: Review Request 36842: Mesos: Introduce configurable
`UNIMPLEMENTED` macro.
Posted by Joseph Wu <jo...@mesosphere.io>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/36842/#review93146
-----------------------------------------------------------
Ship it!
Ship It!
- Joseph Wu
On July 27, 2015, 12:19 a.m., Joris Van Remoortere wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/36842/
> -----------------------------------------------------------
>
> (Updated July 27, 2015, 12:19 a.m.)
>
>
> Review request for mesos, Benjamin Hindman, Artem Harutyunyan, Joseph Wu, and Michael Park.
>
>
> Bugs: MESOS-3122
> https://issues.apache.org/jira/browse/MESOS-3122
>
>
> Repository: mesos
>
>
> Description
> -------
>
> use --enable-static-unimplemented to get compile time errors as opposed
> to runtime errors.
>
>
> Diffs
> -----
>
> configure.ac 546c9bbf775a4ef481fafb3a58c85c6d80e19500
>
> Diff: https://reviews.apache.org/r/36842/diff/
>
>
> Testing
> -------
>
> created a function with an `UNIMPLEMENTED()` body and verified the runtime error occured when configured by default, and a compile-time error ocurred when configured with `--enable-static-unimplemented`
>
>
> Thanks,
>
> Joris Van Remoortere
>
>