You are viewing a plain text version of this content. The canonical link for it is here.
Posted to codereview@trafodion.apache.org by sandhyasun <gi...@git.apache.org> on 2015/11/15 02:26:28 UTC
[GitHub] incubator-trafodion pull request: Fix for the executor/TEST106 fai...
GitHub user sandhyasun opened a pull request:
https://github.com/apache/incubator-trafodion/pull/175
Fix for the executor/TEST106 failure caused due to JIRA TRAFODION-1625
A delete query on a 200K large table was marked as a unique delete. This was found when the long operation was not being cancelled when a cancel query was issued. Unique queries are typcially not cancelable since they are short running. The issue happens when rowset deletes are chosen . This plan change happened recently due to a costing change. The rowset operation needs to be marked as cancelable.
You can merge this pull request into a Git repository by running:
$ git pull https://github.com/sandhyasun/incubator-trafodion sandhya_traf_fixes
Alternatively you can review and apply these changes as the patch at:
https://github.com/apache/incubator-trafodion/pull/175.patch
To close this pull request, make a commit to your master/trunk branch
with (at least) the following in the commit message:
This closes #175
----
commit adafbd5f0159ef18fcbd052e1c11b231ee3a9099
Author: Sandhya Sundaresan <sa...@apache.org>
Date: 2015-11-15T01:01:44Z
Fix for the core/TEST106 failure caused due to JIRA TRAFODION-1625
----
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
[GitHub] incubator-trafodion pull request: Fix for the executor/TEST106 fai...
Posted by asfgit <gi...@git.apache.org>.
Github user asfgit closed the pull request at:
https://github.com/apache/incubator-trafodion/pull/175
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
[GitHub] incubator-trafodion pull request: Fix for the executor/TEST106 fai...
Posted by selvaganesang <gi...@git.apache.org>.
Github user selvaganesang commented on a diff in the pull request:
https://github.com/apache/incubator-trafodion/pull/175#discussion_r44961933
--- Diff: core/sql/generator/GenPreCode.cpp ---
@@ -4934,8 +4934,9 @@ RelExpr * HbaseDelete::preCodeGen(Generator * generator,
else
if (isUnique)
{
- // do not cancel unique queries.
- generator->setMayNotCancel(TRUE);
+ if (!generator->oltOptInfo()->multipleRowsReturned())
+ // do not cancel unique queries.
+ generator->setMayNotCancel(TRUE);
--- End diff --
Revise the comment please.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
[GitHub] incubator-trafodion pull request: Fix for the executor/TEST106 fai...
Posted by sandhyasun <gi...@git.apache.org>.
Github user sandhyasun commented on a diff in the pull request:
https://github.com/apache/incubator-trafodion/pull/175#discussion_r44991733
--- Diff: core/sql/generator/GenPreCode.cpp ---
@@ -4934,8 +4934,9 @@ RelExpr * HbaseDelete::preCodeGen(Generator * generator,
else
if (isUnique)
{
- // do not cancel unique queries.
- generator->setMayNotCancel(TRUE);
+ if (!generator->oltOptInfo()->multipleRowsReturned())
+ // do not cancel unique queries.
+ generator->setMayNotCancel(TRUE);
--- End diff --
Done updating the comment. Also added a similar check to HbaseUpdate . Hbase Access already had the check in place and added just a comment. I did not find any other place that needed this check.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---