You are viewing a plain text version of this content. The canonical link for it is here.

Posted to dev@stratos.apache.org by Vishanth Balasubramaniam <vi...@wso2.com> on 2015/04/27 11:44:19 UTC

Adding properties to add payload parameters in network partition

Hi Devs,

I worked on adding properties (to add payload parameters) to network
partitions. This functionality will be needed for passing network partition
specific parameters to the instances. For example: Puppet Master
information per network partition.

Please review and merge the PR [1].

[1] - https://github.com/apache/stratos/pull/289

Regards,
Vishanth

-- 
*Vishanth Balasubramaniam*
Software Engineer
WSO2 Inc.; http://wso2.com
lean.enterprise.middleware

mobile: *+94771737718*
about me: *http://about.me/vishanth <http://about.me/vishanth>*

Re: Adding properties to add payload parameters in network partition

Posted by Vishanth Balasubramaniam <vi...@wso2.com>.

Thanks Anuruddha for the notes. I have made those minor corrections and
committed to the PR.


On Mon, Apr 27, 2015 at 5:32 PM, Anuruddha Liyanarachchi <
anuruddhal@wso2.com> wrote:

> Hi All,
>
> Please find the notes from the code review.
>
> *ObjectConverter.java*
>
>    - Add brackets to if statements with two conditions.
>
>
> *CloudControllerServiceImpl.java*
>
>    - Reuse the constant PAYLOAD_PARAMETER declared in the other
>    ApplicationUtils class
>    - Remove the commented code segments.
>
>
> On Mon, Apr 27, 2015 at 4:51 PM, Imesh Gunaratne <im...@apache.org> wrote:
>
>> Thanks Vishanth! Will have a code review session for this and merge the
>> PR.
>>
>> Thanks
>>
>> On Mon, Apr 27, 2015 at 3:14 PM, Vishanth Balasubramaniam <
>> vishanthb@wso2.com> wrote:
>>
>>> Hi Devs,
>>>
>>> I worked on adding properties (to add payload parameters) to network
>>> partitions. This functionality will be needed for passing network partition
>>> specific parameters to the instances. For example: Puppet Master
>>> information per network partition.
>>>
>>> Please review and merge the PR [1].
>>>
>>> [1] - https://github.com/apache/stratos/pull/289
>>>
>>> Regards,
>>> Vishanth
>>>
>>> --
>>> *Vishanth Balasubramaniam*
>>> Software Engineer
>>> WSO2 Inc.; http://wso2.com
>>> lean.enterprise.middleware
>>>
>>> mobile: *+94771737718*
>>> about me: *http://about.me/vishanth <http://about.me/vishanth>*
>>>
>>>
>>
>>
>> --
>> Imesh Gunaratne
>>
>> Senior Technical Lead, WSO2
>> Committer & PMC Member, Apache Stratos
>>
>
>
>
> --
> *Thanks and Regards,*
> Anuruddha Lanka Liyanarachchi
> Software Engineer - WSO2
> Mobile : +94 (0) 712762611
> Tel      : +94 112 145 345
> a <th...@wso2.com>nuruddhal@wso2.com
>



-- 
*Vishanth Balasubramaniam*
Software Engineer
WSO2 Inc.; http://wso2.com
lean.enterprise.middleware

mobile: *+94771737718*
about me: *http://about.me/vishanth <http://about.me/vishanth>*

Re: Adding properties to add payload parameters in network partition

Posted by Anuruddha Liyanarachchi <an...@wso2.com>.

Hi All,

Please find the notes from the code review.

*ObjectConverter.java*

   - Add brackets to if statements with two conditions.


*CloudControllerServiceImpl.java*

   - Reuse the constant PAYLOAD_PARAMETER declared in the other
   ApplicationUtils class
   - Remove the commented code segments.


On Mon, Apr 27, 2015 at 4:51 PM, Imesh Gunaratne <im...@apache.org> wrote:

> Thanks Vishanth! Will have a code review session for this and merge the PR.
>
> Thanks
>
> On Mon, Apr 27, 2015 at 3:14 PM, Vishanth Balasubramaniam <
> vishanthb@wso2.com> wrote:
>
>> Hi Devs,
>>
>> I worked on adding properties (to add payload parameters) to network
>> partitions. This functionality will be needed for passing network partition
>> specific parameters to the instances. For example: Puppet Master
>> information per network partition.
>>
>> Please review and merge the PR [1].
>>
>> [1] - https://github.com/apache/stratos/pull/289
>>
>> Regards,
>> Vishanth
>>
>> --
>> *Vishanth Balasubramaniam*
>> Software Engineer
>> WSO2 Inc.; http://wso2.com
>> lean.enterprise.middleware
>>
>> mobile: *+94771737718*
>> about me: *http://about.me/vishanth <http://about.me/vishanth>*
>>
>>
>
>
> --
> Imesh Gunaratne
>
> Senior Technical Lead, WSO2
> Committer & PMC Member, Apache Stratos
>



-- 
*Thanks and Regards,*
Anuruddha Lanka Liyanarachchi
Software Engineer - WSO2
Mobile : +94 (0) 712762611
Tel      : +94 112 145 345
a <th...@wso2.com>nuruddhal@wso2.com

Re: Adding properties to add payload parameters in network partition

Posted by Imesh Gunaratne <im...@apache.org>.

Thanks Vishanth! Will have a code review session for this and merge the PR.

Thanks

On Mon, Apr 27, 2015 at 3:14 PM, Vishanth Balasubramaniam <
vishanthb@wso2.com> wrote:

> Hi Devs,
>
> I worked on adding properties (to add payload parameters) to network
> partitions. This functionality will be needed for passing network partition
> specific parameters to the instances. For example: Puppet Master
> information per network partition.
>
> Please review and merge the PR [1].
>
> [1] - https://github.com/apache/stratos/pull/289
>
> Regards,
> Vishanth
>
> --
> *Vishanth Balasubramaniam*
> Software Engineer
> WSO2 Inc.; http://wso2.com
> lean.enterprise.middleware
>
> mobile: *+94771737718*
> about me: *http://about.me/vishanth <http://about.me/vishanth>*
>
>


-- 
Imesh Gunaratne

Senior Technical Lead, WSO2
Committer & PMC Member, Apache Stratos