[GitHub] [pulsar-helm-chart] lhotari opened a new pull request #239: Revert "Upgrade cert-manager to 1.5.4 (#204)"

[GitBox <gi...@apache.org>]

lhotari opened a new pull request #239:
URL: https://github.com/apache/pulsar-helm-chart/pull/239


   This reverts commit 40a4d50923bd93c960a4ef940930177ca80cb77e.
   
   Supporting `cert-manager.io/v1` api version requires changes made in #233 or #238. In addition, the change should be made in a way that it is backwards compatible.
   


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: dev-unsubscribe@pulsar.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

[GitHub] [pulsar-helm-chart] toneill818 commented on pull request #239: Revert "Upgrade cert-manager to 1.5.4 (#204)"

[GitBox <gi...@apache.org>]

toneill818 commented on pull request #239:
URL: https://github.com/apache/pulsar-helm-chart/pull/239#issuecomment-1054553884


   @lhotari Would you be interested in having cert-manager installed as a dependency if enabled, or kept outside this chart? If we require it as a dependency we can use the following to get the version (we will need to loop through in case more dependencies are added in the future).
   ```
   {{- $certManger := index .Chart.Dependencies 0 -}}
   {{ $certManger.Version }}
   ```
   Then we could use the [semver](http://masterminds.github.io/sprig/semver.html) function to get more information about the release and edit the TLS to be backwards compatible. 
   `{{- if semverCompare "^1.5.0"  $certManger.Version -}}`


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: dev-unsubscribe@pulsar.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org