You are viewing a plain text version of this content. The canonical link for it is here.
Posted to github@arrow.apache.org by "Weijun-H (via GitHub)" <gi...@apache.org> on 2023/03/27 17:05:53 UTC
[GitHub] [arrow-rs] Weijun-H opened a new pull request, #3961: feat: cast between `Binary`/`LargeBinary` and `FixedSizeBinary`
Weijun-H opened a new pull request, #3961:
URL: https://github.com/apache/arrow-rs/pull/3961
# Which issue does this PR close?
<!--
We generally require a GitHub issue to be filed for all bug fixes and enhancements and this helps us generate change logs for our releases. You can link an issue to this PR using the GitHub syntax. For example `Closes #123` indicates that this PR will close issue #123.
-->
Closes #3826
# Rationale for this change
<!--
Why are you proposing this change? If this is already explained clearly in the issue then this section is not needed.
Explaining clearly why changes are proposed helps reviewers understand your changes and offer better suggestions for fixes.
-->
# What changes are included in this PR?
<!--
There is no need to duplicate the description in the issue here but it is sometimes worth providing a summary of the individual changes in this PR.
-->
# Are there any user-facing changes?
<!--
If there are user-facing changes then we may require documentation to be updated before approving the PR.
-->
<!---
If there are any breaking changes to public APIs, please add the `breaking change` label.
-->
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: github-unsubscribe@arrow.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [arrow-rs] tustvold commented on a diff in pull request #3961: feat: cast between `Binary`/`LargeBinary` and `FixedSizeBinary`
Posted by "tustvold (via GitHub)" <gi...@apache.org>.
tustvold commented on code in PR #3961:
URL: https://github.com/apache/arrow-rs/pull/3961#discussion_r1150824930
##########
arrow-cast/src/cast.rs:
##########
@@ -3390,6 +3405,67 @@ fn cast_binary_to_string<O: OffsetSizeTrait>(
}
}
+/// Helper function to cast from one `BinaryArray` or 'LargeBinaryArray' to 'FixedSizeBinaryArray'.
+fn cast_binary_to_fixed_size_binary<O: OffsetSizeTrait>(
+ array: &dyn Array,
+ byte_width: i32,
+) -> Result<ArrayRef, ArrowError> {
+ let array = array
+ .as_any()
+ .downcast_ref::<GenericBinaryArray<O>>()
+ .unwrap();
+
+ let mut builder = FixedSizeBinaryBuilder::with_capacity(array.len(), byte_width);
+
+ for i in 0..array.len() {
+ if array.is_null(i) {
+ builder.append_null();
+ } else {
+ builder.append_value(array.value(i))?;
Review Comment:
I think this should handle `CastOptions::safe` and insert nulls instead of erroring if `safe = true`
##########
arrow-cast/src/cast.rs:
##########
@@ -3390,6 +3405,67 @@ fn cast_binary_to_string<O: OffsetSizeTrait>(
}
}
+/// Helper function to cast from one `BinaryArray` or 'LargeBinaryArray' to 'FixedSizeBinaryArray'.
+fn cast_binary_to_fixed_size_binary<O: OffsetSizeTrait>(
+ array: &dyn Array,
+ byte_width: i32,
+) -> Result<ArrayRef, ArrowError> {
+ let array = array
+ .as_any()
+ .downcast_ref::<GenericBinaryArray<O>>()
+ .unwrap();
Review Comment:
```suggestion
let array = array.as_binary::<O>();
```
##########
arrow-cast/src/cast.rs:
##########
@@ -3390,6 +3405,67 @@ fn cast_binary_to_string<O: OffsetSizeTrait>(
}
}
+/// Helper function to cast from one `BinaryArray` or 'LargeBinaryArray' to 'FixedSizeBinaryArray'.
+fn cast_binary_to_fixed_size_binary<O: OffsetSizeTrait>(
+ array: &dyn Array,
+ byte_width: i32,
+) -> Result<ArrayRef, ArrowError> {
+ let array = array
+ .as_any()
+ .downcast_ref::<GenericBinaryArray<O>>()
+ .unwrap();
+
+ let mut builder = FixedSizeBinaryBuilder::with_capacity(array.len(), byte_width);
+
+ for i in 0..array.len() {
+ if array.is_null(i) {
+ builder.append_null();
+ } else {
+ builder.append_value(array.value(i))?;
+ }
+ }
+
+ Ok(Arc::new(builder.finish()))
+}
+
+/// Helper function to cast from 'FixedSizeBinaryArray' to one `BinaryArray` or 'LargeBinaryArray'.
+/// If the target one is too large for the source array it will return an Error.
+fn cast_fixed_size_binary_to_binary<O: OffsetSizeTrait>(
+ array: &dyn Array,
+ to_type: &DataType,
+ byte_width: i32,
+) -> Result<ArrayRef, ArrowError> {
+ let array = array
+ .as_any()
+ .downcast_ref::<FixedSizeBinaryArray>()
+ .unwrap();
+
+ let offsets: i128 = byte_width as i128 * array.len() as i128;
+
+ let is_binary = matches!(to_type, DataType::Binary);
Review Comment:
Could we change this to match on `GenericBinaryType<O>::DATA_TYPE` instead
##########
arrow-cast/src/cast.rs:
##########
@@ -5295,6 +5371,72 @@ mod tests {
);
}
+ #[test]
+ fn test_cast_binary_to_fixed_size_binary() {
+ let bytes_1 = "Hiiii".as_bytes();
+ let bytes_2 = "Hello".as_bytes();
+
+ let binary_data = vec![Some(bytes_1), Some(bytes_2), None];
+ let a1 = Arc::new(BinaryArray::from(binary_data.clone())) as ArrayRef;
+ let a2 = Arc::new(LargeBinaryArray::from(binary_data)) as ArrayRef;
+
+ let array_ref = cast(&a1, &DataType::FixedSizeBinary(5)).unwrap();
+ let down_cast = array_ref
+ .as_any()
+ .downcast_ref::<FixedSizeBinaryArray>()
+ .unwrap();
+ assert_eq!(bytes_1, down_cast.value(0));
+ assert_eq!(bytes_2, down_cast.value(1));
+ assert!(down_cast.is_null(2));
+
+ let array_ref = cast(&a2, &DataType::FixedSizeBinary(5)).unwrap();
+ let down_cast = array_ref
+ .as_any()
+ .downcast_ref::<FixedSizeBinaryArray>()
+ .unwrap();
+ assert_eq!(bytes_1, down_cast.value(0));
+ assert_eq!(bytes_2, down_cast.value(1));
+ assert!(down_cast.is_null(2));
+
+ // test error cases when the length of binary are not same
+ let bytes_1 = "Hi".as_bytes();
+ let bytes_2 = "Hello".as_bytes();
+
+ let binary_data = vec![Some(bytes_1), Some(bytes_2), None];
+ let a1 = Arc::new(BinaryArray::from(binary_data.clone())) as ArrayRef;
+ let a2 = Arc::new(LargeBinaryArray::from(binary_data)) as ArrayRef;
+
+ let array_ref = cast(&a1, &DataType::FixedSizeBinary(5));
+ assert!(array_ref.is_err());
+
+ let array_ref = cast(&a2, &DataType::FixedSizeBinary(5));
+ assert!(array_ref.is_err());
+ }
+
+ #[test]
+ fn test_fixed_size_binary_to_binary() {
+ let bytes_1 = "Hiiii".as_bytes();
+ let bytes_2 = "Hello".as_bytes();
+
+ let binary_data = vec![Some(bytes_1), Some(bytes_2), None];
+ let a1 = Arc::new(FixedSizeBinaryArray::from(binary_data.clone())) as ArrayRef;
+
+ let array_ref = cast(&a1, &DataType::Binary).unwrap();
+ let down_cast = array_ref.as_any().downcast_ref::<BinaryArray>().unwrap();
Review Comment:
```suggestion
let down_cast = array_ref.as_binary::<i32>();
```
##########
arrow-cast/src/cast.rs:
##########
@@ -5295,6 +5371,72 @@ mod tests {
);
}
+ #[test]
+ fn test_cast_binary_to_fixed_size_binary() {
+ let bytes_1 = "Hiiii".as_bytes();
+ let bytes_2 = "Hello".as_bytes();
+
+ let binary_data = vec![Some(bytes_1), Some(bytes_2), None];
+ let a1 = Arc::new(BinaryArray::from(binary_data.clone())) as ArrayRef;
+ let a2 = Arc::new(LargeBinaryArray::from(binary_data)) as ArrayRef;
+
+ let array_ref = cast(&a1, &DataType::FixedSizeBinary(5)).unwrap();
+ let down_cast = array_ref
+ .as_any()
+ .downcast_ref::<FixedSizeBinaryArray>()
+ .unwrap();
+ assert_eq!(bytes_1, down_cast.value(0));
+ assert_eq!(bytes_2, down_cast.value(1));
+ assert!(down_cast.is_null(2));
+
+ let array_ref = cast(&a2, &DataType::FixedSizeBinary(5)).unwrap();
+ let down_cast = array_ref
+ .as_any()
+ .downcast_ref::<FixedSizeBinaryArray>()
+ .unwrap();
+ assert_eq!(bytes_1, down_cast.value(0));
+ assert_eq!(bytes_2, down_cast.value(1));
+ assert!(down_cast.is_null(2));
+
+ // test error cases when the length of binary are not same
+ let bytes_1 = "Hi".as_bytes();
+ let bytes_2 = "Hello".as_bytes();
+
+ let binary_data = vec![Some(bytes_1), Some(bytes_2), None];
+ let a1 = Arc::new(BinaryArray::from(binary_data.clone())) as ArrayRef;
+ let a2 = Arc::new(LargeBinaryArray::from(binary_data)) as ArrayRef;
+
+ let array_ref = cast(&a1, &DataType::FixedSizeBinary(5));
+ assert!(array_ref.is_err());
+
+ let array_ref = cast(&a2, &DataType::FixedSizeBinary(5));
+ assert!(array_ref.is_err());
+ }
+
+ #[test]
+ fn test_fixed_size_binary_to_binary() {
+ let bytes_1 = "Hiiii".as_bytes();
+ let bytes_2 = "Hello".as_bytes();
+
+ let binary_data = vec![Some(bytes_1), Some(bytes_2), None];
+ let a1 = Arc::new(FixedSizeBinaryArray::from(binary_data.clone())) as ArrayRef;
+
+ let array_ref = cast(&a1, &DataType::Binary).unwrap();
+ let down_cast = array_ref.as_any().downcast_ref::<BinaryArray>().unwrap();
+ assert_eq!(bytes_1, down_cast.value(0));
+ assert_eq!(bytes_2, down_cast.value(1));
+ assert!(down_cast.is_null(2));
+
+ let array_ref = cast(&a1, &DataType::LargeBinary).unwrap();
+ let down_cast = array_ref
+ .as_any()
+ .downcast_ref::<LargeBinaryArray>()
+ .unwrap();
Review Comment:
```suggestion
let down_cast = array_ref.as_binary::<i64>();
```
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: github-unsubscribe@arrow.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [arrow-rs] viirya commented on a diff in pull request #3961: feat: cast between `Binary`/`LargeBinary` and `FixedSizeBinary`
Posted by "viirya (via GitHub)" <gi...@apache.org>.
viirya commented on code in PR #3961:
URL: https://github.com/apache/arrow-rs/pull/3961#discussion_r1150847645
##########
arrow-cast/src/cast.rs:
##########
@@ -3390,6 +3405,67 @@ fn cast_binary_to_string<O: OffsetSizeTrait>(
}
}
+/// Helper function to cast from one `BinaryArray` or 'LargeBinaryArray' to 'FixedSizeBinaryArray'.
+fn cast_binary_to_fixed_size_binary<O: OffsetSizeTrait>(
+ array: &dyn Array,
+ byte_width: i32,
+) -> Result<ArrayRef, ArrowError> {
+ let array = array
+ .as_any()
+ .downcast_ref::<GenericBinaryArray<O>>()
+ .unwrap();
+
+ let mut builder = FixedSizeBinaryBuilder::with_capacity(array.len(), byte_width);
+
+ for i in 0..array.len() {
+ if array.is_null(i) {
+ builder.append_null();
+ } else {
+ builder.append_value(array.value(i))?;
+ }
+ }
+
+ Ok(Arc::new(builder.finish()))
+}
+
+/// Helper function to cast from 'FixedSizeBinaryArray' to one `BinaryArray` or 'LargeBinaryArray'.
+/// If the target one is too large for the source array it will return an Error.
+fn cast_fixed_size_binary_to_binary<O: OffsetSizeTrait>(
+ array: &dyn Array,
+ to_type: &DataType,
+ byte_width: i32,
+) -> Result<ArrayRef, ArrowError> {
+ let array = array
+ .as_any()
+ .downcast_ref::<FixedSizeBinaryArray>()
+ .unwrap();
+
+ let offsets: i128 = byte_width as i128 * array.len() as i128;
+
+ let is_binary = matches!(to_type, DataType::Binary);
+ if is_binary && offsets > i32::MAX as i128 {
+ return Err(ArrowError::ComputeError(
+ "Cast from FixedSizeBinary to Binary would overflow".to_string(),
+ ));
+ } else if !is_binary && offsets > i64::MAX as i128 {
+ return Err(ArrowError::ComputeError(
+ "Cast from FixedSizeBinary to LargeBinary would overflow".to_string(),
+ ));
Review Comment:
The error message can be more specific. E.g., Cannot cast the FixedSizeBinary to Binary because exceeding maximum offset of Binary.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: github-unsubscribe@arrow.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [arrow-rs] viirya commented on a diff in pull request #3961: feat: cast between `Binary`/`LargeBinary` and `FixedSizeBinary`
Posted by "viirya (via GitHub)" <gi...@apache.org>.
viirya commented on code in PR #3961:
URL: https://github.com/apache/arrow-rs/pull/3961#discussion_r1149575987
##########
arrow-cast/src/cast.rs:
##########
@@ -3390,6 +3405,63 @@ fn cast_binary_to_string<O: OffsetSizeTrait>(
}
}
+/// Helper function to cast from one `BinaryArray` or 'LargeBinaryArray' to 'FixedSizeBinaryArray'.
+fn cast_binary_to_fixed_size_binary<O: OffsetSizeTrait>(
+ array: &dyn Array,
+ byte_width: i32,
+) -> Result<ArrayRef, ArrowError> {
+ let array = array
+ .as_any()
+ .downcast_ref::<GenericBinaryArray<O>>()
+ .unwrap();
+
+ let mut builder = FixedSizeBinaryBuilder::with_capacity(array.len(), byte_width);
+
+ for i in 0..array.len() {
+ if array.is_null(i) {
+ builder.append_null();
+ } else {
+ builder.append_value(array.value(i))?;
+ }
+ }
+
+ Ok(Arc::new(builder.finish()))
+}
+
+/// Helper function to cast from 'FixedSizeBinaryArray' to one `BinaryArray` or 'LargeBinaryArray'.
+/// If the target one is too large for the source array it will return an Error.
+fn cast_fixed_size_binary_to_binary<O: OffsetSizeTrait>(
+ array: &dyn Array,
+ to_type: &DataType,
+ byte_width: i32,
+) -> Result<ArrayRef, ArrowError> {
+ let array = array
+ .as_any()
+ .downcast_ref::<FixedSizeBinaryArray>()
+ .unwrap();
+
+ let offsets: i64 = byte_width as i64 * array.len() as i64;
+
+ let is_binary = matches!(to_type, DataType::Binary);
+ if is_binary && offsets > i32::MAX as i64 {
+ return Err(ArrowError::ComputeError(
+ "Cast from FixedSizeBinary to Binary would overflow".to_string(),
+ ));
+ }
Review Comment:
Isn't this also used to `LargeBinaryArray`?
##########
arrow-cast/src/cast.rs:
##########
@@ -3390,6 +3405,63 @@ fn cast_binary_to_string<O: OffsetSizeTrait>(
}
}
+/// Helper function to cast from one `BinaryArray` or 'LargeBinaryArray' to 'FixedSizeBinaryArray'.
+fn cast_binary_to_fixed_size_binary<O: OffsetSizeTrait>(
+ array: &dyn Array,
+ byte_width: i32,
+) -> Result<ArrayRef, ArrowError> {
+ let array = array
+ .as_any()
+ .downcast_ref::<GenericBinaryArray<O>>()
+ .unwrap();
+
+ let mut builder = FixedSizeBinaryBuilder::with_capacity(array.len(), byte_width);
+
+ for i in 0..array.len() {
+ if array.is_null(i) {
+ builder.append_null();
+ } else {
+ builder.append_value(array.value(i))?;
+ }
+ }
+
+ Ok(Arc::new(builder.finish()))
+}
+
+/// Helper function to cast from 'FixedSizeBinaryArray' to one `BinaryArray` or 'LargeBinaryArray'.
+/// If the target one is too large for the source array it will return an Error.
+fn cast_fixed_size_binary_to_binary<O: OffsetSizeTrait>(
+ array: &dyn Array,
+ to_type: &DataType,
Review Comment:
`to_type` looks redundant as it is known `GenericBinaryType<O>`.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: github-unsubscribe@arrow.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [arrow-rs] tustvold merged pull request #3961: feat: cast between `Binary`/`LargeBinary` and `FixedSizeBinary`
Posted by "tustvold (via GitHub)" <gi...@apache.org>.
tustvold merged PR #3961:
URL: https://github.com/apache/arrow-rs/pull/3961
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: github-unsubscribe@arrow.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org