You are viewing a plain text version of this content. The canonical link for it is here.
Posted to reviews@toree.apache.org by "pan3793 (via GitHub)" <gi...@apache.org> on 2023/08/20 18:07:20 UTC
[GitHub] [incubator-toree] pan3793 opened a new pull request, #218: [DRAFT] Support Scala 2.13
pan3793 opened a new pull request, #218:
URL: https://github.com/apache/incubator-toree/pull/218
This PR based on #199, and makes the project compatible with both Scala 2.12 and 2.13.
```
sbt ++2.12 clean test
sbt ++2.13 clean test
```
Some changes are dirty, and polishing/splitting is required before merging
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: reviews-unsubscribe@toree.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] [DRAFT] Support Scala 2.13 [incubator-toree]
Posted by "pan3793 (via GitHub)" <gi...@apache.org>.
pan3793 commented on PR #218:
URL: https://github.com/apache/incubator-toree/pull/218#issuecomment-2309970908
@lresende I remember the `coursier` log API changed significantly, and we need to adapt the new API to recover the log display, let me find time these weeks to fix it and finish the scala 2.13 support.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: reviews-unsubscribe@toree.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] [TOREE-556] Support Scala 2.13 [incubator-toree]
Posted by "pan3793 (via GitHub)" <gi...@apache.org>.
pan3793 commented on PR #218:
URL: https://github.com/apache/incubator-toree/pull/218#issuecomment-3370970756
@lresende I have resolved the conflicts
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: reviews-unsubscribe@toree.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] [TOREE-556] Support Scala 2.13 [incubator-toree]
Posted by "lresende (via GitHub)" <gi...@apache.org>.
lresende commented on PR #218:
URL: https://github.com/apache/incubator-toree/pull/218#issuecomment-3377839252
@fangyh20 i am waiting for #229 and will try to make a rc
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: reviews-unsubscribe@toree.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] [TOREE-556] Support Scala 2.13 [incubator-toree]
Posted by "pan3793 (via GitHub)" <gi...@apache.org>.
pan3793 commented on PR #218:
URL: https://github.com/apache/incubator-toree/pull/218#issuecomment-2328897618
@lresende this PR is ready to review now.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: reviews-unsubscribe@toree.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] [TOREE-556] Support Scala 2.13 [incubator-toree]
Posted by "fangyh20 (via GitHub)" <gi...@apache.org>.
fangyh20 commented on PR #218:
URL: https://github.com/apache/incubator-toree/pull/218#issuecomment-3377542380
Thank you for merging this. when would this be available in pypi? Do we support spark4 currently?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: reviews-unsubscribe@toree.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] [DRAFT] Support Scala 2.13 [incubator-toree]
Posted by "pan3793 (via GitHub)" <gi...@apache.org>.
pan3793 commented on code in PR #218:
URL: https://github.com/apache/incubator-toree/pull/218#discussion_r1743710751
##########
macros/project/plugins.sbt:
##########
@@ -16,4 +16,6 @@
*/
resolvers += Resolver.sonatypeRepo("releases")
-addCompilerPlugin("org.scalamacros" % "paradise" % "2.1.0" cross CrossVersion.full)
+if (scalaBinaryVersion.value == "2.12") {
+ addCompilerPlugin("org.scalamacros" % "paradise" % "2.1.1" cross CrossVersion.full)
Review Comment:
https://github.com/scalamacros/paradise
> In Scala 2.13, the plugin's functionality has been included in the compiler directly under the -Ymacro-annotations flag.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: reviews-unsubscribe@toree.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] [TOREE-556] Support Scala 2.13 [incubator-toree]
Posted by "pan3793 (via GitHub)" <gi...@apache.org>.
pan3793 commented on PR #218:
URL: https://github.com/apache/incubator-toree/pull/218#issuecomment-2328930930
also cc @requaos
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: reviews-unsubscribe@toree.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] [TOREE-556] Support Scala 2.13 [incubator-toree]
Posted by "fangyh20 (via GitHub)" <gi...@apache.org>.
fangyh20 commented on PR #218:
URL: https://github.com/apache/incubator-toree/pull/218#issuecomment-3303958048
if we do one release after another, when would be the Spark4 and scala 2.13 available? is there anything that I can help to accelerate the process?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: reviews-unsubscribe@toree.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] [DRAFT] Support Scala 2.13 [incubator-toree]
Posted by "pan3793 (via GitHub)" <gi...@apache.org>.
pan3793 commented on code in PR #218:
URL: https://github.com/apache/incubator-toree/pull/218#discussion_r1743703688
##########
build.sbt:
##########
@@ -43,7 +50,6 @@ ThisBuild / scalacOptions ++= Seq(
"-deprecation",
"-unchecked",
"-feature",
- "-Xfatal-warnings",
Review Comment:
To make the code support both Scala 2.12 and 2.13, we have to use some deprecated Scala API, so this scalac flag must be disabled.
```
object JavaConverters in package collection is deprecated (since 2.13.0): Use `scala.jdk.CollectionConverters` instead
```
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: reviews-unsubscribe@toree.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] [DRAFT] Support Scala 2.13 [incubator-toree]
Posted by "lresende (via GitHub)" <gi...@apache.org>.
lresende commented on PR #218:
URL: https://github.com/apache/incubator-toree/pull/218#issuecomment-2323735208
Thank you for the updates @pan3793 I did not do much testing, but updated my env to spark 3.4.3 + scala 13 and at least it connects and establishes a spark session... will try to spend more time on validation during the week.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: reviews-unsubscribe@toree.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] [TOREE-556] Support Scala 2.13 [incubator-toree]
Posted by "lresende (via GitHub)" <gi...@apache.org>.
lresende commented on PR #218:
URL: https://github.com/apache/incubator-toree/pull/218#issuecomment-3370016348
@pan3793 I was going to test this locally and noticed the conflicts. I have a rebased version locally but if you want to rebase to make sure there are not conflicts, please go ahead otherwise, i can push the changes from local
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: reviews-unsubscribe@toree.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] [DRAFT] Support Scala 2.13 [incubator-toree]
Posted by "lresende (via GitHub)" <gi...@apache.org>.
lresende commented on PR #218:
URL: https://github.com/apache/incubator-toree/pull/218#issuecomment-2309305740
@pan3793 what is the status of this pr?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: reviews-unsubscribe@toree.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] [TOREE-556] Support Scala 2.13 [incubator-toree]
Posted by "fangyh20 (via GitHub)" <gi...@apache.org>.
fangyh20 commented on PR #218:
URL: https://github.com/apache/incubator-toree/pull/218#issuecomment-3299494854
It would be super helpful if we can have this in the latest release as well.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: reviews-unsubscribe@toree.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] [TOREE-556] Support Scala 2.13 [incubator-toree]
Posted by "fangyh20 (via GitHub)" <gi...@apache.org>.
fangyh20 commented on PR #218:
URL: https://github.com/apache/incubator-toree/pull/218#issuecomment-3294061673
hello all, can this be merged? what's pending on this? is there anything I can help w/?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: reviews-unsubscribe@toree.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] [TOREE-556] Support Scala 2.13 [incubator-toree]
Posted by "jjmeyer0 (via GitHub)" <gi...@apache.org>.
jjmeyer0 commented on PR #218:
URL: https://github.com/apache/incubator-toree/pull/218#issuecomment-2805187831
hello all, can this be merged? if there is additional work, is there anything I can help w/?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: reviews-unsubscribe@toree.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] [TOREE-556] Support Scala 2.13 [incubator-toree]
Posted by "pan3793 (via GitHub)" <gi...@apache.org>.
pan3793 commented on PR #218:
URL: https://github.com/apache/incubator-toree/pull/218#issuecomment-3314831195
I have updated the PR to keep Scala 2.12 as the default, @lresende it's up to you to include this in the upcoming 0.6 or defer it to the next release.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: reviews-unsubscribe@toree.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] [TOREE-556] Support Scala 2.13 [incubator-toree]
Posted by "pan3793 (via GitHub)" <gi...@apache.org>.
pan3793 merged PR #218:
URL: https://github.com/apache/incubator-toree/pull/218
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: reviews-unsubscribe@toree.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] [TOREE-556] Support Scala 2.13 [incubator-toree]
Posted by "pan3793 (via GitHub)" <gi...@apache.org>.
pan3793 commented on PR #218:
URL: https://github.com/apache/incubator-toree/pull/218#issuecomment-3379411167
@fangyh20 Spark 4 is not supported yet (I guess we need to make it support Java 17+ first, then try Spark 4.0), PRs are welcome
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: reviews-unsubscribe@toree.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] [TOREE-556] Support Scala 2.13 [incubator-toree]
Posted by "legiondean (via GitHub)" <gi...@apache.org>.
legiondean commented on PR #218:
URL: https://github.com/apache/incubator-toree/pull/218#issuecomment-2550303924
@pan3793, @lresende , @requaos
do we feel comfortable to merge the PR to support 2.13?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: reviews-unsubscribe@toree.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] [TOREE-556] Support Scala 2.13 [incubator-toree]
Posted by "pan3793 (via GitHub)" <gi...@apache.org>.
pan3793 commented on PR #218:
URL: https://github.com/apache/incubator-toree/pull/218#issuecomment-2422420941
kindly ping @lresende ~
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: reviews-unsubscribe@toree.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] [TOREE-556] Support Scala 2.13 [incubator-toree]
Posted by "lresende (via GitHub)" <gi...@apache.org>.
lresende commented on PR #218:
URL: https://github.com/apache/incubator-toree/pull/218#issuecomment-3299575435
My suggestion is to have a last release with 2.12 which supports old spark releases, and in the future, if needed, we can branch from it and provide patches, etc. And then we can focus on Scala 2.13 for future releases. Having said that, it does not mean we can't do one release after another, in a short period of time, mostly to have the support for both scala versions.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: reviews-unsubscribe@toree.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] [TOREE-556] Support Scala 2.13 [incubator-toree]
Posted by "pan3793 (via GitHub)" <gi...@apache.org>.
pan3793 commented on PR #218:
URL: https://github.com/apache/incubator-toree/pull/218#issuecomment-3374853038
CI passed, let me merge this to allow other PRs to have both Scala 2.12 and 2.13 CI coverage.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: reviews-unsubscribe@toree.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] [DRAFT] Support Scala 2.13 [incubator-toree]
Posted by "pan3793 (via GitHub)" <gi...@apache.org>.
pan3793 commented on code in PR #218:
URL: https://github.com/apache/incubator-toree/pull/218#discussion_r1743712607
##########
build.sbt:
##########
@@ -17,13 +17,20 @@
import scala.util.Properties
+lazy val scala212 = "2.12.15"
+lazy val scala213 = "2.13.8"
+lazy val defaultScalaVersion = sys.env.get("SCALA_VERSION") match {
+ case Some("2.12") => scala212
+ case _ => scala213
Review Comment:
I make Scala 2.13 as the default version
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: reviews-unsubscribe@toree.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org