[GitHub] [superset] hughhhh commented on a diff in pull request #22199: feat(ssh_tunnel): APIs for SSH Tunnels

[GitBox <gi...@apache.org>]

hughhhh commented on code in PR #22199:
URL: https://github.com/apache/superset/pull/22199#discussion_r1033852119


##########
superset/databases/schemas.py:
##########
@@ -365,6 +365,26 @@ class Meta:  # pylint: disable=too-few-public-methods
     )
 
 
+class DatabaseSSHTunnel(Schema):
+    id = fields.Integer()
+    database_id = fields.Integer()
+
+    server_address = fields.String()
+    server_port = fields.Integer()
+    username = fields.String()
+
+    # Basic Authentication
+    password = fields.String(required=False)
+
+    # password protected private key authentication
+    private_key = fields.String(required=False)
+    private_key_password = fields.String(required=False)
+
+    # remote binding port
+    bind_host = fields.String()
+    bind_port = fields.Integer()

Review Comment:
   we don't need to add this part to the schema



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org


---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org
For additional commands, e-mail: notifications-help@superset.apache.org