You are viewing a plain text version of this content. The canonical link for it is here.

Posted to notifications@skywalking.apache.org by GitBox <gi...@apache.org> on 2021/07/15 00:33:54 UTC

[GitHub] [skywalking] JaredTan95 edited a comment on pull request #7294: Support envoy cluster manager metrics

JaredTan95 edited a comment on pull request #7294:
URL: https://github.com/apache/skywalking/pull/7294#issuecomment-880298849


   > > In the latest codes, we expect to match the all and metric service as always, so we begin to read identify section.
   > 
   > We had doc for this also if they want to use Envoy without istio https://github.com/apache/skywalking/blob/master/docs/en/setup/envoy/metrics_service_setting.md#configure-envoy-to-send-metrics-to-skywalking-without-istio
   
   thx
   
   > Should envoy/examples be updated?
   
   In this comment, I mean that we should update 
   https://github.com/apache/skywalking/blob/master/docs/en/setup/envoy/metrics_service_setting.md#configure-envoy-to-send-metrics-to-skywalking-without-istio.
   
   As the latest PR codes do not affect native envoy metrics, fine to me. 
   


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: notifications-unsubscribe@skywalking.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org