You are viewing a plain text version of this content. The canonical link for it is here.
Posted to jira@kafka.apache.org by GitBox <gi...@apache.org> on 2022/06/06 21:39:14 UTC

[GitHub] [kafka] hachikuji opened a new pull request, #12258: MINOR: Convert `ReassignPartitionsIntegrationTest` to KRaft

hachikuji opened a new pull request, #12258:
URL: https://github.com/apache/kafka/pull/12258

   Updates relevant tests in `ReassignPartitionsIntegrationTest` for KRaft. We skip the JBOD and AlterPartition upgrade tests.
   
   
   
   ### Committer Checklist (excluded from commit message)
   - [ ] Verify design and implementation 
   - [ ] Verify test coverage and CI build status
   - [ ] Verify documentation (including upgrade notes)
   


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: jira-unsubscribe@kafka.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

[GitHub] [kafka] hachikuji merged pull request #12258: MINOR: Convert `ReassignPartitionsIntegrationTest` to KRaft

Posted by GitBox <gi...@apache.org>.
hachikuji merged PR #12258:
URL: https://github.com/apache/kafka/pull/12258


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: jira-unsubscribe@kafka.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

[GitHub] [kafka] mumrah commented on a diff in pull request #12258: MINOR: Convert `ReassignPartitionsIntegrationTest` to KRaft

Posted by GitBox <gi...@apache.org>.
mumrah commented on code in PR #12258:
URL: https://github.com/apache/kafka/pull/12258#discussion_r890611619


##########
core/src/test/scala/integration/kafka/admin/ReassignPartitionsIntegrationTest.scala:
##########
@@ -582,7 +598,7 @@ class ReassignPartitionsIntegrationTest extends QuorumTestHarness {
       case (brokerId, rack) =>
         val config = TestUtils.createBrokerConfig(
           nodeId = brokerId,
-          zkConnect = zkConnect,
+          zkConnect = zkConnectOrNull,

Review Comment:
   I wonder how hard it would be to convert `createBrokerConfig` to take an Option here instead of a null.



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: jira-unsubscribe@kafka.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

[GitHub] [kafka] hachikuji commented on a diff in pull request #12258: MINOR: Convert `ReassignPartitionsIntegrationTest` to KRaft

Posted by GitBox <gi...@apache.org>.
hachikuji commented on code in PR #12258:
URL: https://github.com/apache/kafka/pull/12258#discussion_r890622191


##########
core/src/test/scala/integration/kafka/admin/ReassignPartitionsIntegrationTest.scala:
##########
@@ -582,7 +598,7 @@ class ReassignPartitionsIntegrationTest extends QuorumTestHarness {
       case (brokerId, rack) =>
         val config = TestUtils.createBrokerConfig(
           nodeId = brokerId,
-          zkConnect = zkConnect,
+          zkConnect = zkConnectOrNull,

Review Comment:
   I was wondering that too. Looks like nearly 200 usages, so probably better to do it separately.



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: jira-unsubscribe@kafka.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org