You are viewing a plain text version of this content. The canonical link for it is here.
Posted to commits@airflow.apache.org by "o-nikolas (via GitHub)" <gi...@apache.org> on 2026/04/21 16:34:52 UTC
[PR] Add team name to task CTX [airflow]
o-nikolas opened a new pull request, #65617:
URL: https://github.com/apache/airflow/pull/65617
To be able to tell the team we're executing a task for on the worker (for logging, metrics, etc) we need to include the team name as part of the context.
<!-- SPDX-License-Identifier: Apache-2.0
https://www.apache.org/licenses/LICENSE-2.0 -->
<!--
Thank you for contributing!
Please provide above a brief description of the changes made in this pull request.
Write a good git commit message following this guide: http://chris.beams.io/posts/git-commit/
Please make sure that your code changes are covered with tests.
And in case of new features or big changes remember to adjust the documentation.
Feel free to ping (in general) for the review if you do not see reaction for a few days
(72 Hours is the minimum reaction time you can expect from volunteers) - we sometimes miss notifications.
In case of an existing issue, reference it using one of the following:
* closes: #ISSUE
* related: #ISSUE
-->
---
##### Was generative AI tooling used to co-author this PR?
<!--
If generative AI tooling has been used in the process of authoring this PR, please
change below checkbox to `[X]` followed by the name of the tool, uncomment the "Generated-by".
-->
- [ ] Yes (please specify the tool below)
<!--
Generated-by: [Tool Name] following [the guidelines](https://github.com/apache/airflow/blob/main/contributing-docs/05_pull_requests.rst#gen-ai-assisted-contributions)
-->
---
* Read the **[Pull Request Guidelines](https://github.com/apache/airflow/blob/main/contributing-docs/05_pull_requests.rst#pull-request-guidelines)** for more information. Note: commit author/co-author name and email in commits become permanently public when merged.
* For fundamental code changes, an Airflow Improvement Proposal ([AIP](https://cwiki.apache.org/confluence/display/AIRFLOW/Airflow+Improvement+Proposals)) is needed.
* When adding dependency, check compliance with the [ASF 3rd Party License Policy](https://www.apache.org/legal/resolved.html#category-x).
* For significant user-facing changes create newsfragment: `{pr_number}.significant.rst`, in [airflow-core/newsfragments](https://github.com/apache/airflow/tree/main/airflow-core/newsfragments). You can add this file in a follow-up commit after the PR is created so you know the PR number.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@airflow.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] Add team name to task CTX [airflow]
Posted by "o-nikolas (via GitHub)" <gi...@apache.org>.
o-nikolas commented on code in PR #65617:
URL: https://github.com/apache/airflow/pull/65617#discussion_r3127199054
##########
uv.lock:
##########
Review Comment:
Huh, interesting, I think people avoiding pushing it is going to mean that it gets out of date and then defeat the whole purpose of it being current on each commit in the git history. I wonder if we need more specific guidance on this. Maybe I'll get in touch with you offline to understand it better
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@airflow.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] Add team name to task CTX [airflow]
Posted by "vincbeck (via GitHub)" <gi...@apache.org>.
vincbeck commented on code in PR #65617:
URL: https://github.com/apache/airflow/pull/65617#discussion_r3124696094
##########
uv.lock:
##########
Review Comment:
I do not have any concerns to include it, but usually you include it if you make some changes in dependencies
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@airflow.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] Add team name to task CTX [airflow]
Posted by "vincbeck (via GitHub)" <gi...@apache.org>.
vincbeck commented on code in PR #65617:
URL: https://github.com/apache/airflow/pull/65617#discussion_r3126264962
##########
uv.lock:
##########
Review Comment:
> Or do you just take care when doing git add to not include it?
Exactly that. Unless I make any modifications to the dependencies, I do not include it.
> Also I guess I assumed the uv.lock wouldn't show a diff if there wasn't some reason for the diff in the first place?
Did you run any `uv sync`? I think that's probably what triggered it. But again, there is nothing wrong including it, I just feel this is not *necessary*. And in case the new dependency creates/brings a bug with it, then your feature will be reverted even though it has nothing to do with the bug
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@airflow.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] Add team name to task CTX [airflow]
Posted by "vincbeck (via GitHub)" <gi...@apache.org>.
vincbeck commented on code in PR #65617:
URL: https://github.com/apache/airflow/pull/65617#discussion_r3119448405
##########
uv.lock:
##########
Review Comment:
I do not think you. need to include it?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@airflow.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] Add team name to task CTX [airflow]
Posted by "o-nikolas (via GitHub)" <gi...@apache.org>.
o-nikolas commented on code in PR #65617:
URL: https://github.com/apache/airflow/pull/65617#discussion_r3126117894
##########
uv.lock:
##########
Review Comment:
I assumed it was the API version/model changes? Also I guess I assumed the uv.lock wouldn't show a diff if there wasn't _some_ reason for the diff in the first place?
What's the guidance if after pre-commit runs there are diffs in the uv.lock? To you just add uv.lock to your personal .gitignore to stop it from getting included in any of your commits? Or do you just take care when doing git add to not include it?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@airflow.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] Add team name to task CTX [airflow]
Posted by "o-nikolas (via GitHub)" <gi...@apache.org>.
o-nikolas merged PR #65617:
URL: https://github.com/apache/airflow/pull/65617
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@airflow.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] Add team name to task CTX [airflow]
Posted by "vincbeck (via GitHub)" <gi...@apache.org>.
vincbeck commented on code in PR #65617:
URL: https://github.com/apache/airflow/pull/65617#discussion_r3126264962
##########
uv.lock:
##########
Review Comment:
> Or do you just take care when doing git add to not include it?
Exactly that. Unless I make any modifications to the dependencies, I do not include it.
> Also I guess I assumed the uv.lock wouldn't show a diff if there wasn't some reason for the diff in the first place?
Did you run any `uv sync`? I think that's probably what triggered it. But again, there is nothing wrong including it, I think feel this is not *necessary*. And in case the new dependency creates/brings a bug with it, then your feature will be reverted even though it has nothing to do with the bug
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@airflow.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] Add team name to task CTX [airflow]
Posted by "o-nikolas (via GitHub)" <gi...@apache.org>.
o-nikolas commented on code in PR #65617:
URL: https://github.com/apache/airflow/pull/65617#discussion_r3120132217
##########
uv.lock:
##########
Review Comment:
Oh interesting, is there some CI that handles this? Looking at `git log -- uv.lock` I see both github-actions and regular PRs updating this. And I recall from the dev list discussion that folks should add it to their PR when there are differences
##########
uv.lock:
##########
Review Comment:
<img width="565" height="372" alt="Image" src="https://github.com/user-attachments/assets/a12c204c-a0e1-4f5c-b3b2-51bb2374406f" />
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@airflow.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org