You are viewing a plain text version of this content. The canonical link for it is here.
Posted to commits@tooling.apache.org by sb...@apache.org on 2026/10/05 18:24:14 UTC
(tooling-trusted-releases) branch sbp updated: Use updated terminology for podling votes
This is an automated email from the ASF dual-hosted git repository.
sbp pushed a commit to branch sbp
in repository https://gitbox.apache.org/repos/asf/tooling-trusted-releases.git
The following commit(s) were added to refs/heads/sbp by this push:
new 77148026 Use updated terminology for podling votes
77148026 is described below
commit 771480261b3259daf9f5a36e8ddfc9e9a6c43265
Author: Sean B. Palmer <se...@miscoranda.com>
AuthorDate: Mon Oct 5 19:23:39 2026 +0100
Use updated terminology for podling votes
---
atr/get/vote.py | 16 ++++++++++------
tests/unit/test_vote_rendering.py | 12 ++++++------
2 files changed, 16 insertions(+), 12 deletions(-)
diff --git a/atr/get/vote.py b/atr/get/vote.py
index daeb0bd1..20dd0ec3 100644
--- a/atr/get/vote.py
+++ b/atr/get/vote.py
@@ -402,15 +402,19 @@ def _render_binding_status_round_one(
page: htm.Block, ppmc_membership: str, is_ppmc_member: bool, is_ipmc_member: bool
) -> str:
if is_ppmc_member:
- ppmc_status = [f"As {ppmc_membership}, your vote ", htpy.strong["counts"], " towards podling approval. "]
+ ppmc_status = [f"As {ppmc_membership}, your vote is ", htpy.strong["PPMC-binding"], " for podling approval. "]
else:
ppmc_status = [
- f"You are not {ppmc_membership}, so your vote ",
- htpy.strong["does not count"],
- " towards podling approval. ",
+ f"You are not {ppmc_membership}, so your vote is ",
+ htpy.strong["non-binding"],
+ " for podling approval. ",
]
if is_ipmc_member:
- ipmc_status = ["As an Incubator PMC member, your vote is ", htpy.strong["binding"], " for Incubator approval."]
+ ipmc_status = [
+ "As an Incubator PMC member, your vote is ",
+ htpy.strong["IPMC-binding"],
+ " for Incubator approval.",
+ ]
else:
ipmc_status = [
"You are not an Incubator PMC member, so your vote is ",
@@ -418,7 +422,7 @@ def _render_binding_status_round_one(
" for Incubator approval.",
]
page.p[ppmc_status, ipmc_status]
- labels = (["IPMC binding"] if is_ipmc_member else []) + (["PPMC vote"] if is_ppmc_member else [])
+ labels = (["IPMC-binding"] if is_ipmc_member else []) + (["PPMC-binding"] if is_ppmc_member else [])
return ", ".join(labels) or "Non-binding"
diff --git a/tests/unit/test_vote_rendering.py b/tests/unit/test_vote_rendering.py
index 48c72d08..e0872ef4 100644
--- a/tests/unit/test_vote_rendering.py
+++ b/tests/unit/test_vote_rendering.py
@@ -564,9 +564,9 @@ async def test_trusted_rendering_without_start_mid_disables_form_but_shows_lates
@pytest.mark.parametrize(
("is_podling", "podling_thread_id", "binding_by_round", "label"),
[
- (True, None, {1: True, 2: True}, "IPMC binding, PPMC vote"),
- (True, None, {1: False, 2: True}, "IPMC binding"),
- (True, None, {1: True, 2: False}, "PPMC vote"),
+ (True, None, {1: True, 2: True}, "IPMC-binding, PPMC-binding"),
+ (True, None, {1: False, 2: True}, "IPMC-binding"),
+ (True, None, {1: True, 2: False}, "PPMC-binding"),
(True, None, {1: False, 2: False}, "Non-binding"),
(True, "thread-abc", {2: True}, "Binding"),
(False, None, {None: False}, "Non-binding"),
@@ -600,9 +600,9 @@ async def test_vote_decision_labels_reflect_membership(
assert f"+1 ({label})" in html
assert f"-1 ({label})" in html
if is_podling and (podling_thread_id is None):
- ppmc_word = "counts" if binding_by_round[1] else "does not count"
- ipmc_word = "binding" if binding_by_round[2] else "non-binding"
- assert f"your vote <strong>{ppmc_word}</strong> towards podling approval." in html
+ ppmc_word = "PPMC-binding" if binding_by_round[1] else "non-binding"
+ ipmc_word = "IPMC-binding" if binding_by_round[2] else "non-binding"
+ assert f"your vote is <strong>{ppmc_word}</strong> for podling approval." in html
assert f"your vote is <strong>{ipmc_word}</strong> for Incubator approval." in html
---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@tooling.apache.org
For additional commands, e-mail: commits-help@tooling.apache.org