You are viewing a plain text version of this content. The canonical link for it is here.

Posted to commits@submarine.apache.org by GitBox <gi...@apache.org> on 2022/07/14 01:03:56 UTC

[GitHub] [submarine] joshvictor1024 commented on pull request #978: SUBMARINE-1292. Submarine-cloud-v3 e2e test

joshvictor1024 commented on PR #978:
URL: https://github.com/apache/submarine/pull/978#issuecomment-1183836245

   > Hi, @joshvictor1024 thank you for your contribution~ Maybe we can change PR title to [SUBMARINE-1292](https://issues.apache.org/jira/browse/SUBMARINE-1292). Add submarine-cloud-v3 e2e test ?
   
   Sorry, forgot about title format. Fixed.
   
   > ```dockerfile
   > # manager is run as non-root user
   > # See submarine-cloud-v3/config/manager/manager.yaml
   > RUN addgroup -g 1000 -S mygroup
   > RUN adduser -u 1000 -S myuser -G mygroup
   > USER myuser
   > ```
   > 
   > I think we can change `mygroup` and `myuser` to `submarine`
   
   Good point, thanks.


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscribe@submarine.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org