You are viewing a plain text version of this content. The canonical link for it is here.
Posted to notifications@ant.apache.org by "Anders Jacobsson (JIRA)" <ji...@apache.org> on 2010/03/10 13:23:29 UTC
[jira] Created: (IVY-1175) ApacheURLLister does not allow
directories not containing a dot
ApacheURLLister does not allow directories not containing a dot
---------------------------------------------------------------
Key: IVY-1175
URL: https://issues.apache.org/jira/browse/IVY-1175
Project: Ivy
Issue Type: Bug
Components: Core
Affects Versions: trunk
Reporter: Anders Jacobsson
Priority: Minor
I need to use a different revision scheme that looks like R1A01, i.e. not the normal scheme x.y.z, for my company internal dependencies. When doing this, I discovered that ApacheURLLister does not handle directories without a dot (.) properly as it filters those out. If it does not find a dot in the directory name, it compares the href with the text but forgets to check for a trailing slash in href.
--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.
[jira] Updated: (IVY-1175) ApacheURLLister does not allow
directories not containing a dot
Posted by "Anders Jacobsson (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/IVY-1175?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]
Anders Jacobsson updated IVY-1175:
----------------------------------
Attachment: artifactory_directory_listing.zip
> ApacheURLLister does not allow directories not containing a dot
> ---------------------------------------------------------------
>
> Key: IVY-1175
> URL: https://issues.apache.org/jira/browse/IVY-1175
> Project: Ivy
> Issue Type: Bug
> Components: Core
> Affects Versions: trunk
> Reporter: Anders Jacobsson
> Priority: Minor
> Attachments: artifactory_directory_listing.zip, patch.diff
>
>
> I need to use a different revision scheme that looks like R1A01, i.e. not the normal scheme x.y.z, for my company internal dependencies. When doing this, I discovered that ApacheURLLister does not handle directories without a dot (.) properly as it filters those out. If it does not find a dot in the directory name, it compares the href with the text but forgets to check for a trailing slash in href.
--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.
[jira] Commented: (IVY-1175) ApacheURLLister does not allow
directories not containing a dot
Posted by "Anders Jacobsson (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/IVY-1175?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=12843959#action_12843959 ]
Anders Jacobsson commented on IVY-1175:
---------------------------------------
I have added a complete HTML dump of a directory listing from Artifactory.
As you can see, Artifactory does not have a trailing slash on directory entries. And when I think of it, perhaps the title of this bug report is somewhat misleading. It is the combination of not having a dot and not having a trailing slash that is the problem.
> ApacheURLLister does not allow directories not containing a dot
> ---------------------------------------------------------------
>
> Key: IVY-1175
> URL: https://issues.apache.org/jira/browse/IVY-1175
> Project: Ivy
> Issue Type: Bug
> Components: Core
> Affects Versions: trunk
> Reporter: Anders Jacobsson
> Priority: Minor
> Attachments: artifactory_directory_listing.zip, patch.diff
>
>
> I need to use a different revision scheme that looks like R1A01, i.e. not the normal scheme x.y.z, for my company internal dependencies. When doing this, I discovered that ApacheURLLister does not handle directories without a dot (.) properly as it filters those out. If it does not find a dot in the directory name, it compares the href with the text but forgets to check for a trailing slash in href.
--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.
[jira] Commented: (IVY-1175) ApacheURLLister does not allow
directories not containing a dot
Posted by "Maarten Coene (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/IVY-1175?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=12843786#action_12843786 ]
Maarten Coene commented on IVY-1175:
------------------------------------
I tried to create a junit test for your problem, but I wasn't able to reproduce it.
Could you attach such a html listing that is causing problems?
> ApacheURLLister does not allow directories not containing a dot
> ---------------------------------------------------------------
>
> Key: IVY-1175
> URL: https://issues.apache.org/jira/browse/IVY-1175
> Project: Ivy
> Issue Type: Bug
> Components: Core
> Affects Versions: trunk
> Reporter: Anders Jacobsson
> Priority: Minor
> Attachments: patch.diff
>
>
> I need to use a different revision scheme that looks like R1A01, i.e. not the normal scheme x.y.z, for my company internal dependencies. When doing this, I discovered that ApacheURLLister does not handle directories without a dot (.) properly as it filters those out. If it does not find a dot in the directory name, it compares the href with the text but forgets to check for a trailing slash in href.
--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.
[jira] Commented: (IVY-1175) ApacheURLLister does not allow
directories not containing a dot
Posted by "Anders Jacobsson (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/IVY-1175?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=12845288#action_12845288 ]
Anders Jacobsson commented on IVY-1175:
---------------------------------------
Works perfectly. Thanks for the quick turnaround!
> ApacheURLLister does not allow directories not containing a dot
> ---------------------------------------------------------------
>
> Key: IVY-1175
> URL: https://issues.apache.org/jira/browse/IVY-1175
> Project: Ivy
> Issue Type: Bug
> Components: Core
> Affects Versions: trunk
> Reporter: Anders Jacobsson
> Assignee: Maarten Coene
> Priority: Minor
> Fix For: trunk
>
> Attachments: artifactory_directory_listing.zip, patch.diff
>
>
> I need to use a different revision scheme that looks like R1A01, i.e. not the normal scheme x.y.z, for my company internal dependencies. When doing this, I discovered that ApacheURLLister does not handle directories without a dot (.) properly as it filters those out. If it does not find a dot in the directory name, it compares the href with the text but forgets to check for a trailing slash in href.
--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.
[jira] Updated: (IVY-1175) ApacheURLLister does not allow
directories not containing a dot
Posted by "Anders Jacobsson (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/IVY-1175?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]
Anders Jacobsson updated IVY-1175:
----------------------------------
Attachment: patch.diff
Added patch based on revision 918275
> ApacheURLLister does not allow directories not containing a dot
> ---------------------------------------------------------------
>
> Key: IVY-1175
> URL: https://issues.apache.org/jira/browse/IVY-1175
> Project: Ivy
> Issue Type: Bug
> Components: Core
> Affects Versions: trunk
> Reporter: Anders Jacobsson
> Priority: Minor
> Attachments: patch.diff
>
>
> I need to use a different revision scheme that looks like R1A01, i.e. not the normal scheme x.y.z, for my company internal dependencies. When doing this, I discovered that ApacheURLLister does not handle directories without a dot (.) properly as it filters those out. If it does not find a dot in the directory name, it compares the href with the text but forgets to check for a trailing slash in href.
--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.
[jira] Updated: (IVY-1175) ApacheURLLister does not allow
directories not containing a dot
Posted by "Maarten Coene (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/IVY-1175?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]
Maarten Coene updated IVY-1175:
-------------------------------
Fix Version/s: 2.2.0-RC1
(was: trunk)
> ApacheURLLister does not allow directories not containing a dot
> ---------------------------------------------------------------
>
> Key: IVY-1175
> URL: https://issues.apache.org/jira/browse/IVY-1175
> Project: Ivy
> Issue Type: Bug
> Components: Core
> Affects Versions: trunk
> Reporter: Anders Jacobsson
> Assignee: Maarten Coene
> Priority: Minor
> Fix For: 2.2.0-RC1
>
> Attachments: artifactory_directory_listing.zip, patch.diff
>
>
> I need to use a different revision scheme that looks like R1A01, i.e. not the normal scheme x.y.z, for my company internal dependencies. When doing this, I discovered that ApacheURLLister does not handle directories without a dot (.) properly as it filters those out. If it does not find a dot in the directory name, it compares the href with the text but forgets to check for a trailing slash in href.
--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.
[jira] Resolved: (IVY-1175) ApacheURLLister does not allow
directories not containing a dot
Posted by "Maarten Coene (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/IVY-1175?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]
Maarten Coene resolved IVY-1175.
--------------------------------
Resolution: Fixed
Fix Version/s: trunk
Assignee: Maarten Coene
Patch committed in trunk.
I fixed it a bit differently than the patch you suggested, so please give it a try to check if your problem has been solved.
thanks for the contribution!
Maarten
> ApacheURLLister does not allow directories not containing a dot
> ---------------------------------------------------------------
>
> Key: IVY-1175
> URL: https://issues.apache.org/jira/browse/IVY-1175
> Project: Ivy
> Issue Type: Bug
> Components: Core
> Affects Versions: trunk
> Reporter: Anders Jacobsson
> Assignee: Maarten Coene
> Priority: Minor
> Fix For: trunk
>
> Attachments: artifactory_directory_listing.zip, patch.diff
>
>
> I need to use a different revision scheme that looks like R1A01, i.e. not the normal scheme x.y.z, for my company internal dependencies. When doing this, I discovered that ApacheURLLister does not handle directories without a dot (.) properly as it filters those out. If it does not find a dot in the directory name, it compares the href with the text but forgets to check for a trailing slash in href.
--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.