You are viewing a plain text version of this content. The canonical link for it is here.
Posted to commits@doris.apache.org by "HHoflittlefish777 (via GitHub)" <gi...@apache.org> on 2024/01/30 12:06:09 UTC
[PR] [branch-2.1](merge-on-write) handle create rowset error to avoid null pointer exception [doris]
HHoflittlefish777 opened a new pull request, #30598:
URL: https://github.com/apache/doris/pull/30598
## Proposed changes
#30474
<!--Describe your changes.-->
## Further comments
If this is a relatively large or complex change, kick off the discussion at [dev@doris.apache.org](mailto:dev@doris.apache.org) by explaining why you chose the solution you did and what alternatives you considered, etc...
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org
For additional commands, e-mail: commits-help@doris.apache.org
Re: [PR] [branch-2.1](merge-on-write) handle create rowset error to avoid null pointer exception [doris]
Posted by "HHoflittlefish777 (via GitHub)" <gi...@apache.org>.
HHoflittlefish777 commented on PR #30598:
URL: https://github.com/apache/doris/pull/30598#issuecomment-1916711095
run buildall
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org
For additional commands, e-mail: commits-help@doris.apache.org
Re: [PR] [branch-2.1](merge-on-write) handle create rowset error to avoid null pointer exception [doris]
Posted by "github-actions[bot] (via GitHub)" <gi...@apache.org>.
github-actions[bot] commented on code in PR #30598:
URL: https://github.com/apache/doris/pull/30598#discussion_r1471107096
##########
be/src/olap/rowset/beta_rowset_writer.cpp:
##########
@@ -657,19 +659,20 @@ void BaseBetaRowsetWriter::_build_rowset_meta(std::shared_ptr<RowsetMeta> rowset
}
}
-RowsetSharedPtr BaseBetaRowsetWriter::_build_tmp() {
- std::shared_ptr<RowsetMeta> rowset_meta_ = std::make_shared<RowsetMeta>();
+Status BaseBetaRowsetWriter::_build_tmp(RowsetSharedPtr& rowset_ptr) {
Review Comment:
warning: method '_build_tmp' can be made static [readability-convert-member-functions-to-static]
be/src/olap/rowset/beta_rowset_writer.h:143:
```diff
- Status _build_tmp(RowsetSharedPtr& rowset_ptr);
+ static Status _build_tmp(RowsetSharedPtr& rowset_ptr);
```
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org
For additional commands, e-mail: commits-help@doris.apache.org
Re: [PR] [branch-2.1](merge-on-write) handle create rowset error to avoid null pointer exception [doris]
Posted by "yiguolei (via GitHub)" <gi...@apache.org>.
yiguolei merged PR #30598:
URL: https://github.com/apache/doris/pull/30598
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org
For additional commands, e-mail: commits-help@doris.apache.org