[GitHub] [lucene] gsmiller commented on a change in pull request #25: LUCENE-9385: Add option to skip indexing facet drill down terms

[GitBox <gi...@apache.org>]

gsmiller commented on a change in pull request #25:
URL: https://github.com/apache/lucene/pull/25#discussion_r597964197



##########
File path: lucene/facet/src/java/org/apache/lucene/facet/FacetsConfig.java
##########
@@ -178,6 +190,25 @@ public synchronized void setRequireDimensionDrillDown(String dimName, boolean v)
     ft.requireDimensionDrillDown = v;
   }
 
+  /**
+   * Specify whether drill down functionality as a whole should be disabled. Default to false for
+   * backward compatibility.

Review comment:
       I wonder if calling out "backward compatibility" here might create confusion. It reads like the "new best thing" is to disable drilling down, which really isn't the case. Seems like just defaulting to enabling drill down is a simple enough explanation (hey, that's what most users probably expect right?).
   
   Also, to echo Robert's comment above, I suggest enableDrillDown instead of focusing on "disabling"




-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org



---------------------------------------------------------------------
To unsubscribe, e-mail: issues-unsubscribe@lucene.apache.org
For additional commands, e-mail: issues-help@lucene.apache.org