You are viewing a plain text version of this content. The canonical link for it is here.
Posted to issues@arrow.apache.org by "lidavidm (via GitHub)" <gi...@apache.org> on 2023/05/23 15:45:03 UTC

[GitHub] [arrow] lidavidm opened a new issue, #35725: [FlightRPC][C++] Order of gRPC channel arguments is wrong

lidavidm opened a new issue, #35725:
URL: https://github.com/apache/arrow/issues/35725

   ### Describe the bug, including details regarding any error messages, version, and platform.
   
   ```cpp
       // Allow setting generic gRPC options.
       for (const auto& arg : options.generic_options) {
         if (std::holds_alternative<int>(arg.second)) {
           default_args[arg.first] = std::get<int>(arg.second);
         } else if (std::holds_alternative<std::string>(arg.second)) {
           args.SetString(arg.first, std::get<std::string>(arg.second));
         }
         // Otherwise unimplemented
       }
       for (const auto& pair : default_args) {
         args.SetInt(pair.first, pair.second);
       }
   ```
   
   We should set the defaults _before_ the user-supplied arguments.
   
   ### Component(s)
   
   C++, FlightRPC


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: issues-unsubscribe@arrow.apache.org.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

[GitHub] [arrow] chLynda commented on issue #35725: [FlightRPC][C++] Order of gRPC channel arguments is wrong

Posted by "chLynda (via GitHub)" <gi...@apache.org>.
chLynda commented on issue #35725:
URL: https://github.com/apache/arrow/issues/35725#issuecomment-1572460291

   Hello ,for my first contribution ,i would like work on your project .Can I?


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: github-unsubscribe@arrow.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

[GitHub] [arrow] lidavidm commented on issue #35725: [FlightRPC][C++] Order of gRPC channel arguments is wrong

Posted by "lidavidm (via GitHub)" <gi...@apache.org>.
lidavidm commented on issue #35725:
URL: https://github.com/apache/arrow/issues/35725#issuecomment-1573661707

   @chLynda please feel free, you can look at https://arrow.apache.org/docs/dev/developers/contributing.html to get started.


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: github-unsubscribe@arrow.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

[GitHub] [arrow] perhapsmaple commented on issue #35725: [FlightRPC][C++] Order of gRPC channel arguments is wrong

Posted by "perhapsmaple (via GitHub)" <gi...@apache.org>.
perhapsmaple commented on issue #35725:
URL: https://github.com/apache/arrow/issues/35725#issuecomment-1675843532

   @lidavidm The above code snippet seems to first processes user-supplied options within the loop, overwriting the default options and then sets the arguments. It looks correct in terms of ordering the setting of default arguments and user-supplied options to me. Maybe I'm missing something, if you could explain the desired change, I would be happy to help and contribute. 


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: github-unsubscribe@arrow.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

[GitHub] [arrow] lidavidm commented on issue #35725: [FlightRPC][C++] Order of gRPC channel arguments is wrong

Posted by "lidavidm (via GitHub)" <gi...@apache.org>.
lidavidm commented on issue #35725:
URL: https://github.com/apache/arrow/issues/35725#issuecomment-1676033259

   Hmm, right. I don't remember what the original problem was anymore so let's close it.


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: github-unsubscribe@arrow.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

[GitHub] [arrow] lidavidm closed issue #35725: [FlightRPC][C++] Order of gRPC channel arguments is wrong

Posted by "lidavidm (via GitHub)" <gi...@apache.org>.
lidavidm closed issue #35725: [FlightRPC][C++] Order of gRPC channel arguments is wrong
URL: https://github.com/apache/arrow/issues/35725


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: issues-unsubscribe@arrow.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org