[GitHub] [guacamole-client] mike-jumper commented on a change in pull request #470: GUACAMOLE-124: Add full-screen action

[GitBox <gi...@apache.org>]

mike-jumper commented on a change in pull request #470:
URL: https://github.com/apache/guacamole-client/pull/470#discussion_r464245394



##########
File path: guacamole/src/main/webapp/app/navigation/directives/guacUserMenu.js
##########
@@ -164,6 +191,40 @@ angular.module('navigation').directive('guacUserMenu', [function guacUserMenu()
              */
             $scope.actions = [ LOGOUT_ACTION ];
 
+            // Check if Internet Explorer UserAgent
+            var ua = window.navigator.userAgent;
+            var isIE = (ua.indexOf('MSIE ') > -1) || (ua.indexOf('Trident/') > -1);

Review comment:
       > ... don't show toggle is running Internet explorer as it renders a black screen (known bug, but it's IE..)
   
   I'm wary of browser sniffing like this unless absolutely necessary. @echu2013, can you point to where the bug is documented?




----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org