You are viewing a plain text version of this content. The canonical link for it is here.

Posted to github@beam.apache.org by GitBox <gi...@apache.org> on 2022/09/08 15:38:12 UTC

[GitHub] [beam] ryanthompson591 opened a new issue, #23091: [Feature Request]: Add TF example to python notebook

ryanthompson591 opened a new issue, #23091:
URL: https://github.com/apache/beam/issues/23091

   ### What would you like to happen?
   
   We have example code for how to use runinference with sklearn and pytorch. See:
   
   https://github.com/apache/beam/tree/master/examples/notebooks/beam-ml
   
   Since we support TF through TFX -BSL it would make sense to add a TF example to that notebook.
   
   I also had a discussion with @AnandInguva around perhaps breaking these notebooks up into three separate ones in the future. It's likely developers will only be interested in a single framework so it might make sense to structure them with that in mind.
   
   
   ### Issue Priority
   
   Priority: 2
   
   ### Issue Component
   
   Component: sdk-py-core


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: github-unsubscribe@beam.apache.org.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

[GitHub] [beam] ryanthompson591 commented on issue #23091: [Feature Request]: Add TF example to python notebook

Posted by GitBox <gi...@apache.org>.

ryanthompson591 commented on issue #23091:
URL: https://github.com/apache/beam/issues/23091#issuecomment-1240890879

   .add-labels run-inference


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: github-unsubscribe@beam.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

[GitHub] [beam] damccorm commented on issue #23091: [Feature Request]: Add TF example to python notebook

Posted by GitBox <gi...@apache.org>.

damccorm commented on issue #23091:
URL: https://github.com/apache/beam/issues/23091#issuecomment-1245526992

   > I feel like it would be better to have individual notebook for each framework. This looks too big if we add to a single notebook. Any thoughts?
   
   I agree - I imagine most people new to the transform (or who want to use it for a new purpose) are going to have a specific framework in mind. I would vote we split this out into its own notebook and then follow up to split out sklearn as well.


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: github-unsubscribe@beam.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

[GitHub] [beam] AnandInguva commented on issue #23091: [Feature Request]: Add TF example to python notebook

Posted by GitBox <gi...@apache.org>.

AnandInguva commented on issue #23091:
URL: https://github.com/apache/beam/issues/23091#issuecomment-1240890531

   cc: @rezarokni 


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: github-unsubscribe@beam.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

[GitHub] [beam] damccorm commented on issue #23091: [Feature Request]: Add TF example to python notebook

Posted by GitBox <gi...@apache.org>.

damccorm commented on issue #23091:
URL: https://github.com/apache/beam/issues/23091#issuecomment-1245570571

   One recommendation (either as part of this PR or a separate one): it would be nice to have a very simple top level README describing (1) RunInference very generally/pointing to the docs and (2) what each notebook does (including the spaCy one) so that people who are just getting started know where to go. If if its not convenient for that to make it into this PR, I can also follow up on that separately.


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: github-unsubscribe@beam.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

[GitHub] [beam] ryanthompson591 commented on issue #23091: [Feature Request]: Add TF example to python notebook

Posted by GitBox <gi...@apache.org>.

ryanthompson591 commented on issue #23091:
URL: https://github.com/apache/beam/issues/23091#issuecomment-1245493780

   R: @damccorm 


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: github-unsubscribe@beam.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

[GitHub] [beam] ryanthompson591 commented on issue #23091: [Feature Request]: Add TF example to python notebook

Posted by GitBox <gi...@apache.org>.

ryanthompson591 commented on issue #23091:
URL: https://github.com/apache/beam/issues/23091#issuecomment-1240889799

   .take-issue


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: github-unsubscribe@beam.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

[GitHub] [beam] AnandInguva commented on issue #23091: [Feature Request]: Add TF example to python notebook

Posted by GitBox <gi...@apache.org>.

AnandInguva commented on issue #23091:
URL: https://github.com/apache/beam/issues/23091#issuecomment-1245495247

   I feel like it would be better to have individual notebook for each framework. This looks too big. 


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: github-unsubscribe@beam.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

[GitHub] [beam] rezarokni commented on issue #23091: [Feature Request]: Add TF example to python notebook

Posted by GitBox <gi...@apache.org>.

rezarokni commented on issue #23091:
URL: https://github.com/apache/beam/issues/23091#issuecomment-1245989591

   +1 to creating multiple notebooks 
   +1 to top level README 


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: github-unsubscribe@beam.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

[GitHub] [beam] ryanthompson591 commented on issue #23091: [Feature Request]: Add TF example to python notebook

Posted by GitBox <gi...@apache.org>.

ryanthompson591 commented on issue #23091:
URL: https://github.com/apache/beam/issues/23091#issuecomment-1245551311

   Yeah, after looking at the PR and some of the comments the notebook has gotten bloated. Let me rework the PR.


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: github-unsubscribe@beam.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org