Re: Review Request 73566: RANGER-3389 Swagger UI support for Ranger REST API

[Nitin Galave <ni...@gmail.com>]

-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/73566/#review224062
-----------------------------------------------------------




docs/src/site/resources/index.html
Lines 49 (patched)
<https://reviews.apache.org/r/73566/#comment313030>

    Can you please add closing </script> tag



security-admin/src/main/webapp/templates/common/ProfileBar_tmpl.html
Lines 25 (patched)
<https://reviews.apache.org/r/73566/#comment313031>

    Typo error : API documentation


- Nitin Galave


On Sept. 3, 2021, 10:48 p.m., Steven Ramirez wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/73566/
> -----------------------------------------------------------
> 
> (Updated Sept. 3, 2021, 10:48 p.m.)
> 
> 
> Review request for ranger, Abhay Kulkarni, Ramesh Mani, Sailaja Polavarapu, and Velmurugan Periasamy.
> 
> 
> Bugs: RANGER-3389
>     https://issues.apache.org/jira/browse/RANGER-3389
> 
> 
> Repository: ranger
> 
> 
> Description
> -------
> 
> Under the Docs folder, I have added the distribution files for swagger UI. Along with this I have also modified the profile bar template under security admin to include a link to the swagger UI. THis will now provide interactive documentation for users using the ranger admin UI, where they can view all the REST APIs as well as test them out by making requests from the swagger UI.
> 
> 
> Diffs
> -----
> 
>   distro/src/main/assembly/admin-web.xml 3fc054d7c 
>   docs/src/site/resources/index.html PRE-CREATION 
>   docs/src/site/resources/index.js PRE-CREATION 
>   docs/src/site/resources/swagger-ui-bundle.js PRE-CREATION 
>   docs/src/site/resources/swagger-ui-es-bundle-core.js PRE-CREATION 
>   docs/src/site/resources/swagger-ui-es-bundle.js PRE-CREATION 
>   docs/src/site/resources/swagger-ui-standalone-preset.js PRE-CREATION 
>   docs/src/site/resources/swagger-ui.css PRE-CREATION 
>   docs/src/site/resources/swagger-ui.js PRE-CREATION 
>   enunciate.xml 13b465b55 
>   pom.xml 8d81988d4 
>   security-admin/src/main/webapp/templates/common/ProfileBar_tmpl.html 285d10617 
> 
> 
> Diff: https://reviews.apache.org/r/73566/diff/2/
> 
> 
> Testing
> -------
> 
> - Have ensured that the desired files are built under ranger-admin module
> - Have checked that requests and responses are being recieved and correctly displayed
> - Made sure that get requests do not have a X-XSRF-HEADER but all other requests will have "" as their X-XSRF-HEADER attribute.
> 
> 
> Thanks,
> 
> Steven Ramirez
> 
>