You are viewing a plain text version of this content. The canonical link for it is here.
Posted to dev@eventmesh.apache.org by "nkgotcode (via GitHub)" <gi...@apache.org> on 2026/06/15 18:37:16 UTC
[PR] [ISSUE #5233] Preserve common HTTP JSON payloads (eventmesh)
nkgotcode opened a new pull request, #5258:
URL: https://github.com/apache/eventmesh/pull/5258
Fixes #5233
### Motivation
The HTTP connector common protocol fails when it receives a JSON object body because the request payload is parsed as a Java `String`. A JSON object such as `{"name":"Andy"}` cannot be deserialized that way, so the connector rejects a valid request body.
### Modifications
The common HTTP protocol now preserves the raw request body string before enqueuing the `WebhookRequest`. A regression test starts the Vert.x route through `CommonProtocol`, posts a JSON object, verifies the HTTP 200 response, and checks that the queued request payload is unchanged.
Validation:
```bash
docker run --rm -v "$PWD":/workspace -w /workspace eclipse-temurin:8-jdk ./gradlew :eventmesh-connectors:eventmesh-connector-http:test --tests org.apache.eventmesh.connector.http.source.protocol.impl.CommonProtocolTest --no-daemon --stacktrace
```
```text
BUILD SUCCESSFUL
```
### Documentation
- Does this pull request introduce a new feature? no
- If yes, how is the feature documented? not applicable
- If a feature is not applicable for documentation, explain why? This fixes request payload handling for an existing connector protocol.
- If a feature is not documented yet in this PR, please create a followup issue for adding the documentation
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: dev-unsubscribe@eventmesh.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@eventmesh.apache.org
For additional commands, e-mail: dev-help@eventmesh.apache.org
Re: [PR] [ISSUE #5233] Preserve common HTTP JSON payloads (eventmesh)
Posted by "github-actions[bot] (via GitHub)" <gi...@apache.org>.
github-actions[bot] commented on PR #5258:
URL: https://github.com/apache/eventmesh/pull/5258#issuecomment-5296989931
It has been 60 days since the last activity on this pull request. I am reaching out here to gently remind you that the Apache EventMesh community values every pull request, and please feel free to get in touch with the reviewers at any time. They are available to assist you in advancing the progress of your pull request and offering the latest feedback.
If you encounter any challenges during development, seeking support within the community is encouraged. We sincerely appreciate your contributions to Apache EventMesh.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@eventmesh.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: issues-unsubscribe@eventmesh.apache.org
For additional commands, e-mail: issues-help@eventmesh.apache.org
Re: [PR] [ISSUE #5233] Preserve common HTTP JSON payloads (eventmesh)
Posted by "nkgotcode (via GitHub)" <gi...@apache.org>.
nkgotcode commented on PR #5258:
URL: https://github.com/apache/eventmesh/pull/5258#issuecomment-6137064209
Following up on the fix for #5233. The PR remains mergeable and includes regression tests for preserving common HTTP JSON payloads. There are no outstanding inline review comments, but the only reported check is the greeting workflow. Could a maintainer review the change and approve or trigger the normal validation workflows if needed?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@eventmesh.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: issues-unsubscribe@eventmesh.apache.org
For additional commands, e-mail: issues-help@eventmesh.apache.org