You are viewing a plain text version of this content. The canonical link for it is here.

Posted to reviews@yunikorn.apache.org by "wilfred-s (via GitHub)" <gi...@apache.org> on 2023/05/16 03:32:22 UTC

[GitHub] [yunikorn-core] wilfred-s commented on pull request #547: [YUNIKORN-1719] Improve the performance of Application.sortRequests()

wilfred-s commented on PR #547:
URL: https://github.com/apache/yunikorn-core/pull/547#issuecomment-1548925776

   I see that we also have a small leak for the case that we call removeAsksInternal with an empty string. We remove all requests but we do not reset the sortedRequests to nil (line 516) we should add `sa.sortedRequests = nil` It is a leak that eventually will fix itself but we need to be consistent.


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: reviews-unsubscribe@yunikorn.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org