You are viewing a plain text version of this content. The canonical link for it is here.
Posted to dev@gossip.apache.org by Edward Capriolo <ed...@gmail.com> on 2016/12/30 17:31:07 UTC
[VOTE] Release Gossip (Incubating) version gossip-0.1.1-incubating
I am pleased to be calling this vote for the source release of Apache Gossip
Ancillary artifacts such as poms, jars, wars, ect. can be found here:
https://repository.apache.org/content/repositories/orgapachegossip-1001
The Git commit ID is:
https://github.com/edwardcapriolo/incubator-gossip/commit/74133870410fec45bd6cac39351fcbbe0950de18
Which will be tagged as gossip-0.1.1-incubating
https://git-wip-us.apache.org/repos/asf?p=incubator-rya.git;a=commit;h=66d8b7f060bddeeb7c50cb0918f98ce3b265c564
Checksums of
https://repository.apache.org/content/repositories/orgapachegossip-1001/org/apache/gossip/gossip/0.1.1-incubating/gossip-0.1.1-incubating-source-release.zip.asc
:
SHA1: 53ca6498d0f704fe7931ec23ca81a638a1fd666c
MD5: c27067c47bdeb6133660beda908f679c
Release artifacts are signed with the following key:
http://people.apache.org/~ecapriolo/
http://people.apache.org/~ecapriolo/ecapriolo_asf.asc
KEYS file available here:
https://dist.apache.org/repos/dist/release/incubator/rya/KEYS
The vote will be open for 72 hours. Please download the release candidate
and evaluate the necessary items including checking hashes, signatures,
build from source, and test.
Release this package?
[ ] +1 yes
[ ] +0 no opinion
[ ] -1 Do not release this package because because...
Re: [VOTE] Release Gossip (Incubating) version gossip-0.1.1-incubating
Posted by Gary Dusbabek <gd...@gmail.com>.
+1
On Fri, Dec 30, 2016 at 11:31 AM, Edward Capriolo <ed...@gmail.com>
wrote:
> I am pleased to be calling this vote for the source release of Apache
> Gossip
>
> Ancillary artifacts such as poms, jars, wars, ect. can be found here:
> https://repository.apache.org/content/repositories/orgapachegossip-1001
>
> The Git commit ID is:
> https://github.com/edwardcapriolo/incubator-gossip/commit/
> 74133870410fec45bd6cac39351fcbbe0950de18
>
> Which will be tagged as gossip-0.1.1-incubating
>
> https://git-wip-us.apache.org/repos/asf?p=incubator-rya.git;a=commit;h=
> 66d8b7f060bddeeb7c50cb0918f98ce3b265c564
>
>
> Checksums of
> https://repository.apache.org/content/repositories/
> orgapachegossip-1001/org/apache/gossip/gossip/0.1.1-
> incubating/gossip-0.1.1-incubating-source-release.zip.asc
> :
> SHA1: 53ca6498d0f704fe7931ec23ca81a638a1fd666c
> MD5: c27067c47bdeb6133660beda908f679c
>
> Release artifacts are signed with the following key:
> http://people.apache.org/~ecapriolo/
> http://people.apache.org/~ecapriolo/ecapriolo_asf.asc
>
> KEYS file available here:
> https://dist.apache.org/repos/dist/release/incubator/rya/KEYS
>
> The vote will be open for 72 hours. Please download the release candidate
> and evaluate the necessary items including checking hashes, signatures,
> build from source, and test.
>
>
> Release this package?
> [ ] +1 yes
> [ ] +0 no opinion
> [ ] -1 Do not release this package because because...
>
Re: [VOTE] Release Gossip (Incubating) version gossip-0.1.1-incubating
Posted by Edward Capriolo <ed...@gmail.com>.
On Tue, Jan 3, 2017 at 12:56 AM, Josh Elser <el...@apache.org> wrote:
> Obligatory: sorry, I didn't make the time to look at it today. Thanks,
> Drew, for covering my butt! I will do this first thing in the morning, but
> I wanted to comment on two things before I forget.
>
> Edward Capriolo wrote:
>
>> * The git commit ID is good to see (not just the tag), but linking to
>> your personal github acct is a little out-of-the-normal to me.
>>
>> Yes. I plan on pushing that commit to apache git as the tag once the vote
>> is complete. Normally the maven release WOULD push the tag but we are
>> voting on the tag so I did not want to push it until it is +1ed.
>>
>
> In the shortest way possible: this isn't how this works :)
>
> You *must* push the commit which is being voted on. The thing being voted
> upon must exist in the VCS. It is very normal to avoid pushing a tag that
> would imply a release (e.g. gossip-0.1.1-incubating), and it is common to
> see an "RC" tag pushed instead (e.g. gossip-0.1.1-incubating-rc1). Yes,
> this often requires a little bit of scripting or manual tag/push logic on
> your part. It's pretty common to see a little bash script that encapsulates
> this logic.
>
> I have pushed the tag as
>> https://github.com/apache/incubator-gossip/tree/gossip-0.1.
>> 1-incubating-rc1when
>> the vote is complete I will re-tag as
>> https://github.com/apache/incubator-gossip/tree/gossip-0.1.1-incubating
>>
>> *The manifest at the start of the KEYS file doesn't list you key although
>> the it present at the end of the file.
>>
>> My manifest is after Taylors key (towards the middle of the file)
>>
>> * For the checksums, I'm guessing you copied the wrong filename.
>> I assume you meant those are the checksums for
>> gossip-0.1.1-incubating-source-release.zip as a gpg signature doesn't
>> require
>> a checksum to ensure it was not tampered with
>>
>> The maven process signed every artifact here:
>> https://repository.apache.org/content/repositories/orgapache
>> gossip-1001/org/apache/gossip/gossip/0.1.1-incubating/
>> I have verified these locally.
>>
>> The correct URL to the keys file is here:
>> https://dist.apache.org/repos/dist/release/incubator/gossip/KEYS
>>
>
> Please re-read what I wrote :). I did not state that the checksums or
> signatures were bad/wrong. The URL in your VOTE email to the file which the
> checksums and signatures are for was incorrect/nonsensical.
>
>
You *must* push the commit which is being voted on. The thing being voted
upon must exist in the VCS. It is very normal to avoid pushing a tag that
would imply a release (e.g. gossip-0.1.1-incubating), and it is common to
see an "RC" tag pushed instead (e.g. gossip-0.1.1-incubating-rc1). Yes,
this often requires a little bit of scripting or manual tag/push logic on
your part. It's pretty common to see a little bash script that encapsulates
this logic.
The tag is pushed from last email.
I have pushed the tag as
https://github.com/apache/incubator-gossip/tree/gossip-0.1.1-incubating-rc1
the vote is complete I will re-tag as
https://github.com/apache/incubator-gossip/tree/gossip-0.1.1-incubating
The checksums are verified.
[edward@jackintosh train]$ wget
https://repository.apache.org/content/repositories/orgapachegossip-1001/org/apache/gossip/gossip/0.1.1-incubating/gossip-0.1.1-
[edward@jackintosh train]$ cat
gossip-0.1.1-incubating-source-release.zip.md5
804b942e73a2b82c9b7a2ac6062e9e0d
[edward@jackintosh train]$ md5sum gossip-0.1.1-incubating-source-release.zip
804b942e73a2b82c9b7a2ac6062e9e0d gossip-0.1.1-incubating-source-release.zip
Is there any show stopper open left outside of typos in the vote email that
will be an issue?
Re: [VOTE] Release Gossip (Incubating) version gossip-0.1.1-incubating
Posted by Josh Elser <el...@apache.org>.
Obligatory: sorry, I didn't make the time to look at it today. Thanks,
Drew, for covering my butt! I will do this first thing in the morning,
but I wanted to comment on two things before I forget.
Edward Capriolo wrote:
> * The git commit ID is good to see (not just the tag), but linking to
> your personal github acct is a little out-of-the-normal to me.
>
> Yes. I plan on pushing that commit to apache git as the tag once the vote
> is complete. Normally the maven release WOULD push the tag but we are
> voting on the tag so I did not want to push it until it is +1ed.
In the shortest way possible: this isn't how this works :)
You *must* push the commit which is being voted on. The thing being
voted upon must exist in the VCS. It is very normal to avoid pushing a
tag that would imply a release (e.g. gossip-0.1.1-incubating), and it is
common to see an "RC" tag pushed instead (e.g.
gossip-0.1.1-incubating-rc1). Yes, this often requires a little bit of
scripting or manual tag/push logic on your part. It's pretty common to
see a little bash script that encapsulates this logic.
> I have pushed the tag as
> https://github.com/apache/incubator-gossip/tree/gossip-0.1.1-incubating-rc1when
> the vote is complete I will re-tag as
> https://github.com/apache/incubator-gossip/tree/gossip-0.1.1-incubating
>
> *The manifest at the start of the KEYS file doesn't list you key although
> the it present at the end of the file.
>
> My manifest is after Taylors key (towards the middle of the file)
>
> * For the checksums, I'm guessing you copied the wrong filename.
> I assume you meant those are the checksums for
> gossip-0.1.1-incubating-source-release.zip as a gpg signature doesn't
> require
> a checksum to ensure it was not tampered with
>
> The maven process signed every artifact here:
> https://repository.apache.org/content/repositories/orgapachegossip-1001/org/apache/gossip/gossip/0.1.1-incubating/
> I have verified these locally.
>
> The correct URL to the keys file is here:
> https://dist.apache.org/repos/dist/release/incubator/gossip/KEYS
Please re-read what I wrote :). I did not state that the checksums or
signatures were bad/wrong. The URL in your VOTE email to the file which
the checksums and signatures are for was incorrect/nonsensical.
Re: [VOTE] Release Gossip (Incubating) version gossip-0.1.1-incubating
Posted by Edward Capriolo <ed...@gmail.com>.
* The git commit ID is good to see (not just the tag), but linking to
your personal github acct is a little out-of-the-normal to me.
Yes. I plan on pushing that commit to apache git as the tag once the vote
is complete. Normally the maven release WOULD push the tag but we are
voting on the tag so I did not want to push it until it is +1ed.
I have pushed the tag as
https://github.com/apache/incubator-gossip/tree/gossip-0.1.1-incubating-rc1when
the vote is complete I will re-tag as
https://github.com/apache/incubator-gossip/tree/gossip-0.1.1-incubating
*The manifest at the start of the KEYS file doesn't list you key although
the it present at the end of the file.
My manifest is after Taylors key (towards the middle of the file)
* For the checksums, I'm guessing you copied the wrong filename.
I assume you meant those are the checksums for
gossip-0.1.1-incubating-source-release.zip as a gpg signature doesn't
require
a checksum to ensure it was not tampered with
The maven process signed every artifact here:
https://repository.apache.org/content/repositories/orgapachegossip-1001/org/apache/gossip/gossip/0.1.1-incubating/
I have verified these locally.
The correct URL to the keys file is here:
https://dist.apache.org/repos/dist/release/incubator/gossip/KEYS
On Mon, Jan 2, 2017 at 9:37 AM, Drew Farris <dr...@apache.org> wrote:
> Edward,
>
> Thanks for the release. Generally things looks pretty good. Aside from the
> concerns with the vote e-mail Josh already shared, I can't seem to find the
> commit referenced by commit id 7413387041 anywhere other than the
> edwardcapriolo fork on GitHub. That's the only other showstopper I have
> found.
>
> Here's what I checked:
>
> I found the correct KEYS file at:
> https://dist.apache.org/repos/dist/release/incubator/gossip/KEYS
>
> - Name on release artifacts includes incubating.
> - Verified GPG signatures, MD5's and SHA hashes look good.
> - No unintentional binary artifacts in the source release zip.
> - NOTICE, LICENSE, DISCLAIMER files all look good.
> - All source files have the Apache license header.
> - Can build from the source release.
>
> Some nits:
>
> You may consider GPG signing with an apache.org e-mail address instead of
> a
> personal address.
>
> The manifest at the start of the KEYS file doesn't list you key although
> the it present at the end of the file.
>
> I think it is probably worth calling a second vote with a corrected e-mail
> once Josh has weighed in and the commit is present on Apache's git repo.
>
> Drew
>
> On Mon, Jan 2, 2017 at 12:21 AM Josh Elser <el...@apache.org> wrote:
>
> I'm just getting back from a little vacation. If you can hold off on
> calling the vote strictly after 72hrs, I'll do my best to look at this
> tmrw before it makes its way to the IPMC for a vote.
>
> A couple of remarks on the VOTE email's content:
> * The git commit ID is good to see (not just the tag), but linking to
> your personal github acct is a little out-of-the-normal to me.
> * The URL to the KEYS file and the git-wip-us URL are both wrong.
> * For the checksums, I'm guessing you copied the wrong filename. I
> assume you meant those are the checksums for
> gossip-0.1.1-incubating-source-release.zip as a gpg signature doesn't
> require a checksum to ensure it was not tampered with.
>
> Edward Capriolo wrote:
> > I am pleased to be calling this vote for the source release of Apache
> Gossip
> >
> > Ancillary artifacts such as poms, jars, wars, ect. can be found here:
> > https://repository.apache.org/content/repositories/orgapachegossip-1001
> >
> > The Git commit ID is:
> >
> https://github.com/edwardcapriolo/incubator-gossip/commit/
> 74133870410fec45bd6cac39351fcbbe0950de18
> >
> > Which will be tagged as gossip-0.1.1-incubating
> >
> >
> https://git-wip-us.apache.org/repos/asf?p=incubator-rya.git;a=commit;h=
> 66d8b7f060bddeeb7c50cb0918f98ce3b265c564
> >
> >
> > Checksums of
> >
> https://repository.apache.org/content/repositories/
> orgapachegossip-1001/org/apache/gossip/gossip/0.1.1-
> incubating/gossip-0.1.1-incubating-source-release.zip.asc
> > :
> > SHA1: 53ca6498d0f704fe7931ec23ca81a638a1fd666c
> > MD5: c27067c47bdeb6133660beda908f679c
> >
> > Release artifacts are signed with the following key:
> > http://people.apache.org/~ecapriolo/
> > http://people.apache.org/~ecapriolo/ecapriolo_asf.asc
> >
> > KEYS file available here:
> > https://dist.apache.org/repos/dist/release/incubator/rya/KEYS
> >
> > The vote will be open for 72 hours. Please download the release candidate
> > and evaluate the necessary items including checking hashes, signatures,
> > build from source, and test.
> >
> >
> > Release this package?
> > [ ] +1 yes
> > [ ] +0 no opinion
> > [ ] -1 Do not release this package because because...
> >
>
Re: [VOTE] Release Gossip (Incubating) version gossip-0.1.1-incubating
Posted by Drew Farris <dr...@apache.org>.
Edward,
Thanks for the release. Generally things looks pretty good. Aside from the
concerns with the vote e-mail Josh already shared, I can't seem to find the
commit referenced by commit id 7413387041 anywhere other than the
edwardcapriolo fork on GitHub. That's the only other showstopper I have
found.
Here's what I checked:
I found the correct KEYS file at:
https://dist.apache.org/repos/dist/release/incubator/gossip/KEYS
- Name on release artifacts includes incubating.
- Verified GPG signatures, MD5's and SHA hashes look good.
- No unintentional binary artifacts in the source release zip.
- NOTICE, LICENSE, DISCLAIMER files all look good.
- All source files have the Apache license header.
- Can build from the source release.
Some nits:
You may consider GPG signing with an apache.org e-mail address instead of a
personal address.
The manifest at the start of the KEYS file doesn't list you key although
the it present at the end of the file.
I think it is probably worth calling a second vote with a corrected e-mail
once Josh has weighed in and the commit is present on Apache's git repo.
Drew
On Mon, Jan 2, 2017 at 12:21 AM Josh Elser <el...@apache.org> wrote:
I'm just getting back from a little vacation. If you can hold off on
calling the vote strictly after 72hrs, I'll do my best to look at this
tmrw before it makes its way to the IPMC for a vote.
A couple of remarks on the VOTE email's content:
* The git commit ID is good to see (not just the tag), but linking to
your personal github acct is a little out-of-the-normal to me.
* The URL to the KEYS file and the git-wip-us URL are both wrong.
* For the checksums, I'm guessing you copied the wrong filename. I
assume you meant those are the checksums for
gossip-0.1.1-incubating-source-release.zip as a gpg signature doesn't
require a checksum to ensure it was not tampered with.
Edward Capriolo wrote:
> I am pleased to be calling this vote for the source release of Apache
Gossip
>
> Ancillary artifacts such as poms, jars, wars, ect. can be found here:
> https://repository.apache.org/content/repositories/orgapachegossip-1001
>
> The Git commit ID is:
>
https://github.com/edwardcapriolo/incubator-gossip/commit/74133870410fec45bd6cac39351fcbbe0950de18
>
> Which will be tagged as gossip-0.1.1-incubating
>
>
https://git-wip-us.apache.org/repos/asf?p=incubator-rya.git;a=commit;h=66d8b7f060bddeeb7c50cb0918f98ce3b265c564
>
>
> Checksums of
>
https://repository.apache.org/content/repositories/orgapachegossip-1001/org/apache/gossip/gossip/0.1.1-incubating/gossip-0.1.1-incubating-source-release.zip.asc
> :
> SHA1: 53ca6498d0f704fe7931ec23ca81a638a1fd666c
> MD5: c27067c47bdeb6133660beda908f679c
>
> Release artifacts are signed with the following key:
> http://people.apache.org/~ecapriolo/
> http://people.apache.org/~ecapriolo/ecapriolo_asf.asc
>
> KEYS file available here:
> https://dist.apache.org/repos/dist/release/incubator/rya/KEYS
>
> The vote will be open for 72 hours. Please download the release candidate
> and evaluate the necessary items including checking hashes, signatures,
> build from source, and test.
>
>
> Release this package?
> [ ] +1 yes
> [ ] +0 no opinion
> [ ] -1 Do not release this package because because...
>
Re: [VOTE] Release Gossip (Incubating) version gossip-0.1.1-incubating
Posted by Josh Elser <el...@apache.org>.
I'm just getting back from a little vacation. If you can hold off on
calling the vote strictly after 72hrs, I'll do my best to look at this
tmrw before it makes its way to the IPMC for a vote.
A couple of remarks on the VOTE email's content:
* The git commit ID is good to see (not just the tag), but linking to
your personal github acct is a little out-of-the-normal to me.
* The URL to the KEYS file and the git-wip-us URL are both wrong.
* For the checksums, I'm guessing you copied the wrong filename. I
assume you meant those are the checksums for
gossip-0.1.1-incubating-source-release.zip as a gpg signature doesn't
require a checksum to ensure it was not tampered with.
Edward Capriolo wrote:
> I am pleased to be calling this vote for the source release of Apache Gossip
>
> Ancillary artifacts such as poms, jars, wars, ect. can be found here:
> https://repository.apache.org/content/repositories/orgapachegossip-1001
>
> The Git commit ID is:
> https://github.com/edwardcapriolo/incubator-gossip/commit/74133870410fec45bd6cac39351fcbbe0950de18
>
> Which will be tagged as gossip-0.1.1-incubating
>
> https://git-wip-us.apache.org/repos/asf?p=incubator-rya.git;a=commit;h=66d8b7f060bddeeb7c50cb0918f98ce3b265c564
>
>
> Checksums of
> https://repository.apache.org/content/repositories/orgapachegossip-1001/org/apache/gossip/gossip/0.1.1-incubating/gossip-0.1.1-incubating-source-release.zip.asc
> :
> SHA1: 53ca6498d0f704fe7931ec23ca81a638a1fd666c
> MD5: c27067c47bdeb6133660beda908f679c
>
> Release artifacts are signed with the following key:
> http://people.apache.org/~ecapriolo/
> http://people.apache.org/~ecapriolo/ecapriolo_asf.asc
>
> KEYS file available here:
> https://dist.apache.org/repos/dist/release/incubator/rya/KEYS
>
> The vote will be open for 72 hours. Please download the release candidate
> and evaluate the necessary items including checking hashes, signatures,
> build from source, and test.
>
>
> Release this package?
> [ ] +1 yes
> [ ] +0 no opinion
> [ ] -1 Do not release this package because because...
>
Re: [VOTE] Release Gossip (Incubating) version gossip-0.1.1-incubating
Posted by chandresh pancholi <ch...@gmail.com>.
+1
On Dec 30, 2016 11:01 PM, "Edward Capriolo" <ed...@gmail.com> wrote:
I am pleased to be calling this vote for the source release of Apache Gossip
Ancillary artifacts such as poms, jars, wars, ect. can be found here:
https://repository.apache.org/content/repositories/orgapachegossip-1001
The Git commit ID is:
https://github.com/edwardcapriolo/incubator-gossip/commit/
74133870410fec45bd6cac39351fcbbe0950de18
Which will be tagged as gossip-0.1.1-incubating
https://git-wip-us.apache.org/repos/asf?p=incubator-rya.git;a=commit;h=
66d8b7f060bddeeb7c50cb0918f98ce3b265c564
Checksums of
https://repository.apache.org/content/repositories/orgapachegossip-1001/org/
apache/gossip/gossip/0.1.1-incubating/gossip-0.1.1-
incubating-source-release.zip.asc
:
SHA1: 53ca6498d0f704fe7931ec23ca81a638a1fd666c
MD5: c27067c47bdeb6133660beda908f679c
Release artifacts are signed with the following key:
http://people.apache.org/~ecapriolo/
http://people.apache.org/~ecapriolo/ecapriolo_asf.asc
KEYS file available here:
https://dist.apache.org/repos/dist/release/incubator/rya/KEYS
The vote will be open for 72 hours. Please download the release candidate
and evaluate the necessary items including checking hashes, signatures,
build from source, and test.
Release this package?
[ ] +1 yes
[ ] +0 no opinion
[ ] -1 Do not release this package because because...
Re: [VOTE] Release Gossip (Incubating) version gossip-0.1.1-incubating
Posted by Josh Elser <el...@apache.org>.
That's life.
I promise you that this will continue to happen for your first few
releases. Until there is a regular cadence where all of the podling
members understand and do these checks themselves, things will slip
through the cracks and require a new RC.
I'll add myself as a watcher to the issue you filed.
Edward Capriolo wrote:
> This is a bit frustrating. I have called this vote multiple times now and
> each call finds something new. This dep is used by the bit that reads the
> startup settings from a file. I will have to ticket this because it is more
> than cosmetic.
>
> On Tue, Jan 3, 2017 at 1:07 PM, Josh Elser<el...@apache.org> wrote:
>
>>
>> Edward Capriolo wrote:
>>
>>> On Tue, Jan 3, 2017 at 11:45 AM, Josh Elser<el...@apache.org> wrote:
>>>
>>> -1 due to a dependency on a project with a category-X license [1].
>>>> Gossip is transitively depending on org.json:json via
>>>> jackson-datatype-json-org.
>>>>
>>>> ```
>>>> [INFO] org.apache.gossip:gossip:jar:0.1.1-incubating
>>>> [INFO] +- com.fasterxml.jackson:jackson-datatype-json-org:jar:1.8.0:co
>>>> mpile
>>>> [INFO] | +- org.codehaus.jackson:jackson-mapper-asl:jar:1.8.6:compile
>>>> [INFO] | | \- org.codehaus.jackson:jackson-core-asl:jar:1.8.6:compile
>>>> [INFO] | \- org.json:json:jar:20090211:compile
>>>> ```
>>>>
>>>> org.json:json is licensed with the JSON license which the ASF has
>>>> recently
>>>> moved to category-X [2]. Debian has a list of some alternatives[3] which
>>>> can be used instead. This would need to be resolved before your release.
>>>>
>>>> I know in Calcite we use jackson-databind for JSON serialization of POJOs
>>>> and that doesn't have the dependency on org.json:json. Perhaps this can
>>>> be
>>>> easily resolved switching the jackson dependencies and maybe some API
>>>> calls.
>>>>
>>>> Good:
>>>>
>>>> * xsums/sigs match (for source-release.zip)
>>>> * KEYS looks good
>>>> * Can build from source
>>>> * DISCLAIMER is present
>>>>
>>>> I see that the rc1 tag was pushed, and will assume that the next VOTE
>>>> message will get that right too. Re-stating this one as I can't verify
>>>> that
>>>> presently.
>>>>
>>>> Nit:
>>>>
>>>> * Wrong header in the src/**/log4j.properties files. Update it to match
>>>> the header in the rest of the java files. Fix for next release.
>>>> * Year in NOTICE is now out of date. Fix for next release.
>>>> * Use "Apache Gossip" for the first mention of "Gossip" in the README.md.
>>>> Fix for next release.
>>>> * Add the license text to the README and eclipse template as it's trivial
>>>> to do so for both (xml and md both support "comments"). Fix for next
>>>> release.
>>>> * Tests failed for me (on a `mvn package`). Not a release issue, just a
>>>> quality issue. I would expect that all of the tests would pass, and just
>>>> wanted to mention it.
>>>>
>>>> ```
>>>> Failed tests:
>>>> ShutdownDeadtimeTest.DeadNodesDoNotComeAliveAgain:103
>>>> ComparisonFailure
>>>> expected:<[16]> but was:<[8]>
>>>> StartupSettingsTest.testUsingSettingsFile:69 � Runtime
>>>> java.net.BindException:...
>>>> TenNodeThreeSeedTest.test:44->abc:78 � Runtime
>>>> java.net.BindException:
>>>> Address...
>>>> TenNodeThreeSeedTest.testAgain:49->abc:78 � Runtime
>>>> java.net.BindException: Ad...
>>>> ```
>>>>
>>>> - Josh
>>>>
>>>> [1] https://www.apache.org/legal/resolved#category-x
>>>> [2] https://www.apache.org/legal/resolved#json
>>>> [3] https://wiki.debian.org/qa.debian.org/jsonevil
>>>>
>>>> Edward Capriolo wrote:
>>>>
>>>> I am pleased to be calling this vote for the source release of Apache
>>>>> Gossip
>>>>>
>>>>> Ancillary artifacts such as poms, jars, wars, ect. can be found here:
>>>>> https://repository.apache.org/content/repositories/orgapachegossip-1001
>>>>>
>>>>> The Git commit ID is:
>>>>> https://github.com/edwardcapriolo/incubator-gossip/commit/74
>>>>> 133870410fec45bd6cac39351fcbbe0950de18
>>>>>
>>>>> Which will be tagged as gossip-0.1.1-incubating
>>>>>
>>>>> https://git-wip-us.apache.org/repos/asf?p=incubator-rya.git;
>>>>> a=commit;h=66d8b7f060bddeeb7c50cb0918f98ce3b265c564
>>>>>
>>>>>
>>>>> Checksums of
>>>>> https://repository.apache.org/content/repositories/orgapache
>>>>> gossip-1001/org/apache/gossip/gossip/0.1.1-incubating/
>>>>> gossip-0.1.1-incubating-source-release.zip.asc
>>>>> :
>>>>> SHA1: 53ca6498d0f704fe7931ec23ca81a638a1fd666c
>>>>> MD5: c27067c47bdeb6133660beda908f679c
>>>>>
>>>>> Release artifacts are signed with the following key:
>>>>> http://people.apache.org/~ecapriolo/
>>>>> http://people.apache.org/~ecapriolo/ecapriolo_asf.asc
>>>>>
>>>>> KEYS file available here:
>>>>> https://dist.apache.org/repos/dist/release/incubator/rya/KEYS
>>>>>
>>>>> The vote will be open for 72 hours. Please download the release
>>>>> candidate
>>>>> and evaluate the necessary items including checking hashes, signatures,
>>>>> build from source, and test.
>>>>>
>>>>>
>>>>> Release this package?
>>>>> [ ] +1 yes
>>>>> [ ] +0 no opinion
>>>>> [ ] -1 Do not release this package because because...
>>>>>
>>>>>
>>>>> I have changed the dependency to this:
>>> https://mvnrepository.com/artifact/com.fasterxml.jackson.
>>> datatype/jackson-datatype-json-org/2.8.5
>>>
>>> <!--
>>> https://mvnrepository.com/artifact/com.fasterxml.jackson.
>>> datatype/jackson-datatype-json-org
>>> -->
>>> <dependency>
>>> <groupId>com.fasterxml.jackson.datatype</groupId>
>>> <artifactId>jackson-datatype-json-org</artifactId>
>>> <version>2.8.5</version>
>>> </dependency>
>>>
>>> Which produces this:
>>>
>>> mvn dependency:tree
>>> [INFO] --- maven-dependency-plugin:2.10:tree (default-cli) @ gossip ---
>>> [INFO] org.apache.gossip:gossip:jar:0.1.2-incubating-SNAPSHOT
>>> [INFO] +-
>>> com.fasterxml.jackson.datatype:jackson-datatype-json-org:
>>> jar:2.8.5:compile
>>> [INFO] | +- com.fasterxml.jackson.core:jackson-core:jar:2.8.5:compile
>>> [INFO] | +- com.fasterxml.jackson.core:jackson-databind:jar:2.8.5:compil
>>> e
>>> [INFO] | | \-
>>> com.fasterxml.jackson.core:jackson-annotations:jar:2.8.0:compile
>>> [INFO] | \- org.apache.geronimo.bundles:json:jar:20090211_1:compile
>>> [INFO] +- org.junit.jupiter:junit-jupiter-api:jar:5.0.0-M2:test
>>> [INFO] | +- org.opentest4j:opentest4j:jar:1.0.0-M1:test
>>> [INFO] | \- org.junit.platform:junit-platform-commons:jar:1.0.0-M2:test
>>> [INFO] +- org.junit.jupiter:junit-jupiter-engine:jar:5.0.0-M2:test
>>> [INFO] | \- org.junit.platform:junit-platform-engine:jar:1.0.0-M2:test
>>> [INFO] +- org.junit.vintage:junit-vintage-engine:jar:4.12.0-M2:test
>>> [INFO] | \- junit:junit:jar:4.12:test
>>> [INFO] | \- org.hamcrest:hamcrest-core:jar:1.3:test
>>> [INFO] +- org.junit.platform:junit-platform-runner:jar:1.0.0-M2:test
>>> [INFO] | \- org.junit.platform:junit-platform-launcher:jar:1.0.0-M2:test
>>> [INFO] +- io.teknek:tunit:jar:0.0.0:test
>>> [INFO] \- log4j:log4j:jar:1.2.17:compile
>>> [INFO]
>>> ------------------------------------------------------------------------
>>>
>>> Is this acceptable?
>>>
>>>
>> No.
>>
>> http://search.maven.org/#artifactdetails%7Corg.apache.geroni
>> mo.bundles%7Cjson%7C20090211_1%7Cbundle
>>
>> Take a look at the pom. It's just a wrapper around the same category-X
>> licensed dependency.
>>
>
Re: [VOTE] Release Gossip (Incubating) version gossip-0.1.1-incubating
Posted by Edward Capriolo <ed...@gmail.com>.
This is a bit frustrating. I have called this vote multiple times now and
each call finds something new. This dep is used by the bit that reads the
startup settings from a file. I will have to ticket this because it is more
than cosmetic.
On Tue, Jan 3, 2017 at 1:07 PM, Josh Elser <el...@apache.org> wrote:
>
>
> Edward Capriolo wrote:
>
>> On Tue, Jan 3, 2017 at 11:45 AM, Josh Elser<el...@apache.org> wrote:
>>
>> -1 due to a dependency on a project with a category-X license [1].
>>>
>>> Gossip is transitively depending on org.json:json via
>>> jackson-datatype-json-org.
>>>
>>> ```
>>> [INFO] org.apache.gossip:gossip:jar:0.1.1-incubating
>>> [INFO] +- com.fasterxml.jackson:jackson-datatype-json-org:jar:1.8.0:co
>>> mpile
>>> [INFO] | +- org.codehaus.jackson:jackson-mapper-asl:jar:1.8.6:compile
>>> [INFO] | | \- org.codehaus.jackson:jackson-core-asl:jar:1.8.6:compile
>>> [INFO] | \- org.json:json:jar:20090211:compile
>>> ```
>>>
>>> org.json:json is licensed with the JSON license which the ASF has
>>> recently
>>> moved to category-X [2]. Debian has a list of some alternatives[3] which
>>> can be used instead. This would need to be resolved before your release.
>>>
>>> I know in Calcite we use jackson-databind for JSON serialization of POJOs
>>> and that doesn't have the dependency on org.json:json. Perhaps this can
>>> be
>>> easily resolved switching the jackson dependencies and maybe some API
>>> calls.
>>>
>>> Good:
>>>
>>> * xsums/sigs match (for source-release.zip)
>>> * KEYS looks good
>>> * Can build from source
>>> * DISCLAIMER is present
>>>
>>> I see that the rc1 tag was pushed, and will assume that the next VOTE
>>> message will get that right too. Re-stating this one as I can't verify
>>> that
>>> presently.
>>>
>>> Nit:
>>>
>>> * Wrong header in the src/**/log4j.properties files. Update it to match
>>> the header in the rest of the java files. Fix for next release.
>>> * Year in NOTICE is now out of date. Fix for next release.
>>> * Use "Apache Gossip" for the first mention of "Gossip" in the README.md.
>>> Fix for next release.
>>> * Add the license text to the README and eclipse template as it's trivial
>>> to do so for both (xml and md both support "comments"). Fix for next
>>> release.
>>> * Tests failed for me (on a `mvn package`). Not a release issue, just a
>>> quality issue. I would expect that all of the tests would pass, and just
>>> wanted to mention it.
>>>
>>> ```
>>> Failed tests:
>>> ShutdownDeadtimeTest.DeadNodesDoNotComeAliveAgain:103
>>> ComparisonFailure
>>> expected:<[16]> but was:<[8]>
>>> StartupSettingsTest.testUsingSettingsFile:69 » Runtime
>>> java.net.BindException:...
>>> TenNodeThreeSeedTest.test:44->abc:78 » Runtime
>>> java.net.BindException:
>>> Address...
>>> TenNodeThreeSeedTest.testAgain:49->abc:78 » Runtime
>>> java.net.BindException: Ad...
>>> ```
>>>
>>> - Josh
>>>
>>> [1] https://www.apache.org/legal/resolved#category-x
>>> [2] https://www.apache.org/legal/resolved#json
>>> [3] https://wiki.debian.org/qa.debian.org/jsonevil
>>>
>>> Edward Capriolo wrote:
>>>
>>> I am pleased to be calling this vote for the source release of Apache
>>>> Gossip
>>>>
>>>> Ancillary artifacts such as poms, jars, wars, ect. can be found here:
>>>> https://repository.apache.org/content/repositories/orgapachegossip-1001
>>>>
>>>> The Git commit ID is:
>>>> https://github.com/edwardcapriolo/incubator-gossip/commit/74
>>>> 133870410fec45bd6cac39351fcbbe0950de18
>>>>
>>>> Which will be tagged as gossip-0.1.1-incubating
>>>>
>>>> https://git-wip-us.apache.org/repos/asf?p=incubator-rya.git;
>>>> a=commit;h=66d8b7f060bddeeb7c50cb0918f98ce3b265c564
>>>>
>>>>
>>>> Checksums of
>>>> https://repository.apache.org/content/repositories/orgapache
>>>> gossip-1001/org/apache/gossip/gossip/0.1.1-incubating/
>>>> gossip-0.1.1-incubating-source-release.zip.asc
>>>> :
>>>> SHA1: 53ca6498d0f704fe7931ec23ca81a638a1fd666c
>>>> MD5: c27067c47bdeb6133660beda908f679c
>>>>
>>>> Release artifacts are signed with the following key:
>>>> http://people.apache.org/~ecapriolo/
>>>> http://people.apache.org/~ecapriolo/ecapriolo_asf.asc
>>>>
>>>> KEYS file available here:
>>>> https://dist.apache.org/repos/dist/release/incubator/rya/KEYS
>>>>
>>>> The vote will be open for 72 hours. Please download the release
>>>> candidate
>>>> and evaluate the necessary items including checking hashes, signatures,
>>>> build from source, and test.
>>>>
>>>>
>>>> Release this package?
>>>> [ ] +1 yes
>>>> [ ] +0 no opinion
>>>> [ ] -1 Do not release this package because because...
>>>>
>>>>
>>>> I have changed the dependency to this:
>> https://mvnrepository.com/artifact/com.fasterxml.jackson.
>> datatype/jackson-datatype-json-org/2.8.5
>>
>> <!--
>> https://mvnrepository.com/artifact/com.fasterxml.jackson.
>> datatype/jackson-datatype-json-org
>> -->
>> <dependency>
>> <groupId>com.fasterxml.jackson.datatype</groupId>
>> <artifactId>jackson-datatype-json-org</artifactId>
>> <version>2.8.5</version>
>> </dependency>
>>
>> Which produces this:
>>
>> mvn dependency:tree
>> [INFO] --- maven-dependency-plugin:2.10:tree (default-cli) @ gossip ---
>> [INFO] org.apache.gossip:gossip:jar:0.1.2-incubating-SNAPSHOT
>> [INFO] +-
>> com.fasterxml.jackson.datatype:jackson-datatype-json-org:
>> jar:2.8.5:compile
>> [INFO] | +- com.fasterxml.jackson.core:jackson-core:jar:2.8.5:compile
>> [INFO] | +- com.fasterxml.jackson.core:jackson-databind:jar:2.8.5:compil
>> e
>> [INFO] | | \-
>> com.fasterxml.jackson.core:jackson-annotations:jar:2.8.0:compile
>> [INFO] | \- org.apache.geronimo.bundles:json:jar:20090211_1:compile
>> [INFO] +- org.junit.jupiter:junit-jupiter-api:jar:5.0.0-M2:test
>> [INFO] | +- org.opentest4j:opentest4j:jar:1.0.0-M1:test
>> [INFO] | \- org.junit.platform:junit-platform-commons:jar:1.0.0-M2:test
>> [INFO] +- org.junit.jupiter:junit-jupiter-engine:jar:5.0.0-M2:test
>> [INFO] | \- org.junit.platform:junit-platform-engine:jar:1.0.0-M2:test
>> [INFO] +- org.junit.vintage:junit-vintage-engine:jar:4.12.0-M2:test
>> [INFO] | \- junit:junit:jar:4.12:test
>> [INFO] | \- org.hamcrest:hamcrest-core:jar:1.3:test
>> [INFO] +- org.junit.platform:junit-platform-runner:jar:1.0.0-M2:test
>> [INFO] | \- org.junit.platform:junit-platform-launcher:jar:1.0.0-M2:test
>> [INFO] +- io.teknek:tunit:jar:0.0.0:test
>> [INFO] \- log4j:log4j:jar:1.2.17:compile
>> [INFO]
>> ------------------------------------------------------------------------
>>
>> Is this acceptable?
>>
>>
> No.
>
> http://search.maven.org/#artifactdetails%7Corg.apache.geroni
> mo.bundles%7Cjson%7C20090211_1%7Cbundle
>
> Take a look at the pom. It's just a wrapper around the same category-X
> licensed dependency.
>
Re: [VOTE] Release Gossip (Incubating) version gossip-0.1.1-incubating
Posted by Josh Elser <el...@apache.org>.
Edward Capriolo wrote:
> On Tue, Jan 3, 2017 at 11:45 AM, Josh Elser<el...@apache.org> wrote:
>
>> -1 due to a dependency on a project with a category-X license [1].
>>
>> Gossip is transitively depending on org.json:json via
>> jackson-datatype-json-org.
>>
>> ```
>> [INFO] org.apache.gossip:gossip:jar:0.1.1-incubating
>> [INFO] +- com.fasterxml.jackson:jackson-datatype-json-org:jar:1.8.0:co
>> mpile
>> [INFO] | +- org.codehaus.jackson:jackson-mapper-asl:jar:1.8.6:compile
>> [INFO] | | \- org.codehaus.jackson:jackson-core-asl:jar:1.8.6:compile
>> [INFO] | \- org.json:json:jar:20090211:compile
>> ```
>>
>> org.json:json is licensed with the JSON license which the ASF has recently
>> moved to category-X [2]. Debian has a list of some alternatives[3] which
>> can be used instead. This would need to be resolved before your release.
>>
>> I know in Calcite we use jackson-databind for JSON serialization of POJOs
>> and that doesn't have the dependency on org.json:json. Perhaps this can be
>> easily resolved switching the jackson dependencies and maybe some API calls.
>>
>> Good:
>>
>> * xsums/sigs match (for source-release.zip)
>> * KEYS looks good
>> * Can build from source
>> * DISCLAIMER is present
>>
>> I see that the rc1 tag was pushed, and will assume that the next VOTE
>> message will get that right too. Re-stating this one as I can't verify that
>> presently.
>>
>> Nit:
>>
>> * Wrong header in the src/**/log4j.properties files. Update it to match
>> the header in the rest of the java files. Fix for next release.
>> * Year in NOTICE is now out of date. Fix for next release.
>> * Use "Apache Gossip" for the first mention of "Gossip" in the README.md.
>> Fix for next release.
>> * Add the license text to the README and eclipse template as it's trivial
>> to do so for both (xml and md both support "comments"). Fix for next
>> release.
>> * Tests failed for me (on a `mvn package`). Not a release issue, just a
>> quality issue. I would expect that all of the tests would pass, and just
>> wanted to mention it.
>>
>> ```
>> Failed tests:
>> ShutdownDeadtimeTest.DeadNodesDoNotComeAliveAgain:103 ComparisonFailure
>> expected:<[16]> but was:<[8]>
>> StartupSettingsTest.testUsingSettingsFile:69 � Runtime
>> java.net.BindException:...
>> TenNodeThreeSeedTest.test:44->abc:78 � Runtime java.net.BindException:
>> Address...
>> TenNodeThreeSeedTest.testAgain:49->abc:78 � Runtime
>> java.net.BindException: Ad...
>> ```
>>
>> - Josh
>>
>> [1] https://www.apache.org/legal/resolved#category-x
>> [2] https://www.apache.org/legal/resolved#json
>> [3] https://wiki.debian.org/qa.debian.org/jsonevil
>>
>> Edward Capriolo wrote:
>>
>>> I am pleased to be calling this vote for the source release of Apache
>>> Gossip
>>>
>>> Ancillary artifacts such as poms, jars, wars, ect. can be found here:
>>> https://repository.apache.org/content/repositories/orgapachegossip-1001
>>>
>>> The Git commit ID is:
>>> https://github.com/edwardcapriolo/incubator-gossip/commit/74
>>> 133870410fec45bd6cac39351fcbbe0950de18
>>>
>>> Which will be tagged as gossip-0.1.1-incubating
>>>
>>> https://git-wip-us.apache.org/repos/asf?p=incubator-rya.git;
>>> a=commit;h=66d8b7f060bddeeb7c50cb0918f98ce3b265c564
>>>
>>>
>>> Checksums of
>>> https://repository.apache.org/content/repositories/orgapache
>>> gossip-1001/org/apache/gossip/gossip/0.1.1-incubating/
>>> gossip-0.1.1-incubating-source-release.zip.asc
>>> :
>>> SHA1: 53ca6498d0f704fe7931ec23ca81a638a1fd666c
>>> MD5: c27067c47bdeb6133660beda908f679c
>>>
>>> Release artifacts are signed with the following key:
>>> http://people.apache.org/~ecapriolo/
>>> http://people.apache.org/~ecapriolo/ecapriolo_asf.asc
>>>
>>> KEYS file available here:
>>> https://dist.apache.org/repos/dist/release/incubator/rya/KEYS
>>>
>>> The vote will be open for 72 hours. Please download the release candidate
>>> and evaluate the necessary items including checking hashes, signatures,
>>> build from source, and test.
>>>
>>>
>>> Release this package?
>>> [ ] +1 yes
>>> [ ] +0 no opinion
>>> [ ] -1 Do not release this package because because...
>>>
>>>
> I have changed the dependency to this:
> https://mvnrepository.com/artifact/com.fasterxml.jackson.datatype/jackson-datatype-json-org/2.8.5
>
> <!--
> https://mvnrepository.com/artifact/com.fasterxml.jackson.datatype/jackson-datatype-json-org
> -->
> <dependency>
> <groupId>com.fasterxml.jackson.datatype</groupId>
> <artifactId>jackson-datatype-json-org</artifactId>
> <version>2.8.5</version>
> </dependency>
>
> Which produces this:
>
> mvn dependency:tree
> [INFO] --- maven-dependency-plugin:2.10:tree (default-cli) @ gossip ---
> [INFO] org.apache.gossip:gossip:jar:0.1.2-incubating-SNAPSHOT
> [INFO] +-
> com.fasterxml.jackson.datatype:jackson-datatype-json-org:jar:2.8.5:compile
> [INFO] | +- com.fasterxml.jackson.core:jackson-core:jar:2.8.5:compile
> [INFO] | +- com.fasterxml.jackson.core:jackson-databind:jar:2.8.5:compile
> [INFO] | | \-
> com.fasterxml.jackson.core:jackson-annotations:jar:2.8.0:compile
> [INFO] | \- org.apache.geronimo.bundles:json:jar:20090211_1:compile
> [INFO] +- org.junit.jupiter:junit-jupiter-api:jar:5.0.0-M2:test
> [INFO] | +- org.opentest4j:opentest4j:jar:1.0.0-M1:test
> [INFO] | \- org.junit.platform:junit-platform-commons:jar:1.0.0-M2:test
> [INFO] +- org.junit.jupiter:junit-jupiter-engine:jar:5.0.0-M2:test
> [INFO] | \- org.junit.platform:junit-platform-engine:jar:1.0.0-M2:test
> [INFO] +- org.junit.vintage:junit-vintage-engine:jar:4.12.0-M2:test
> [INFO] | \- junit:junit:jar:4.12:test
> [INFO] | \- org.hamcrest:hamcrest-core:jar:1.3:test
> [INFO] +- org.junit.platform:junit-platform-runner:jar:1.0.0-M2:test
> [INFO] | \- org.junit.platform:junit-platform-launcher:jar:1.0.0-M2:test
> [INFO] +- io.teknek:tunit:jar:0.0.0:test
> [INFO] \- log4j:log4j:jar:1.2.17:compile
> [INFO]
> ------------------------------------------------------------------------
>
> Is this acceptable?
>
No.
http://search.maven.org/#artifactdetails%7Corg.apache.geronimo.bundles%7Cjson%7C20090211_1%7Cbundle
Take a look at the pom. It's just a wrapper around the same category-X
licensed dependency.
Re: [VOTE] Release Gossip (Incubating) version gossip-0.1.1-incubating
Posted by Edward Capriolo <ed...@gmail.com>.
On Tue, Jan 3, 2017 at 11:45 AM, Josh Elser <el...@apache.org> wrote:
> -1 due to a dependency on a project with a category-X license [1].
>
> Gossip is transitively depending on org.json:json via
> jackson-datatype-json-org.
>
> ```
> [INFO] org.apache.gossip:gossip:jar:0.1.1-incubating
> [INFO] +- com.fasterxml.jackson:jackson-datatype-json-org:jar:1.8.0:co
> mpile
> [INFO] | +- org.codehaus.jackson:jackson-mapper-asl:jar:1.8.6:compile
> [INFO] | | \- org.codehaus.jackson:jackson-core-asl:jar:1.8.6:compile
> [INFO] | \- org.json:json:jar:20090211:compile
> ```
>
> org.json:json is licensed with the JSON license which the ASF has recently
> moved to category-X [2]. Debian has a list of some alternatives[3] which
> can be used instead. This would need to be resolved before your release.
>
> I know in Calcite we use jackson-databind for JSON serialization of POJOs
> and that doesn't have the dependency on org.json:json. Perhaps this can be
> easily resolved switching the jackson dependencies and maybe some API calls.
>
> Good:
>
> * xsums/sigs match (for source-release.zip)
> * KEYS looks good
> * Can build from source
> * DISCLAIMER is present
>
> I see that the rc1 tag was pushed, and will assume that the next VOTE
> message will get that right too. Re-stating this one as I can't verify that
> presently.
>
> Nit:
>
> * Wrong header in the src/**/log4j.properties files. Update it to match
> the header in the rest of the java files. Fix for next release.
> * Year in NOTICE is now out of date. Fix for next release.
> * Use "Apache Gossip" for the first mention of "Gossip" in the README.md.
> Fix for next release.
> * Add the license text to the README and eclipse template as it's trivial
> to do so for both (xml and md both support "comments"). Fix for next
> release.
> * Tests failed for me (on a `mvn package`). Not a release issue, just a
> quality issue. I would expect that all of the tests would pass, and just
> wanted to mention it.
>
> ```
> Failed tests:
> ShutdownDeadtimeTest.DeadNodesDoNotComeAliveAgain:103 ComparisonFailure
> expected:<[16]> but was:<[8]>
> StartupSettingsTest.testUsingSettingsFile:69 » Runtime
> java.net.BindException:...
> TenNodeThreeSeedTest.test:44->abc:78 » Runtime java.net.BindException:
> Address...
> TenNodeThreeSeedTest.testAgain:49->abc:78 » Runtime
> java.net.BindException: Ad...
> ```
>
> - Josh
>
> [1] https://www.apache.org/legal/resolved#category-x
> [2] https://www.apache.org/legal/resolved#json
> [3] https://wiki.debian.org/qa.debian.org/jsonevil
>
> Edward Capriolo wrote:
>
>> I am pleased to be calling this vote for the source release of Apache
>> Gossip
>>
>> Ancillary artifacts such as poms, jars, wars, ect. can be found here:
>> https://repository.apache.org/content/repositories/orgapachegossip-1001
>>
>> The Git commit ID is:
>> https://github.com/edwardcapriolo/incubator-gossip/commit/74
>> 133870410fec45bd6cac39351fcbbe0950de18
>>
>> Which will be tagged as gossip-0.1.1-incubating
>>
>> https://git-wip-us.apache.org/repos/asf?p=incubator-rya.git;
>> a=commit;h=66d8b7f060bddeeb7c50cb0918f98ce3b265c564
>>
>>
>> Checksums of
>> https://repository.apache.org/content/repositories/orgapache
>> gossip-1001/org/apache/gossip/gossip/0.1.1-incubating/
>> gossip-0.1.1-incubating-source-release.zip.asc
>> :
>> SHA1: 53ca6498d0f704fe7931ec23ca81a638a1fd666c
>> MD5: c27067c47bdeb6133660beda908f679c
>>
>> Release artifacts are signed with the following key:
>> http://people.apache.org/~ecapriolo/
>> http://people.apache.org/~ecapriolo/ecapriolo_asf.asc
>>
>> KEYS file available here:
>> https://dist.apache.org/repos/dist/release/incubator/rya/KEYS
>>
>> The vote will be open for 72 hours. Please download the release candidate
>> and evaluate the necessary items including checking hashes, signatures,
>> build from source, and test.
>>
>>
>> Release this package?
>> [ ] +1 yes
>> [ ] +0 no opinion
>> [ ] -1 Do not release this package because because...
>>
>>
I have changed the dependency to this:
https://mvnrepository.com/artifact/com.fasterxml.jackson.datatype/jackson-datatype-json-org/2.8.5
<!--
https://mvnrepository.com/artifact/com.fasterxml.jackson.datatype/jackson-datatype-json-org
-->
<dependency>
<groupId>com.fasterxml.jackson.datatype</groupId>
<artifactId>jackson-datatype-json-org</artifactId>
<version>2.8.5</version>
</dependency>
Which produces this:
mvn dependency:tree
[INFO] --- maven-dependency-plugin:2.10:tree (default-cli) @ gossip ---
[INFO] org.apache.gossip:gossip:jar:0.1.2-incubating-SNAPSHOT
[INFO] +-
com.fasterxml.jackson.datatype:jackson-datatype-json-org:jar:2.8.5:compile
[INFO] | +- com.fasterxml.jackson.core:jackson-core:jar:2.8.5:compile
[INFO] | +- com.fasterxml.jackson.core:jackson-databind:jar:2.8.5:compile
[INFO] | | \-
com.fasterxml.jackson.core:jackson-annotations:jar:2.8.0:compile
[INFO] | \- org.apache.geronimo.bundles:json:jar:20090211_1:compile
[INFO] +- org.junit.jupiter:junit-jupiter-api:jar:5.0.0-M2:test
[INFO] | +- org.opentest4j:opentest4j:jar:1.0.0-M1:test
[INFO] | \- org.junit.platform:junit-platform-commons:jar:1.0.0-M2:test
[INFO] +- org.junit.jupiter:junit-jupiter-engine:jar:5.0.0-M2:test
[INFO] | \- org.junit.platform:junit-platform-engine:jar:1.0.0-M2:test
[INFO] +- org.junit.vintage:junit-vintage-engine:jar:4.12.0-M2:test
[INFO] | \- junit:junit:jar:4.12:test
[INFO] | \- org.hamcrest:hamcrest-core:jar:1.3:test
[INFO] +- org.junit.platform:junit-platform-runner:jar:1.0.0-M2:test
[INFO] | \- org.junit.platform:junit-platform-launcher:jar:1.0.0-M2:test
[INFO] +- io.teknek:tunit:jar:0.0.0:test
[INFO] \- log4j:log4j:jar:1.2.17:compile
[INFO]
------------------------------------------------------------------------
Is this acceptable?
Re: [VOTE] Release Gossip (Incubating) version
gossip-0.1.1-incubating
Posted by "P. Taylor Goetz" <pt...@gmail.com>.
Josh is correct that there is some wiggle room on this specific issue (json.org license). The wiggle room is that existing projects have a grace period for removing the json.org dependency, with the deadline I think being June 2017.
Since Gossip has yet to make a release, I would lean toward removing it. It would be a good demonstration to the IPMC of the podling taking efforts to comply with license policy.
> On Jan 3, 2017, at 4:54 PM, Gary Dusbabek <gd...@gmail.com> wrote:
>
> On Tue, Jan 3, 2017 at 10:45 AM, Josh Elser <el...@apache.org> wrote:
>
>> -1 due to a dependency on a project with a category-X license [1].
>>
>
> Wait. So you're saying that a transitive category-X licensed dependency is
> verboten even when we do not include the binary or the source?
>
The litmus test I use is “Can the software be used without the category-X licensed dependency?”
If the answer is “no” then it is verboten.
-Taylor
Re: [VOTE] Release Gossip (Incubating) version gossip-0.1.1-incubating
Posted by Gary Dusbabek <gd...@gmail.com>.
On Tue, Jan 3, 2017 at 10:45 AM, Josh Elser <el...@apache.org> wrote:
> -1 due to a dependency on a project with a category-X license [1].
>
Wait. So you're saying that a transitive category-X licensed dependency is
verboten even when we do not include the binary or the source?
That page doesn't do a good job describing how "include" should be
interpreted. "include" != "depend" if you ask me.
Cheers,
Gary.
>
> Gossip is transitively depending on org.json:json via
> jackson-datatype-json-org.
>
> ```
> [INFO] org.apache.gossip:gossip:jar:0.1.1-incubating
> [INFO] +- com.fasterxml.jackson:jackson-datatype-json-org:jar:1.8.0:co
> mpile
> [INFO] | +- org.codehaus.jackson:jackson-mapper-asl:jar:1.8.6:compile
> [INFO] | | \- org.codehaus.jackson:jackson-core-asl:jar:1.8.6:compile
> [INFO] | \- org.json:json:jar:20090211:compile
> ```
>
> org.json:json is licensed with the JSON license which the ASF has recently
> moved to category-X [2]. Debian has a list of some alternatives[3] which
> can be used instead. This would need to be resolved before your release.
>
> I know in Calcite we use jackson-databind for JSON serialization of POJOs
> and that doesn't have the dependency on org.json:json. Perhaps this can be
> easily resolved switching the jackson dependencies and maybe some API calls.
>
> Good:
>
> * xsums/sigs match (for source-release.zip)
> * KEYS looks good
> * Can build from source
> * DISCLAIMER is present
>
> I see that the rc1 tag was pushed, and will assume that the next VOTE
> message will get that right too. Re-stating this one as I can't verify that
> presently.
>
> Nit:
>
> * Wrong header in the src/**/log4j.properties files. Update it to match
> the header in the rest of the java files. Fix for next release.
> * Year in NOTICE is now out of date. Fix for next release.
> * Use "Apache Gossip" for the first mention of "Gossip" in the README.md.
> Fix for next release.
> * Add the license text to the README and eclipse template as it's trivial
> to do so for both (xml and md both support "comments"). Fix for next
> release.
> * Tests failed for me (on a `mvn package`). Not a release issue, just a
> quality issue. I would expect that all of the tests would pass, and just
> wanted to mention it.
>
> ```
> Failed tests:
> ShutdownDeadtimeTest.DeadNodesDoNotComeAliveAgain:103 ComparisonFailure
> expected:<[16]> but was:<[8]>
> StartupSettingsTest.testUsingSettingsFile:69 » Runtime
> java.net.BindException:...
> TenNodeThreeSeedTest.test:44->abc:78 » Runtime java.net.BindException:
> Address...
> TenNodeThreeSeedTest.testAgain:49->abc:78 » Runtime
> java.net.BindException: Ad...
> ```
>
> - Josh
>
> [1] https://www.apache.org/legal/resolved#category-x
> [2] https://www.apache.org/legal/resolved#json
> [3] https://wiki.debian.org/qa.debian.org/jsonevil
>
>
> Edward Capriolo wrote:
>
>> I am pleased to be calling this vote for the source release of Apache
>> Gossip
>>
>> Ancillary artifacts such as poms, jars, wars, ect. can be found here:
>> https://repository.apache.org/content/repositories/orgapachegossip-1001
>>
>> The Git commit ID is:
>> https://github.com/edwardcapriolo/incubator-gossip/commit/74
>> 133870410fec45bd6cac39351fcbbe0950de18
>>
>> Which will be tagged as gossip-0.1.1-incubating
>>
>> https://git-wip-us.apache.org/repos/asf?p=incubator-rya.git;
>> a=commit;h=66d8b7f060bddeeb7c50cb0918f98ce3b265c564
>>
>>
>> Checksums of
>> https://repository.apache.org/content/repositories/orgapache
>> gossip-1001/org/apache/gossip/gossip/0.1.1-incubating/
>> gossip-0.1.1-incubating-source-release.zip.asc
>> :
>> SHA1: 53ca6498d0f704fe7931ec23ca81a638a1fd666c
>> MD5: c27067c47bdeb6133660beda908f679c
>>
>> Release artifacts are signed with the following key:
>> http://people.apache.org/~ecapriolo/
>> http://people.apache.org/~ecapriolo/ecapriolo_asf.asc
>>
>> KEYS file available here:
>> https://dist.apache.org/repos/dist/release/incubator/rya/KEYS
>>
>> The vote will be open for 72 hours. Please download the release candidate
>> and evaluate the necessary items including checking hashes, signatures,
>> build from source, and test.
>>
>>
>> Release this package?
>> [ ] +1 yes
>> [ ] +0 no opinion
>> [ ] -1 Do not release this package because because...
>>
>>
Re: [VOTE] Release Gossip (Incubating) version gossip-0.1.1-incubating
Posted by Edward Capriolo <ed...@gmail.com>.
I have addressed this here:
https://issues.apache.org/jira/browse/GOSSIP-34
https://github.com/apache/incubator-gossip/pull/21
We are now doing the "dom" parsing of the startup settings with jackson. I
will let this sit for an hour or so if any committer wants to review/merge
otherwise I will merge it into trunk and than merge this into an RC.
Thanks,
Edward
On Tue, Jan 3, 2017 at 1:26 PM, Drew Farris <dr...@apache.org> wrote:
> I may be incorrect here, I need to do some research; The license issue may
> be a barrier to graduation but may not prevent releases while incubating.
> Josh, do you recall offhand?
>
> Drew
>
> On Tue, Jan 3, 2017 at 11:45 AM Josh Elser <el...@apache.org> wrote:
>
> > -1 due to a dependency on a project with a category-X license [1].
> >
> > Gossip is transitively depending on org.json:json via
> > jackson-datatype-json-org.
> >
> > ```
> > [INFO] org.apache.gossip:gossip:jar:0.1.1-incubating
> > [INFO] +- com.fasterxml.jackson:jackson-datatype-json-org:jar:1.8.0:
> compile
> > [INFO] | +- org.codehaus.jackson:jackson-mapper-asl:jar:1.8.6:compile
> > [INFO] | | \- org.codehaus.jackson:jackson-core-asl:jar:1.8.6:compile
> > [INFO] | \- org.json:json:jar:20090211:compile
> > ```
> >
> > org.json:json is licensed with the JSON license which the ASF has
> > recently moved to category-X [2]. Debian has a list of some
> > alternatives[3] which can be used instead. This would need to be
> > resolved before your release.
> >
> > I know in Calcite we use jackson-databind for JSON serialization of
> > POJOs and that doesn't have the dependency on org.json:json. Perhaps
> > this can be easily resolved switching the jackson dependencies and maybe
> > some API calls.
> >
> > Good:
> >
> > * xsums/sigs match (for source-release.zip)
> > * KEYS looks good
> > * Can build from source
> > * DISCLAIMER is present
> >
> > I see that the rc1 tag was pushed, and will assume that the next VOTE
> > message will get that right too. Re-stating this one as I can't verify
> > that presently.
> >
> > Nit:
> >
> > * Wrong header in the src/**/log4j.properties files. Update it to match
> > the header in the rest of the java files. Fix for next release.
> > * Year in NOTICE is now out of date. Fix for next release.
> > * Use "Apache Gossip" for the first mention of "Gossip" in the
> > README.md. Fix for next release.
> > * Add the license text to the README and eclipse template as it's
> > trivial to do so for both (xml and md both support "comments"). Fix for
> > next release.
> > * Tests failed for me (on a `mvn package`). Not a release issue, just a
> > quality issue. I would expect that all of the tests would pass, and just
> > wanted to mention it.
> >
> > ```
> > Failed tests:
> > ShutdownDeadtimeTest.DeadNodesDoNotComeAliveAgain:103
> > ComparisonFailure expected:<[16]> but was:<[8]>
> > StartupSettingsTest.testUsingSettingsFile:69 » Runtime
> > java.net.BindException:...
> > TenNodeThreeSeedTest.test:44->abc:78 » Runtime
> > java.net.BindException: Address...
> > TenNodeThreeSeedTest.testAgain:49->abc:78 » Runtime
> > java.net.BindException: Ad...
> > ```
> >
> > - Josh
> >
> > [1] https://www.apache.org/legal/resolved#category-x
> > [2] https://www.apache.org/legal/resolved#json
> > [3] https://wiki.debian.org/qa.debian.org/jsonevil
> >
> > Edward Capriolo wrote:
> > > I am pleased to be calling this vote for the source release of Apache
> > Gossip
> > >
> > > Ancillary artifacts such as poms, jars, wars, ect. can be found here:
> > > https://repository.apache.org/content/repositories/
> orgapachegossip-1001
> > >
> > > The Git commit ID is:
> > >
> > https://github.com/edwardcapriolo/incubator-gossip/commit/
> 74133870410fec45bd6cac39351fcbbe0950de18
> > >
> > > Which will be tagged as gossip-0.1.1-incubating
> > >
> > >
> > https://git-wip-us.apache.org/repos/asf?p=incubator-rya.git;a=commit;h=
> 66d8b7f060bddeeb7c50cb0918f98ce3b265c564
> > >
> > >
> > > Checksums of
> > >
> > https://repository.apache.org/content/repositories/
> orgapachegossip-1001/org/apache/gossip/gossip/0.1.1-
> incubating/gossip-0.1.1-incubating-source-release.zip.asc
> > > :
> > > SHA1: 53ca6498d0f704fe7931ec23ca81a638a1fd666c
> > > MD5: c27067c47bdeb6133660beda908f679c
> > >
> > > Release artifacts are signed with the following key:
> > > http://people.apache.org/~ecapriolo/
> > > http://people.apache.org/~ecapriolo/ecapriolo_asf.asc
> > >
> > > KEYS file available here:
> > > https://dist.apache.org/repos/dist/release/incubator/rya/KEYS
> > >
> > > The vote will be open for 72 hours. Please download the release
> candidate
> > > and evaluate the necessary items including checking hashes, signatures,
> > > build from source, and test.
> > >
> > >
> > > Release this package?
> > > [ ] +1 yes
> > > [ ] +0 no opinion
> > > [ ] -1 Do not release this package because because...
> > >
> >
>
Re: [VOTE] Release Gossip (Incubating) version gossip-0.1.1-incubating
Posted by Edward Capriolo <ed...@gmail.com>.
No worries I will tackle it today. I did not like the ugly class names hurt
my eyes.
import org.json.JSONObject;
STOP YELLING AT ME JSON!
On Tue, Jan 3, 2017 at 1:26 PM, Drew Farris <dr...@apache.org> wrote:
> I may be incorrect here, I need to do some research; The license issue may
> be a barrier to graduation but may not prevent releases while incubating.
> Josh, do you recall offhand?
>
> Drew
>
> On Tue, Jan 3, 2017 at 11:45 AM Josh Elser <el...@apache.org> wrote:
>
> > -1 due to a dependency on a project with a category-X license [1].
> >
> > Gossip is transitively depending on org.json:json via
> > jackson-datatype-json-org.
> >
> > ```
> > [INFO] org.apache.gossip:gossip:jar:0.1.1-incubating
> > [INFO] +- com.fasterxml.jackson:jackson-datatype-json-org:jar:1.8.0:
> compile
> > [INFO] | +- org.codehaus.jackson:jackson-mapper-asl:jar:1.8.6:compile
> > [INFO] | | \- org.codehaus.jackson:jackson-core-asl:jar:1.8.6:compile
> > [INFO] | \- org.json:json:jar:20090211:compile
> > ```
> >
> > org.json:json is licensed with the JSON license which the ASF has
> > recently moved to category-X [2]. Debian has a list of some
> > alternatives[3] which can be used instead. This would need to be
> > resolved before your release.
> >
> > I know in Calcite we use jackson-databind for JSON serialization of
> > POJOs and that doesn't have the dependency on org.json:json. Perhaps
> > this can be easily resolved switching the jackson dependencies and maybe
> > some API calls.
> >
> > Good:
> >
> > * xsums/sigs match (for source-release.zip)
> > * KEYS looks good
> > * Can build from source
> > * DISCLAIMER is present
> >
> > I see that the rc1 tag was pushed, and will assume that the next VOTE
> > message will get that right too. Re-stating this one as I can't verify
> > that presently.
> >
> > Nit:
> >
> > * Wrong header in the src/**/log4j.properties files. Update it to match
> > the header in the rest of the java files. Fix for next release.
> > * Year in NOTICE is now out of date. Fix for next release.
> > * Use "Apache Gossip" for the first mention of "Gossip" in the
> > README.md. Fix for next release.
> > * Add the license text to the README and eclipse template as it's
> > trivial to do so for both (xml and md both support "comments"). Fix for
> > next release.
> > * Tests failed for me (on a `mvn package`). Not a release issue, just a
> > quality issue. I would expect that all of the tests would pass, and just
> > wanted to mention it.
> >
> > ```
> > Failed tests:
> > ShutdownDeadtimeTest.DeadNodesDoNotComeAliveAgain:103
> > ComparisonFailure expected:<[16]> but was:<[8]>
> > StartupSettingsTest.testUsingSettingsFile:69 » Runtime
> > java.net.BindException:...
> > TenNodeThreeSeedTest.test:44->abc:78 » Runtime
> > java.net.BindException: Address...
> > TenNodeThreeSeedTest.testAgain:49->abc:78 » Runtime
> > java.net.BindException: Ad...
> > ```
> >
> > - Josh
> >
> > [1] https://www.apache.org/legal/resolved#category-x
> > [2] https://www.apache.org/legal/resolved#json
> > [3] https://wiki.debian.org/qa.debian.org/jsonevil
> >
> > Edward Capriolo wrote:
> > > I am pleased to be calling this vote for the source release of Apache
> > Gossip
> > >
> > > Ancillary artifacts such as poms, jars, wars, ect. can be found here:
> > > https://repository.apache.org/content/repositories/
> orgapachegossip-1001
> > >
> > > The Git commit ID is:
> > >
> > https://github.com/edwardcapriolo/incubator-gossip/commit/
> 74133870410fec45bd6cac39351fcbbe0950de18
> > >
> > > Which will be tagged as gossip-0.1.1-incubating
> > >
> > >
> > https://git-wip-us.apache.org/repos/asf?p=incubator-rya.git;a=commit;h=
> 66d8b7f060bddeeb7c50cb0918f98ce3b265c564
> > >
> > >
> > > Checksums of
> > >
> > https://repository.apache.org/content/repositories/
> orgapachegossip-1001/org/apache/gossip/gossip/0.1.1-
> incubating/gossip-0.1.1-incubating-source-release.zip.asc
> > > :
> > > SHA1: 53ca6498d0f704fe7931ec23ca81a638a1fd666c
> > > MD5: c27067c47bdeb6133660beda908f679c
> > >
> > > Release artifacts are signed with the following key:
> > > http://people.apache.org/~ecapriolo/
> > > http://people.apache.org/~ecapriolo/ecapriolo_asf.asc
> > >
> > > KEYS file available here:
> > > https://dist.apache.org/repos/dist/release/incubator/rya/KEYS
> > >
> > > The vote will be open for 72 hours. Please download the release
> candidate
> > > and evaluate the necessary items including checking hashes, signatures,
> > > build from source, and test.
> > >
> > >
> > > Release this package?
> > > [ ] +1 yes
> > > [ ] +0 no opinion
> > > [ ] -1 Do not release this package because because...
> > >
> >
>
Re: [VOTE] Release Gossip (Incubating) version gossip-0.1.1-incubating
Posted by Josh Elser <el...@apache.org>.
There is likely some wiggle room, but, without good reason as to why
it's too onerous to fix now, I'd prefer to not explore that space.
Understanding the licenses on Gossip's dependencies is something the
podling as a whole needs to monitor/track on their own. This is not
nearly as terrible as many other TLPs, so I'd like to be a force some
immediate action here.
If this isn't a quick fix, I'm happy to step off of my soapbox. I'll let
Ed comment to that effect (but I think there's a PR up already, so I
assume it's not).
Drew Farris wrote:
> I may be incorrect here, I need to do some research; The license issue may
> be a barrier to graduation but may not prevent releases while incubating.
> Josh, do you recall offhand?
>
> Drew
>
> On Tue, Jan 3, 2017 at 11:45 AM Josh Elser<el...@apache.org> wrote:
>
>> -1 due to a dependency on a project with a category-X license [1].
>>
>> Gossip is transitively depending on org.json:json via
>> jackson-datatype-json-org.
>>
>> ```
>> [INFO] org.apache.gossip:gossip:jar:0.1.1-incubating
>> [INFO] +- com.fasterxml.jackson:jackson-datatype-json-org:jar:1.8.0:compile
>> [INFO] | +- org.codehaus.jackson:jackson-mapper-asl:jar:1.8.6:compile
>> [INFO] | | \- org.codehaus.jackson:jackson-core-asl:jar:1.8.6:compile
>> [INFO] | \- org.json:json:jar:20090211:compile
>> ```
>>
>> org.json:json is licensed with the JSON license which the ASF has
>> recently moved to category-X [2]. Debian has a list of some
>> alternatives[3] which can be used instead. This would need to be
>> resolved before your release.
>>
>> I know in Calcite we use jackson-databind for JSON serialization of
>> POJOs and that doesn't have the dependency on org.json:json. Perhaps
>> this can be easily resolved switching the jackson dependencies and maybe
>> some API calls.
>>
>> Good:
>>
>> * xsums/sigs match (for source-release.zip)
>> * KEYS looks good
>> * Can build from source
>> * DISCLAIMER is present
>>
>> I see that the rc1 tag was pushed, and will assume that the next VOTE
>> message will get that right too. Re-stating this one as I can't verify
>> that presently.
>>
>> Nit:
>>
>> * Wrong header in the src/**/log4j.properties files. Update it to match
>> the header in the rest of the java files. Fix for next release.
>> * Year in NOTICE is now out of date. Fix for next release.
>> * Use "Apache Gossip" for the first mention of "Gossip" in the
>> README.md. Fix for next release.
>> * Add the license text to the README and eclipse template as it's
>> trivial to do so for both (xml and md both support "comments"). Fix for
>> next release.
>> * Tests failed for me (on a `mvn package`). Not a release issue, just a
>> quality issue. I would expect that all of the tests would pass, and just
>> wanted to mention it.
>>
>> ```
>> Failed tests:
>> ShutdownDeadtimeTest.DeadNodesDoNotComeAliveAgain:103
>> ComparisonFailure expected:<[16]> but was:<[8]>
>> StartupSettingsTest.testUsingSettingsFile:69 � Runtime
>> java.net.BindException:...
>> TenNodeThreeSeedTest.test:44->abc:78 � Runtime
>> java.net.BindException: Address...
>> TenNodeThreeSeedTest.testAgain:49->abc:78 � Runtime
>> java.net.BindException: Ad...
>> ```
>>
>> - Josh
>>
>> [1] https://www.apache.org/legal/resolved#category-x
>> [2] https://www.apache.org/legal/resolved#json
>> [3] https://wiki.debian.org/qa.debian.org/jsonevil
>>
>> Edward Capriolo wrote:
>>> I am pleased to be calling this vote for the source release of Apache
>> Gossip
>>> Ancillary artifacts such as poms, jars, wars, ect. can be found here:
>>> https://repository.apache.org/content/repositories/orgapachegossip-1001
>>>
>>> The Git commit ID is:
>>>
>> https://github.com/edwardcapriolo/incubator-gossip/commit/74133870410fec45bd6cac39351fcbbe0950de18
>>> Which will be tagged as gossip-0.1.1-incubating
>>>
>>>
>> https://git-wip-us.apache.org/repos/asf?p=incubator-rya.git;a=commit;h=66d8b7f060bddeeb7c50cb0918f98ce3b265c564
>>>
>>> Checksums of
>>>
>> https://repository.apache.org/content/repositories/orgapachegossip-1001/org/apache/gossip/gossip/0.1.1-incubating/gossip-0.1.1-incubating-source-release.zip.asc
>>> :
>>> SHA1: 53ca6498d0f704fe7931ec23ca81a638a1fd666c
>>> MD5: c27067c47bdeb6133660beda908f679c
>>>
>>> Release artifacts are signed with the following key:
>>> http://people.apache.org/~ecapriolo/
>>> http://people.apache.org/~ecapriolo/ecapriolo_asf.asc
>>>
>>> KEYS file available here:
>>> https://dist.apache.org/repos/dist/release/incubator/rya/KEYS
>>>
>>> The vote will be open for 72 hours. Please download the release candidate
>>> and evaluate the necessary items including checking hashes, signatures,
>>> build from source, and test.
>>>
>>>
>>> Release this package?
>>> [ ] +1 yes
>>> [ ] +0 no opinion
>>> [ ] -1 Do not release this package because because...
>>>
>
Re: [VOTE] Release Gossip (Incubating) version gossip-0.1.1-incubating
Posted by Drew Farris <dr...@apache.org>.
I may be incorrect here, I need to do some research; The license issue may
be a barrier to graduation but may not prevent releases while incubating.
Josh, do you recall offhand?
Drew
On Tue, Jan 3, 2017 at 11:45 AM Josh Elser <el...@apache.org> wrote:
> -1 due to a dependency on a project with a category-X license [1].
>
> Gossip is transitively depending on org.json:json via
> jackson-datatype-json-org.
>
> ```
> [INFO] org.apache.gossip:gossip:jar:0.1.1-incubating
> [INFO] +- com.fasterxml.jackson:jackson-datatype-json-org:jar:1.8.0:compile
> [INFO] | +- org.codehaus.jackson:jackson-mapper-asl:jar:1.8.6:compile
> [INFO] | | \- org.codehaus.jackson:jackson-core-asl:jar:1.8.6:compile
> [INFO] | \- org.json:json:jar:20090211:compile
> ```
>
> org.json:json is licensed with the JSON license which the ASF has
> recently moved to category-X [2]. Debian has a list of some
> alternatives[3] which can be used instead. This would need to be
> resolved before your release.
>
> I know in Calcite we use jackson-databind for JSON serialization of
> POJOs and that doesn't have the dependency on org.json:json. Perhaps
> this can be easily resolved switching the jackson dependencies and maybe
> some API calls.
>
> Good:
>
> * xsums/sigs match (for source-release.zip)
> * KEYS looks good
> * Can build from source
> * DISCLAIMER is present
>
> I see that the rc1 tag was pushed, and will assume that the next VOTE
> message will get that right too. Re-stating this one as I can't verify
> that presently.
>
> Nit:
>
> * Wrong header in the src/**/log4j.properties files. Update it to match
> the header in the rest of the java files. Fix for next release.
> * Year in NOTICE is now out of date. Fix for next release.
> * Use "Apache Gossip" for the first mention of "Gossip" in the
> README.md. Fix for next release.
> * Add the license text to the README and eclipse template as it's
> trivial to do so for both (xml and md both support "comments"). Fix for
> next release.
> * Tests failed for me (on a `mvn package`). Not a release issue, just a
> quality issue. I would expect that all of the tests would pass, and just
> wanted to mention it.
>
> ```
> Failed tests:
> ShutdownDeadtimeTest.DeadNodesDoNotComeAliveAgain:103
> ComparisonFailure expected:<[16]> but was:<[8]>
> StartupSettingsTest.testUsingSettingsFile:69 » Runtime
> java.net.BindException:...
> TenNodeThreeSeedTest.test:44->abc:78 » Runtime
> java.net.BindException: Address...
> TenNodeThreeSeedTest.testAgain:49->abc:78 » Runtime
> java.net.BindException: Ad...
> ```
>
> - Josh
>
> [1] https://www.apache.org/legal/resolved#category-x
> [2] https://www.apache.org/legal/resolved#json
> [3] https://wiki.debian.org/qa.debian.org/jsonevil
>
> Edward Capriolo wrote:
> > I am pleased to be calling this vote for the source release of Apache
> Gossip
> >
> > Ancillary artifacts such as poms, jars, wars, ect. can be found here:
> > https://repository.apache.org/content/repositories/orgapachegossip-1001
> >
> > The Git commit ID is:
> >
> https://github.com/edwardcapriolo/incubator-gossip/commit/74133870410fec45bd6cac39351fcbbe0950de18
> >
> > Which will be tagged as gossip-0.1.1-incubating
> >
> >
> https://git-wip-us.apache.org/repos/asf?p=incubator-rya.git;a=commit;h=66d8b7f060bddeeb7c50cb0918f98ce3b265c564
> >
> >
> > Checksums of
> >
> https://repository.apache.org/content/repositories/orgapachegossip-1001/org/apache/gossip/gossip/0.1.1-incubating/gossip-0.1.1-incubating-source-release.zip.asc
> > :
> > SHA1: 53ca6498d0f704fe7931ec23ca81a638a1fd666c
> > MD5: c27067c47bdeb6133660beda908f679c
> >
> > Release artifacts are signed with the following key:
> > http://people.apache.org/~ecapriolo/
> > http://people.apache.org/~ecapriolo/ecapriolo_asf.asc
> >
> > KEYS file available here:
> > https://dist.apache.org/repos/dist/release/incubator/rya/KEYS
> >
> > The vote will be open for 72 hours. Please download the release candidate
> > and evaluate the necessary items including checking hashes, signatures,
> > build from source, and test.
> >
> >
> > Release this package?
> > [ ] +1 yes
> > [ ] +0 no opinion
> > [ ] -1 Do not release this package because because...
> >
>
Re: [VOTE] Release Gossip (Incubating) version gossip-0.1.1-incubating
Posted by Josh Elser <el...@apache.org>.
-1 due to a dependency on a project with a category-X license [1].
Gossip is transitively depending on org.json:json via
jackson-datatype-json-org.
```
[INFO] org.apache.gossip:gossip:jar:0.1.1-incubating
[INFO] +- com.fasterxml.jackson:jackson-datatype-json-org:jar:1.8.0:compile
[INFO] | +- org.codehaus.jackson:jackson-mapper-asl:jar:1.8.6:compile
[INFO] | | \- org.codehaus.jackson:jackson-core-asl:jar:1.8.6:compile
[INFO] | \- org.json:json:jar:20090211:compile
```
org.json:json is licensed with the JSON license which the ASF has
recently moved to category-X [2]. Debian has a list of some
alternatives[3] which can be used instead. This would need to be
resolved before your release.
I know in Calcite we use jackson-databind for JSON serialization of
POJOs and that doesn't have the dependency on org.json:json. Perhaps
this can be easily resolved switching the jackson dependencies and maybe
some API calls.
Good:
* xsums/sigs match (for source-release.zip)
* KEYS looks good
* Can build from source
* DISCLAIMER is present
I see that the rc1 tag was pushed, and will assume that the next VOTE
message will get that right too. Re-stating this one as I can't verify
that presently.
Nit:
* Wrong header in the src/**/log4j.properties files. Update it to match
the header in the rest of the java files. Fix for next release.
* Year in NOTICE is now out of date. Fix for next release.
* Use "Apache Gossip" for the first mention of "Gossip" in the
README.md. Fix for next release.
* Add the license text to the README and eclipse template as it's
trivial to do so for both (xml and md both support "comments"). Fix for
next release.
* Tests failed for me (on a `mvn package`). Not a release issue, just a
quality issue. I would expect that all of the tests would pass, and just
wanted to mention it.
```
Failed tests:
ShutdownDeadtimeTest.DeadNodesDoNotComeAliveAgain:103
ComparisonFailure expected:<[16]> but was:<[8]>
StartupSettingsTest.testUsingSettingsFile:69 � Runtime
java.net.BindException:...
TenNodeThreeSeedTest.test:44->abc:78 � Runtime
java.net.BindException: Address...
TenNodeThreeSeedTest.testAgain:49->abc:78 � Runtime
java.net.BindException: Ad...
```
- Josh
[1] https://www.apache.org/legal/resolved#category-x
[2] https://www.apache.org/legal/resolved#json
[3] https://wiki.debian.org/qa.debian.org/jsonevil
Edward Capriolo wrote:
> I am pleased to be calling this vote for the source release of Apache Gossip
>
> Ancillary artifacts such as poms, jars, wars, ect. can be found here:
> https://repository.apache.org/content/repositories/orgapachegossip-1001
>
> The Git commit ID is:
> https://github.com/edwardcapriolo/incubator-gossip/commit/74133870410fec45bd6cac39351fcbbe0950de18
>
> Which will be tagged as gossip-0.1.1-incubating
>
> https://git-wip-us.apache.org/repos/asf?p=incubator-rya.git;a=commit;h=66d8b7f060bddeeb7c50cb0918f98ce3b265c564
>
>
> Checksums of
> https://repository.apache.org/content/repositories/orgapachegossip-1001/org/apache/gossip/gossip/0.1.1-incubating/gossip-0.1.1-incubating-source-release.zip.asc
> :
> SHA1: 53ca6498d0f704fe7931ec23ca81a638a1fd666c
> MD5: c27067c47bdeb6133660beda908f679c
>
> Release artifacts are signed with the following key:
> http://people.apache.org/~ecapriolo/
> http://people.apache.org/~ecapriolo/ecapriolo_asf.asc
>
> KEYS file available here:
> https://dist.apache.org/repos/dist/release/incubator/rya/KEYS
>
> The vote will be open for 72 hours. Please download the release candidate
> and evaluate the necessary items including checking hashes, signatures,
> build from source, and test.
>
>
> Release this package?
> [ ] +1 yes
> [ ] +0 no opinion
> [ ] -1 Do not release this package because because...
>