You are viewing a plain text version of this content. The canonical link for it is here.
Posted to reviews@kudu.apache.org by "Alexey Serbin (Code Review)" <ge...@cloudera.org> on 2018/02/21 15:58:57 UTC
[kudu-CR] [itests] fix flake in raft consensus nonvoter-itest
Alexey Serbin has uploaded this change for review. ( http://gerrit.cloudera.org:8080/9380
Change subject: [itests] fix flake in raft_consensus_nonvoter-itest
......................................................................
[itests] fix flake in raft_consensus_nonvoter-itest
Fixed flake in RaftConsensusNonVoterITest::RestartClusterWithNonVoter
scenario in the case when a newly added replica becomes a leader.
The flake was most prominent with ASAN builds. Below are links to the
dist_test results of ASAN builds, with and without the fix:
before the fix (51 of 256 failed):
http://dist-test.cloudera.org/job?job_id=aserbin.1519227435.49089
after the fix (0 of 256 failed):
http://dist-test.cloudera.org/job?job_id=aserbin.1519227218.43636
Change-Id: I0b27eec4e9a4727b96689d4e9592b1f1684ebf54
---
M src/kudu/integration-tests/raft_consensus_nonvoter-itest.cc
1 file changed, 5 insertions(+), 0 deletions(-)
git pull ssh://gerrit.cloudera.org:29418/kudu refs/changes/80/9380/1
--
To view, visit http://gerrit.cloudera.org:8080/9380
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings
Gerrit-Project: kudu
Gerrit-Branch: master
Gerrit-MessageType: newchange
Gerrit-Change-Id: I0b27eec4e9a4727b96689d4e9592b1f1684ebf54
Gerrit-Change-Number: 9380
Gerrit-PatchSet: 1
Gerrit-Owner: Alexey Serbin <as...@cloudera.com>
[kudu-CR] [itests] fix flake in raft consensus nonvoter-itest
Posted by "Alexey Serbin (Code Review)" <ge...@cloudera.org>.
Hello Kudu Jenkins,
I'd like you to reexamine a change. Please visit
http://gerrit.cloudera.org:8080/9380
to look at the new patch set (#2).
Change subject: [itests] fix flake in raft_consensus_nonvoter-itest
......................................................................
[itests] fix flake in raft_consensus_nonvoter-itest
Fixed flake in RaftConsensusNonVoterITest::RestartClusterWithNonVoter
scenario in the case when a newly added replica becomes a leader.
The flake was most prominent with ASAN builds. Below are links to the
dist_test results of ASAN builds, with and without the fix:
before the fix (50 of 256 failed):
http://dist-test.cloudera.org/job?job_id=aserbin.1519227435.49089
after the fix (0 of 256 failed):
http://dist-test.cloudera.org/job?job_id=aserbin.1519227218.43636
Change-Id: I0b27eec4e9a4727b96689d4e9592b1f1684ebf54
---
M src/kudu/integration-tests/raft_consensus_nonvoter-itest.cc
1 file changed, 5 insertions(+), 0 deletions(-)
git pull ssh://gerrit.cloudera.org:29418/kudu refs/changes/80/9380/2
--
To view, visit http://gerrit.cloudera.org:8080/9380
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings
Gerrit-Project: kudu
Gerrit-Branch: master
Gerrit-MessageType: newpatchset
Gerrit-Change-Id: I0b27eec4e9a4727b96689d4e9592b1f1684ebf54
Gerrit-Change-Number: 9380
Gerrit-PatchSet: 2
Gerrit-Owner: Alexey Serbin <as...@cloudera.com>
Gerrit-Reviewer: Kudu Jenkins
[kudu-CR] [itests] fix flake in raft consensus nonvoter-itest
Posted by "Mike Percy (Code Review)" <ge...@cloudera.org>.
Mike Percy has posted comments on this change. ( http://gerrit.cloudera.org:8080/9380 )
Change subject: [itests] fix flake in raft_consensus_nonvoter-itest
......................................................................
Patch Set 2: Code-Review+2
--
To view, visit http://gerrit.cloudera.org:8080/9380
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings
Gerrit-Project: kudu
Gerrit-Branch: master
Gerrit-MessageType: comment
Gerrit-Change-Id: I0b27eec4e9a4727b96689d4e9592b1f1684ebf54
Gerrit-Change-Number: 9380
Gerrit-PatchSet: 2
Gerrit-Owner: Alexey Serbin <as...@cloudera.com>
Gerrit-Reviewer: Alexey Serbin <as...@cloudera.com>
Gerrit-Reviewer: Kudu Jenkins
Gerrit-Reviewer: Mike Percy <mp...@apache.org>
Gerrit-Reviewer: Tidy Bot
Gerrit-Reviewer: Todd Lipcon <to...@apache.org>
Gerrit-Comment-Date: Wed, 21 Feb 2018 20:54:48 +0000
Gerrit-HasComments: No
[kudu-CR] [itests] fix flake in raft consensus nonvoter-itest
Posted by "Alexey Serbin (Code Review)" <ge...@cloudera.org>.
Alexey Serbin has submitted this change and it was merged. ( http://gerrit.cloudera.org:8080/9380 )
Change subject: [itests] fix flake in raft_consensus_nonvoter-itest
......................................................................
[itests] fix flake in raft_consensus_nonvoter-itest
Fixed flake in RaftConsensusNonVoterITest::RestartClusterWithNonVoter
scenario in the case when a newly added replica becomes a leader.
The flake was most prominent with ASAN builds. Below are links to the
dist_test results of ASAN builds, with and without the fix:
before the fix (50 of 256 failed):
http://dist-test.cloudera.org/job?job_id=aserbin.1519227435.49089
after the fix (0 of 256 failed):
http://dist-test.cloudera.org/job?job_id=aserbin.1519227218.43636
Change-Id: I0b27eec4e9a4727b96689d4e9592b1f1684ebf54
Reviewed-on: http://gerrit.cloudera.org:8080/9380
Tested-by: Kudu Jenkins
Reviewed-by: Mike Percy <mp...@apache.org>
---
M src/kudu/integration-tests/raft_consensus_nonvoter-itest.cc
1 file changed, 5 insertions(+), 0 deletions(-)
Approvals:
Kudu Jenkins: Verified
Mike Percy: Looks good to me, approved
--
To view, visit http://gerrit.cloudera.org:8080/9380
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings
Gerrit-Project: kudu
Gerrit-Branch: master
Gerrit-MessageType: merged
Gerrit-Change-Id: I0b27eec4e9a4727b96689d4e9592b1f1684ebf54
Gerrit-Change-Number: 9380
Gerrit-PatchSet: 3
Gerrit-Owner: Alexey Serbin <as...@cloudera.com>
Gerrit-Reviewer: Alexey Serbin <as...@cloudera.com>
Gerrit-Reviewer: Kudu Jenkins
Gerrit-Reviewer: Mike Percy <mp...@apache.org>
Gerrit-Reviewer: Tidy Bot
Gerrit-Reviewer: Todd Lipcon <to...@apache.org>
[kudu-CR] [itests] fix flake in raft consensus nonvoter-itest
Posted by "Alexey Serbin (Code Review)" <ge...@cloudera.org>.
Alexey Serbin has posted comments on this change. ( http://gerrit.cloudera.org:8080/9380 )
Change subject: [itests] fix flake in raft_consensus_nonvoter-itest
......................................................................
Patch Set 2:
(1 comment)
http://gerrit.cloudera.org:8080/#/c/9380/1/src/kudu/integration-tests/raft_consensus_nonvoter-itest.cc
File src/kudu/integration-tests/raft_consensus_nonvoter-itest.cc:
http://gerrit.cloudera.org:8080/#/c/9380/1/src/kudu/integration-tests/raft_consensus_nonvoter-itest.cc@35
PS1, Line 35: #include "kudu/consensus/metadata.pb.h"
> error: 'kudu/consensus/metadata.pb.h' file not found [clang-diagnostic-erro
This looks like a fluke, so I'm going to ignore this clang-diagnostic-error.
--
To view, visit http://gerrit.cloudera.org:8080/9380
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings
Gerrit-Project: kudu
Gerrit-Branch: master
Gerrit-MessageType: comment
Gerrit-Change-Id: I0b27eec4e9a4727b96689d4e9592b1f1684ebf54
Gerrit-Change-Number: 9380
Gerrit-PatchSet: 2
Gerrit-Owner: Alexey Serbin <as...@cloudera.com>
Gerrit-Reviewer: Alexey Serbin <as...@cloudera.com>
Gerrit-Reviewer: Kudu Jenkins
Gerrit-Reviewer: Mike Percy <mp...@apache.org>
Gerrit-Reviewer: Tidy Bot
Gerrit-Reviewer: Todd Lipcon <to...@apache.org>
Gerrit-Comment-Date: Wed, 21 Feb 2018 18:10:48 +0000
Gerrit-HasComments: Yes