You are viewing a plain text version of this content. The canonical link for it is here.
Posted to reviews@impala.apache.org by "Joe McDonnell (Code Review)" <ge...@cloudera.org> on 2018/06/11 22:41:16 UTC
[Impala-ASF-CR] Optimize dependencies for Codegen
Joe McDonnell has uploaded this change for review. ( http://gerrit.cloudera.org:8080/10688
Change subject: Optimize dependencies for Codegen
......................................................................
Optimize dependencies for Codegen
Pieces of the Codegen library (impala-(no-)sse-ir.cc)
depend on Exec, Exprs, Runtime, Udf, and Util. These
extra dependencies prevent Codegen from being built
in parallel to these other components. This extends
the build, especially on systems using high parallelism
such as distcc.
As far as I can tell, these dependencies are not
necessary. This replaces those dependencies with gen-deps.
Testing:
- I forced all targets other than Codegen to wait
5 minutes after gen-deps completes to start
building. This forces Codegen to build without any of
the currently listed dependencies. It built
successfully and I made sure that the following
files were identical to a build without this change:
- be/generated-sources/impala-ir/*
- llvm-ir/*
- I ran the core tests, and they were clean except for
known unrelated issues.
Change-Id: Ie3294cd27c2d35388a04934440a1d2b0ba3a0dd9
---
M be/src/codegen/CMakeLists.txt
1 file changed, 2 insertions(+), 2 deletions(-)
git pull ssh://gerrit.cloudera.org:29418/Impala-ASF refs/changes/88/10688/1
--
To view, visit http://gerrit.cloudera.org:8080/10688
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings
Gerrit-Project: Impala-ASF
Gerrit-Branch: master
Gerrit-MessageType: newchange
Gerrit-Change-Id: Ie3294cd27c2d35388a04934440a1d2b0ba3a0dd9
Gerrit-Change-Number: 10688
Gerrit-PatchSet: 1
Gerrit-Owner: Joe McDonnell <jo...@cloudera.com>
[Impala-ASF-CR] Optimize dependencies for Codegen
Posted by "Joe McDonnell (Code Review)" <ge...@cloudera.org>.
Joe McDonnell has abandoned this change. ( http://gerrit.cloudera.org:8080/10688 )
Change subject: Optimize dependencies for Codegen
......................................................................
Abandoned
This has a flawed dependency graph.
--
To view, visit http://gerrit.cloudera.org:8080/10688
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings
Gerrit-Project: Impala-ASF
Gerrit-Branch: master
Gerrit-MessageType: abandon
Gerrit-Change-Id: Ie3294cd27c2d35388a04934440a1d2b0ba3a0dd9
Gerrit-Change-Number: 10688
Gerrit-PatchSet: 1
Gerrit-Owner: Joe McDonnell <jo...@cloudera.com>
Gerrit-Reviewer: Dan Hecht <dh...@cloudera.com>
Gerrit-Reviewer: Impala Public Jenkins <im...@cloudera.com>
Gerrit-Reviewer: Joe McDonnell <jo...@cloudera.com>
[Impala-ASF-CR] Optimize dependencies for Codegen
Posted by "Impala Public Jenkins (Code Review)" <ge...@cloudera.org>.
Impala Public Jenkins has posted comments on this change. ( http://gerrit.cloudera.org:8080/10688 )
Change subject: Optimize dependencies for Codegen
......................................................................
Patch Set 1: Verified+1
--
To view, visit http://gerrit.cloudera.org:8080/10688
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings
Gerrit-Project: Impala-ASF
Gerrit-Branch: master
Gerrit-MessageType: comment
Gerrit-Change-Id: Ie3294cd27c2d35388a04934440a1d2b0ba3a0dd9
Gerrit-Change-Number: 10688
Gerrit-PatchSet: 1
Gerrit-Owner: Joe McDonnell <jo...@cloudera.com>
Gerrit-Reviewer: Impala Public Jenkins <im...@cloudera.com>
Gerrit-Comment-Date: Tue, 12 Jun 2018 19:15:12 +0000
Gerrit-HasComments: No
[Impala-ASF-CR] Optimize dependencies for Codegen
Posted by "Joe McDonnell (Code Review)" <ge...@cloudera.org>.
Joe McDonnell has posted comments on this change. ( http://gerrit.cloudera.org:8080/10688 )
Change subject: Optimize dependencies for Codegen
......................................................................
Patch Set 1:
> Looks like the current way was done as a result of IMPALA-1896.
> Could you check that JIRA to see if removing this will cause that
> problem?
This has that problem. I am abandoning this change.
--
To view, visit http://gerrit.cloudera.org:8080/10688
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings
Gerrit-Project: Impala-ASF
Gerrit-Branch: master
Gerrit-MessageType: comment
Gerrit-Change-Id: Ie3294cd27c2d35388a04934440a1d2b0ba3a0dd9
Gerrit-Change-Number: 10688
Gerrit-PatchSet: 1
Gerrit-Owner: Joe McDonnell <jo...@cloudera.com>
Gerrit-Reviewer: Dan Hecht <dh...@cloudera.com>
Gerrit-Reviewer: Impala Public Jenkins <im...@cloudera.com>
Gerrit-Reviewer: Joe McDonnell <jo...@cloudera.com>
Gerrit-Comment-Date: Fri, 15 Jun 2018 20:07:58 +0000
Gerrit-HasComments: No
[Impala-ASF-CR] Optimize dependencies for Codegen
Posted by "Impala Public Jenkins (Code Review)" <ge...@cloudera.org>.
Impala Public Jenkins has posted comments on this change. ( http://gerrit.cloudera.org:8080/10688 )
Change subject: Optimize dependencies for Codegen
......................................................................
Patch Set 1: Verified-1
Build failed: https://jenkins.impala.io/job/gerrit-verify-dryrun/2633/
--
To view, visit http://gerrit.cloudera.org:8080/10688
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings
Gerrit-Project: Impala-ASF
Gerrit-Branch: master
Gerrit-MessageType: comment
Gerrit-Change-Id: Ie3294cd27c2d35388a04934440a1d2b0ba3a0dd9
Gerrit-Change-Number: 10688
Gerrit-PatchSet: 1
Gerrit-Owner: Joe McDonnell <jo...@cloudera.com>
Gerrit-Reviewer: Impala Public Jenkins <im...@cloudera.com>
Gerrit-Comment-Date: Tue, 12 Jun 2018 02:25:28 +0000
Gerrit-HasComments: No
[Impala-ASF-CR] Optimize dependencies for Codegen
Posted by "Dan Hecht (Code Review)" <ge...@cloudera.org>.
Dan Hecht has posted comments on this change. ( http://gerrit.cloudera.org:8080/10688 )
Change subject: Optimize dependencies for Codegen
......................................................................
Patch Set 1:
Looks like the current way was done as a result of IMPALA-1896. Could you check that JIRA to see if removing this will cause that problem?
--
To view, visit http://gerrit.cloudera.org:8080/10688
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings
Gerrit-Project: Impala-ASF
Gerrit-Branch: master
Gerrit-MessageType: comment
Gerrit-Change-Id: Ie3294cd27c2d35388a04934440a1d2b0ba3a0dd9
Gerrit-Change-Number: 10688
Gerrit-PatchSet: 1
Gerrit-Owner: Joe McDonnell <jo...@cloudera.com>
Gerrit-Reviewer: Dan Hecht <dh...@cloudera.com>
Gerrit-Reviewer: Impala Public Jenkins <im...@cloudera.com>
Gerrit-Comment-Date: Thu, 14 Jun 2018 20:58:50 +0000
Gerrit-HasComments: No
[Impala-ASF-CR] Optimize dependencies for Codegen
Posted by "Impala Public Jenkins (Code Review)" <ge...@cloudera.org>.
Impala Public Jenkins has posted comments on this change. ( http://gerrit.cloudera.org:8080/10688 )
Change subject: Optimize dependencies for Codegen
......................................................................
Patch Set 1:
Build started: https://jenkins.impala.io/job/gerrit-verify-dryrun/2633/
--
To view, visit http://gerrit.cloudera.org:8080/10688
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings
Gerrit-Project: Impala-ASF
Gerrit-Branch: master
Gerrit-MessageType: comment
Gerrit-Change-Id: Ie3294cd27c2d35388a04934440a1d2b0ba3a0dd9
Gerrit-Change-Number: 10688
Gerrit-PatchSet: 1
Gerrit-Owner: Joe McDonnell <jo...@cloudera.com>
Gerrit-Reviewer: Impala Public Jenkins <im...@cloudera.com>
Gerrit-Comment-Date: Mon, 11 Jun 2018 23:20:00 +0000
Gerrit-HasComments: No
[Impala-ASF-CR] Optimize dependencies for Codegen
Posted by "Impala Public Jenkins (Code Review)" <ge...@cloudera.org>.
Impala Public Jenkins has posted comments on this change. ( http://gerrit.cloudera.org:8080/10688 )
Change subject: Optimize dependencies for Codegen
......................................................................
Patch Set 1:
Build started: https://jenkins.impala.io/job/gerrit-verify-dryrun/2637/
--
To view, visit http://gerrit.cloudera.org:8080/10688
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings
Gerrit-Project: Impala-ASF
Gerrit-Branch: master
Gerrit-MessageType: comment
Gerrit-Change-Id: Ie3294cd27c2d35388a04934440a1d2b0ba3a0dd9
Gerrit-Change-Number: 10688
Gerrit-PatchSet: 1
Gerrit-Owner: Joe McDonnell <jo...@cloudera.com>
Gerrit-Reviewer: Impala Public Jenkins <im...@cloudera.com>
Gerrit-Comment-Date: Tue, 12 Jun 2018 15:55:42 +0000
Gerrit-HasComments: No
[Impala-ASF-CR] Optimize dependencies for Codegen
Posted by "Impala Public Jenkins (Code Review)" <ge...@cloudera.org>.
Impala Public Jenkins has posted comments on this change. ( http://gerrit.cloudera.org:8080/10688 )
Change subject: Optimize dependencies for Codegen
......................................................................
Patch Set 1:
Build started: https://jenkins.impala.io/job/gerrit-verify-dryrun/2633/
--
To view, visit http://gerrit.cloudera.org:8080/10688
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings
Gerrit-Project: Impala-ASF
Gerrit-Branch: master
Gerrit-MessageType: comment
Gerrit-Change-Id: Ie3294cd27c2d35388a04934440a1d2b0ba3a0dd9
Gerrit-Change-Number: 10688
Gerrit-PatchSet: 1
Gerrit-Owner: Joe McDonnell <jo...@cloudera.com>
Gerrit-Reviewer: Impala Public Jenkins <im...@cloudera.com>
Gerrit-Comment-Date: Mon, 11 Jun 2018 23:20:01 +0000
Gerrit-HasComments: No