You are viewing a plain text version of this content. The canonical link for it is here.
Posted to commits@pulsar.apache.org by GitBox <gi...@apache.org> on 2022/09/01 01:51:31 UTC
[GitHub] [pulsar] labuladong opened a new issue, #17384: [Doc] Remove first and last newline in code block
labuladong opened a new issue, #17384:
URL: https://github.com/apache/pulsar/issues/17384
### Search before asking
- [X] I searched in the [issues](https://github.com/apache/pulsar/issues) and found nothing similar.
### What issue do you find in Pulsar docs?
Every code block in [pulsar document](https://pulsar.apache.org/docs/) has redundant newlines:
<img width="1123" alt="image" src="https://user-images.githubusercontent.com/37220920/187814413-695a34cc-42de-4e5d-b1dd-779f650daa91.png">
If I click the copy button, `\n` was copied as well, which is inconvenient to change args and may run commands unexpectedly because of the tailing `\n`:
### What is your suggestion?
Trim all redundant newlines of code blocks like this:
<img width="1110" alt="image" src="https://user-images.githubusercontent.com/37220920/187815034-da01d19c-84f2-4818-83f5-13e4fa9f40e1.png">
### Any reference?
_No response_
### Are you willing to submit a PR?
- [X] I'm willing to submit a PR!
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@pulsar.apache.org.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [pulsar] momo-jun commented on issue #17384: [Doc] Remove first and last newline in code block
Posted by GitBox <gi...@apache.org>.
momo-jun commented on issue #17384:
URL: https://github.com/apache/pulsar/issues/17384#issuecomment-1233644530
I'm working on this. https://github.com/apache/pulsar/pull/17355
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@pulsar.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [pulsar] labuladong commented on issue #17384: [Doc] Remove first and last newline in code block
Posted by GitBox <gi...@apache.org>.
labuladong commented on issue #17384:
URL: https://github.com/apache/pulsar/issues/17384#issuecomment-1233647598
> I've already been working on this: #17355.
Seems great, thanks. I'll close this issue.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@pulsar.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [pulsar] tisonkun commented on issue #17384: [Doc] Remove first and last newline in code block
Posted by GitBox <gi...@apache.org>.
tisonkun commented on issue #17384:
URL: https://github.com/apache/pulsar/issues/17384#issuecomment-1233641625
cc @Anonymitaet @momo-jun @Huanli-Meng
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@pulsar.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [pulsar] labuladong closed issue #17384: [Doc] Remove first and last newline in code block
Posted by GitBox <gi...@apache.org>.
labuladong closed issue #17384: [Doc] Remove first and last newline in code block
URL: https://github.com/apache/pulsar/issues/17384
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@pulsar.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [pulsar] tisonkun commented on issue #17384: [Doc] Remove first and last newline in code block
Posted by GitBox <gi...@apache.org>.
tisonkun commented on issue #17384:
URL: https://github.com/apache/pulsar/issues/17384#issuecomment-1233640443
Make sense. I'm doing this when touching related documents. I don't make a patch to apply it globally yet, though. If you have some time to do it and we get two or more committers' approval, we can try to take the move. Otherwise, it's quite easily to conflict with continuous contributions.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@pulsar.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org