You are viewing a plain text version of this content. The canonical link for it is here.
Posted to commits@dolphinscheduler.apache.org by GitBox <gi...@apache.org> on 2021/11/07 11:48:17 UTC
[GitHub] [dolphinscheduler] ruanwenjun opened a new pull request #6729: [Feature][SPI] Add DolphinSPILoader
ruanwenjun opened a new pull request #6729:
URL: https://github.com/apache/dolphinscheduler/pull/6729
related issue #6612
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@dolphinscheduler.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [dolphinscheduler] kezhenxu94 commented on pull request #6729: [Feature][SPI] Add DolphinSPILoader
Posted by GitBox <gi...@apache.org>.
kezhenxu94 commented on pull request #6729:
URL: https://github.com/apache/dolphinscheduler/pull/6729#issuecomment-962597387
I think https://github.com/apache/dolphinscheduler/pull/6712 has already simplified the development and usage of the SPI mechanism. I personally think that Java native SPI is already easy to use and the DolphinScheduler’s plugin mechanism is kind of over designed.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@dolphinscheduler.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [dolphinscheduler] ruanwenjun commented on pull request #6729: [Feature][SPI] Add DolphinSPILoader
Posted by GitBox <gi...@apache.org>.
ruanwenjun commented on pull request #6729:
URL: https://github.com/apache/dolphinscheduler/pull/6729#issuecomment-962597771
> I think #6712 has already simplified the development and usage of the SPI mechanism. I personally think that Java native SPI is already easy to use and the DolphinScheduler’s plugin mechanism is kind of over designed.
Great, I will close this pr.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@dolphinscheduler.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [dolphinscheduler] ruanwenjun closed pull request #6729: [Feature][SPI] Add DolphinSPILoader
Posted by GitBox <gi...@apache.org>.
ruanwenjun closed pull request #6729:
URL: https://github.com/apache/dolphinscheduler/pull/6729
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@dolphinscheduler.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [dolphinscheduler] kezhenxu94 commented on pull request #6729: [Feature][SPI] Add DolphinSPILoader
Posted by GitBox <gi...@apache.org>.
kezhenxu94 commented on pull request #6729:
URL: https://github.com/apache/dolphinscheduler/pull/6729#issuecomment-962597805
https://github.com/apache/dolphinscheduler/pull/6723 Is another optimization of the alert plugins. I’ll continue to optimize the task plugins and finally we can get rid of the over designed plugin loader and Java developer will find it familiar and comfortable to develop a new plugin. For users it’s also easy to use the plugins without pain
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@dolphinscheduler.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org