You are viewing a plain text version of this content. The canonical link for it is here.
Posted to issues@hugegraph.apache.org by "VGalaxies (via GitHub)" <gi...@apache.org> on 2024/07/15 15:58:08 UTC

[PR] chore: intro editorconfig-maven-plugin for validating and appling code style in `.editorconfig` [incubator-hugegraph]

VGalaxies opened a new pull request, #2591:
URL: https://github.com/apache/incubator-hugegraph/pull/2591

   follow up #2561
   
   - check code style during the validate phase of the build
   - use `mvn editorconfig:format` for one-click code formatting


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: issues-unsubscribe@hugegraph.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org


---------------------------------------------------------------------
To unsubscribe, e-mail: issues-unsubscribe@hugegraph.apache.org
For additional commands, e-mail: issues-help@hugegraph.apache.org


Re: [PR] chore: intro `editorconfig-maven-plugin` for verifying code style defined in `.editorconfig` [incubator-hugegraph]

Posted by "JackyYangPassion (via GitHub)" <gi...@apache.org>.
JackyYangPassion merged PR #2591:
URL: https://github.com/apache/incubator-hugegraph/pull/2591


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: issues-unsubscribe@hugegraph.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org


---------------------------------------------------------------------
To unsubscribe, e-mail: issues-unsubscribe@hugegraph.apache.org
For additional commands, e-mail: issues-help@hugegraph.apache.org


Re: [PR] chore: intro `editorconfig-maven-plugin` for verifying code style defined in `.editorconfig` [incubator-hugegraph]

Posted by "VGalaxies (via GitHub)" <gi...@apache.org>.
VGalaxies commented on PR #2591:
URL: https://github.com/apache/incubator-hugegraph/pull/2591#issuecomment-2230385935

   > Thanks, maybe could paste a screenshot for it?
   > 
   > And wonder to know if the old files break the rule, what will happen? (Stop building? Or just warn it?)
   > 
   > PS: The approve button was pressed by mistake and can be ignored :)
   
   In the verify phase, the code style will be checked, and if it does not comply, an error will be reported, as shown in the figure below:
   
   ![image](https://github.com/user-attachments/assets/11f4c6f3-4568-4ff9-ba3f-4f2d291bc222)
   
   **Important:** It has been found that the `editorconfig-maven-plugin` doesn't support Java at the moment: for now the plugin has support to enforce coding style rules for other languages such as XML and YAML. This means that options with the `ij_` prefix in `.editorconfig` will not be applied, as these options are generic IntelliJ options and need to be used with the IDE.
   
   > 1. https://stackoverflow.com/questions/75801441/how-to-format-java-code-based-on-editorconfig-file
   > 
   > 2. https://intellij-support.jetbrains.com/hc/en-us/community/posts/10650008517650--Coding-style-Does-Idea-propose-a-standalone-tool-to-format-java-code-with-editorconfig
   
   


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: issues-unsubscribe@hugegraph.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org


---------------------------------------------------------------------
To unsubscribe, e-mail: issues-unsubscribe@hugegraph.apache.org
For additional commands, e-mail: issues-help@hugegraph.apache.org


Re: [PR] chore: intro `editorconfig-maven-plugin` for validating code style in `.editorconfig` [incubator-hugegraph]

Posted by "codecov[bot] (via GitHub)" <gi...@apache.org>.
codecov[bot] commented on PR #2591:
URL: https://github.com/apache/incubator-hugegraph/pull/2591#issuecomment-2228992953

   ## [Codecov](https://app.codecov.io/gh/apache/incubator-hugegraph/pull/2591?dropdown=coverage&src=pr&el=h1&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) Report
   All modified and coverable lines are covered by tests :white_check_mark:
   > Project coverage is 38.81%. Comparing base [(`85e0966`)](https://app.codecov.io/gh/apache/incubator-hugegraph/commit/85e096698ad38b4c45056569a1dfd0a5398be557?dropdown=coverage&el=desc&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) to head [(`faa70e3`)](https://app.codecov.io/gh/apache/incubator-hugegraph/commit/faa70e32c6bdff428100cc944c421a8c9139bde8?dropdown=coverage&el=desc&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache).
   
   > :exclamation:  There is a different number of reports uploaded between BASE (85e0966) and HEAD (faa70e3). Click for more details.
   > 
   > <details><summary>HEAD has 4 uploads less than BASE</summary>
   >
   >| Flag | BASE (85e0966) | HEAD (faa70e3) |
   >|------|------|------|
   >||5|1|
   ></details>
   
   <details><summary>Additional details and impacted files</summary>
   
   
   ```diff
   @@              Coverage Diff              @@
   ##             master    #2591       +/-   ##
   =============================================
   - Coverage     51.31%   38.81%   -12.50%     
   + Complexity      679      272      -407     
   =============================================
     Files           643      643               
     Lines         53364    53364               
     Branches       7017     7017               
   =============================================
   - Hits          27382    20712     -6670     
   - Misses        23223    30307     +7084     
   + Partials       2759     2345      -414     
   ```
   
   </details>
   
   [:umbrella: View full report in Codecov by Sentry](https://app.codecov.io/gh/apache/incubator-hugegraph/pull/2591?dropdown=coverage&src=pr&el=continue&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache).   
   :loudspeaker: Have feedback on the report? [Share it here](https://about.codecov.io/codecov-pr-comment-feedback/?utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache).
   


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: issues-unsubscribe@hugegraph.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org


---------------------------------------------------------------------
To unsubscribe, e-mail: issues-unsubscribe@hugegraph.apache.org
For additional commands, e-mail: issues-help@hugegraph.apache.org