You are viewing a plain text version of this content. The canonical link for it is here.

Posted to jira@kafka.apache.org by GitBox <gi...@apache.org> on 2022/06/12 09:58:11 UTC

[GitHub] [kafka] divijvaidya commented on pull request #12285: KAFKA-7342 Part 1: Straightforward JUnit4 to JUnit5 migrations

divijvaidya commented on PR #12285:
URL: https://github.com/apache/kafka/pull/12285#issuecomment-1153118745

   Thanks you submitting this change @clolov. This would greatly help us in moving towards getting rid of JUnit4 completely.
   
   1\ To make the code review easier, could we please tackle the `Run IntelliJ's Optimize Imports and streams:spotlessApply on the streams module.` in a separate review? I would drastically decrease the number of files changed and help us reviewing the code in a better manner.
   
   2\ I agree with (and appreciate) your incremental approach towards this migration. We can handle the tests using parameterised separately. 
   
   3\ It would be helpful if you can document the high level changes required for the migration from Junit4 to Junit5 in the description of this PR.


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: jira-unsubscribe@kafka.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org