You are viewing a plain text version of this content. The canonical link for it is here.
Posted to issues@flink.apache.org by GitBox <gi...@apache.org> on 2019/12/11 05:50:30 UTC
[GitHub] [flink] JingsongLi commented on a change in pull request #10514:
[FLINK-15167][sql-client] SQL CLI library option doesn't work for Hive
connector
JingsongLi commented on a change in pull request #10514: [FLINK-15167][sql-client] SQL CLI library option doesn't work for Hive connector
URL: https://github.com/apache/flink/pull/10514#discussion_r356411828
##########
File path: flink-table/flink-sql-client/src/main/java/org/apache/flink/table/client/gateway/local/ExecutionContext.java
##########
@@ -337,6 +342,11 @@ private Module createModule(Map<String, String> moduleProperties, ClassLoader cl
return factory.createModule(moduleProperties);
}
+ private void createAndRegisterCatalog(String name, CatalogEntry entry) {
Review comment:
just inline this method?
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
With regards,
Apache Git Services